Re: [PATCH] kunit: executor: Remove const from kunit_filter_suites() allocation type

[David Gow <davidgow@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

On Sat, 26 Apr 2025 at 14:24, Kees Cook <kees@kernel.org> wrote:
>
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
>
> The assigned type is "struct kunit_suite **" but the returned type will
> be "struct kunit_suite * const *". Since it isn't generally possible
> to remove the const qualifier, adjust the allocation type to match
> the assignment.
>
> Signed-off-by: Kees Cook <kees@kernel.org>
> ---
> Cc: Brendan Higgins <brendan.higgins@linux.dev>
> Cc: David Gow <davidgow@google.com>
> Cc: Rae Moar <rmoar@google.com>
> Cc: <linux-kselftest@vger.kernel.org>
> Cc: <kunit-dev@googlegroups.com>
> ---

Nice catch!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  lib/kunit/executor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> index 3f39955cb0f1..0061d4c7e351 100644
> --- a/lib/kunit/executor.c
> +++ b/lib/kunit/executor.c
> @@ -177,7 +177,7 @@ kunit_filter_suites(const struct kunit_suite_set *suite_set,
>
>         const size_t max = suite_set->end - suite_set->start;
>
> -       copy = kcalloc(max, sizeof(*filtered.start), GFP_KERNEL);
> +       copy = kcalloc(max, sizeof(*copy), GFP_KERNEL);
>         if (!copy) { /* won't be able to run anything, return an empty set */
>                 return filtered;
>         }
> --
> 2.34.1
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5281 bytes --]