From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33008C6369E for ; Thu, 3 Dec 2020 03:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB6B821D91 for ; Thu, 3 Dec 2020 03:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727658AbgLCDGQ (ORCPT ); Wed, 2 Dec 2020 22:06:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgLCDGP (ORCPT ); Wed, 2 Dec 2020 22:06:15 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BC32C061A4F for ; Wed, 2 Dec 2020 19:05:35 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id d8so608664lfa.1 for ; Wed, 02 Dec 2020 19:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fZfjFj0HnOPxDFc3+iS8mDidBdv6khuB8oFfMET/GKI=; b=u66lDIvqTNO9kjjQ2rLurjG7k042fHc8I+LGB1GaopW0Wzq1fo68Lg3tYclhHdyyj+ P/b6j9/SPhuBsfvwZNf0XBrTUkAYj5pfUF6ENf+tlTqrpvqdXx7MCEz+QeLVVTPE8+7Q oFgVPiC3gs7AonDTk2bMELyj8+2wuT/wxZGJMMD5xr1V/u+N16BlC2rYt38C3tbdRqOq xtvqpT0kEoJLGU+Y8g+IyvUXsfOq/8QTSpUnr4fuBqiKiDQCQB6Us6Zo8pbKdKyUT3M9 JSBdb1ElHz23dZ0dhi8V1ZPsPRNbq9n+RbsQ0nGD5oToWIcR6VJNUh5BhQhVTR2T1A3Y jlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fZfjFj0HnOPxDFc3+iS8mDidBdv6khuB8oFfMET/GKI=; b=tBBCSFW24hLBnzxDmpIzBwBTqOl564yqM1RtuIqCJNhB28qDt2uT6lrMIm6dC1Mu5D HT3b6vWWXmStjgO9VigQJ0HyUv+Nm4yaurGvuYtNs1B5BGV/lQFJmmT+uzzvPjdbV2ML VZiPTfzmDBNiaQKftMjN7mNAgPmvR2AcGT0hGf60JQ3+J4nvCKF4d4en/Jlg0lpC2nqq mzD10ip5SiurFzU918q5osUP2DnBpAMQ4QKUdrWxnW9j0xGfHGqGIQtPKKBQGLlEyX3x qlxcLyRSkrsZ/9md0hQ7KatoZaHRks15Vs8y6pYM5xUfolvFXeyJe/715dUBmXLfOIco cMcw== X-Gm-Message-State: AOAM530wzfdFDaIApKVj9L+SOc8d8tew4oskvGyYNFC01HTXi5dfZOwU dNGSUJhQABo1mL/IR7YMThb2uQ1E7NHGKew8fnoeSw== X-Google-Smtp-Source: ABdhPJz3uwU3OoJjqR4+1l9Ui0xIUrD2q3MRpQ1iNbJ8+r/KWnAmLW7YkvTQKvIjA1nhCoGe/AGb1DFSfK1tv9zaaCo= X-Received: by 2002:a19:246:: with SMTP id 67mr420225lfc.234.1606964733349; Wed, 02 Dec 2020 19:05:33 -0800 (PST) MIME-Version: 1.0 References: <20201202190824.1309398-1-dlatypov@google.com> In-Reply-To: <20201202190824.1309398-1-dlatypov@google.com> From: David Gow Date: Thu, 3 Dec 2020 11:05:21 +0800 Message-ID: Subject: Re: [PATCH v2 1/4] kunit: tool: fix unit test cleanup handling To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov wrote: > > * Stop leaking file objects. > * Use self.addCleanup() to ensure we call cleanup functions even if > setUp() fails. > * use mock.patch.stopall instead of more error-prone manual approach > > Signed-off-by: Daniel Latypov > --- This patch hasn't changed since v1, right? It's still: Reviewed-by: David Gow Cheers, -- David