From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFEDC07E9C for ; Wed, 7 Jul 2021 23:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E0BC61CC4 for ; Wed, 7 Jul 2021 23:32:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbhGGXfT (ORCPT ); Wed, 7 Jul 2021 19:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbhGGXfP (ORCPT ); Wed, 7 Jul 2021 19:35:15 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FFFAC061574; Wed, 7 Jul 2021 16:32:34 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id j34so2865229wms.5; Wed, 07 Jul 2021 16:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VQfug0IHv4zPVKKbJZrt/5kYXexS/UlEn7UIdBqjdy0=; b=LAWwwJqdNgjFcpi4SE+Ab48hR+5topHfVlfE1xj5KtLe5QirRqVneBa/P5KlxU6syQ Ns5eUckdJE9rhr8LCBBp0RVl6TdCd1Xf+gKWPkBMtuWKHuF8xcuxq3C4QwIPAh3ytaZr pURIMUCXlcMsknxknx5gPxW7JRO89FoVZRn2Q4yvzFgUwoj07qYez2RELuxAl4wF6yZp yH9sXSKr44EN6a50SByQalvAUtNeBLIuOngHqK83lBKaeoCtn5qPT50SkJfUS9yfQHsx FEon4AhUXeE56LpEnoahkpn0hZp37xOgHhmgpu1FTJfo+Ry95ixR7NfZO0pXGBm8eyZF CNew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VQfug0IHv4zPVKKbJZrt/5kYXexS/UlEn7UIdBqjdy0=; b=BzDRkZC696CPcqNZy78wg0msbK1DKLl9J16UBntS+Bbsciwgs4yunkJ1+vTwk8U69U h6S4/gCYJuDB14FsUCh7c+T3U1Gvl2u48UhlhsX8XEc6f43wrCRo3NZSyO/hT2Xqi5Ww rrHjkKL3zrUllSE8IyeouM82P7ediQz/LOQ69bCM4n1o96jy560/IZhAAwmypBhEnBFq jzASNkKGTd/feXzqa3j2AkVTrWx432WXkX4sziBlN8pJ3M2hbaPJi8fKfWsyOmrbhNY7 pMGCUQVyTj0lFOMLozXqrPKZYXVj/6HJUGgIN/Ys+FatSW91s+CgbbfTIIm4ohm3JIX6 /9Cg== X-Gm-Message-State: AOAM530tlMaA2ih7WQWzCs6mKojToTPjfD+MeFVWhMGWzVSAq2syjLYw M0GsWuKTic/Id6idgeeedhcIN7UJFXjsouY/nwM= X-Google-Smtp-Source: ABdhPJwPoDiNqiFkOfb2Qdr5lC15YXtFZuvpIyIUyx67hU04fAjkhwuzb0CqPqbNCnQoOA+B0MY22o19Dsvy/c/qEuY= X-Received: by 2002:a1c:7915:: with SMTP id l21mr1680459wme.62.1625700753215; Wed, 07 Jul 2021 16:32:33 -0700 (PDT) MIME-Version: 1.0 References: <20210707155633.1486603-1-mudongliangabcd@gmail.com> In-Reply-To: From: Alexander Aring Date: Wed, 7 Jul 2021 19:32:22 -0400 Message-ID: Subject: Re: [PATCH] ieee802154: hwsim: fix GPF in hwsim_new_edge_nl To: Dongliang Mu Cc: Stefan Schmidt , "David S. Miller" , Jakub Kicinski , Alexander Aring , linux-wpan - ML , "open list:NETWORKING [GENERAL]" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 7 Jul 2021 at 19:15, Dongliang Mu wrote: > > On Thu, Jul 8, 2021 at 2:55 AM Alexander Aring wrote: > > > > Hi, > > > > On Wed, 7 Jul 2021 at 12:11, Dongliang Mu wrote: > > > > > > On Wed, Jul 7, 2021 at 11:56 PM Dongliang Mu wrote: > > > > > > > > Both MAC802154_HWSIM_ATTR_RADIO_ID and MAC802154_HWSIM_ATTR_RADIO_EDGE > > > > must be present to fix GPF. > > > > > > I double-check the whole file, and there is only one similar issue > > > left in Line 421. > > > > > > > What about "hwsim_del_edge_nl()" line 483, I think it has the same issue? > > Eric already submitted a patch [1] to fix this function and the patch > is already merged in the mainline. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0303b30375dff5351a79cc2c3c87dfa4fda29bed ah, yes. Thanks. - Alex