mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: "Joonwon Kang" <joonwonkang@google.com>,
	"Subhash Jadavani" <sjadavani@google.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Lucas Wei" <lucaswei@google.com>,
	"Brian Norris" <briannorris@chromium.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 7/7] mailbox: goog-mba: Introduce the goog-mba mailbox driver
Date: Sat, 19 Sep 2026 13:32:44 -0500	[thread overview]
Message-ID: <CABb+yY2_AvcnaTDmpL8gP4H2_Pp3HddrtNr5gvL4GCW2DPPvOw@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=XiguzS7nH1sE=BkXt+7G6-hhqyz5u3sjc4zAA9H7KqJg@mail.gmail.com>

On Wed, Sep 9, 2026 at 11:57 AM Doug Anderson <dianders@chromium.org> wrote:
>
> > I am suggesting to consider TX-Is-Done when send_data() returns, i.e
> > tx submitted is seen as transferred. You anyway  don't catch
> > transmission errors. That way you fill all slots without blocking on
> > the first message and achieve this same throughput.
> > Without knowing the clients I am not sure if that can't be done.
>
> We need to know the txdone and thus we can't do what you're proposing.
> In general, queuing mailboxes are used in cases where the remote side
> enables a resource like a clock or power domain. Different tasks in
> the system may independently turn on/off these resources, so allowing
> them to work "in parallel" makes sense
>
It will still work in parallel - you still keep writing to the h/w
fifo without waiting for previous ones to finish as long as there is
space. Just like you get here.

. ...but each task needs to know
> for sure when its resource is finished turning on. If we just imagine
> 3 clocks we want to turn on.
>
> clk_enable(clk_a)
> clk_enable(clk_b)
> clk_enable(clk_c)
>
> Those 3 calls can be made in 3 different contexts from 3 different
> drivers. We want all 3 enables happening in parallel with each other
> (not one after another), but each call needs to know when its function
> is done.
>
I don't see why not?  The three requests will be queued into h/w fifo
in the order they arrive without any block - just as you do now.

Btw, if you mean they need to be enabled in parallel literally, they
should not be called from three different drivers. Instead they should
be modelled as one "composite" clock.

> Does that make sense?
>
The usage makes sense but I still don't see why existing api can't work.

Regards,
Jassi

  reply	other threads:[~2026-09-19 18:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 22:21 [PATCH 0/7] mailbox: Improve the mbox core then introduce the goog-mba driver Douglas Anderson
2026-07-14 22:21 ` [PATCH 1/7] dt-bindings: mailbox: Don't require #mbox-cells to be 1 Douglas Anderson
2026-07-22 14:02   ` Rob Herring
2026-08-04 20:42     ` Doug Anderson
2026-07-14 22:21 ` [PATCH 2/7] mailbox: Allow #mbox-cells = <0> without specifying a custom xlate Douglas Anderson
2026-07-14 22:21 ` [PATCH 3/7] mailbox: Find a matching mailbox by fwnode rather than device Douglas Anderson
2026-07-14 22:21 ` [PATCH 4/7] mailbox: Simplify circular queue math with mod arithmetic Douglas Anderson
2026-07-14 22:21 ` [PATCH 5/7] mailbox: Add support for mailbox controllers that can queue Douglas Anderson
2026-07-14 22:21 ` [PATCH 6/7] dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings Douglas Anderson
2026-07-15  4:51   ` Krzysztof Kozlowski
2026-07-15 16:49     ` Doug Anderson
2026-07-16  5:46       ` Krzysztof Kozlowski
2026-07-16 16:31         ` Doug Anderson
2026-07-22 17:11           ` Doug Anderson
2026-07-29 13:27             ` Jassi Brar
2026-07-31 21:24               ` Doug Anderson
2026-07-22 14:10       ` Rob Herring
2026-07-22 16:57         ` Doug Anderson
2026-07-14 22:21 ` [PATCH 7/7] mailbox: goog-mba: Introduce the goog-mba mailbox driver Douglas Anderson
2026-09-06  1:20   ` Jassi Brar
2026-09-09 15:53     ` Doug Anderson
2026-09-09 16:34       ` Jassi Brar
2026-09-09 16:56         ` Doug Anderson
2026-09-19 18:32           ` Jassi Brar [this message]
2026-09-19 20:40             ` Doug Anderson
2026-09-20 20:29               ` Jassi Brar
2026-09-20 21:39                 ` Doug Anderson
2026-09-20 22:46                   ` Jassi Brar
2026-09-21 22:18                     ` Doug Anderson
2026-09-22  0:11                       ` Jassi Brar
2026-09-22 16:01                         ` Doug Anderson
2026-09-23  0:23                           ` Jassi Brar
2026-09-28 21:34                             ` Doug Anderson
2026-10-09  6:36                               ` Krzysztof Kozlowski
2026-10-09  8:41                                 ` Doug Anderson
2026-10-09 15:43                                   ` Jassi Brar
2026-10-10  9:16                                     ` Doug Anderson
2026-10-18 18:04                               ` Jassi Brar
2026-10-10 10:15   ` Markus Elfring
2026-10-12 15:52     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABb+yY2_AvcnaTDmpL8gP4H2_Pp3HddrtNr5gvL4GCW2DPPvOw@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=andre.draszik@linaro.org \
    --cc=briannorris@chromium.org \
    --cc=dianders@chromium.org \
    --cc=joonwonkang@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lucaswei@google.com \
    --cc=peter.griffin@linaro.org \
    --cc=sjadavani@google.com \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®