From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB7BF3EF0A5 for ; Sat, 28 Feb 2026 13:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=170.10.133.124 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772287022; cv=pass; b=LNCCrt5bg3ebxOFFGaT6z37Nqy50F6oB7SfPsxZnq1c2pHrHirXDtUwW2wO9u1yg9xPRyM0Tf7QqlFC56exbm0TnroY2gpE9BIZIpek6Djo/l43jdKlK/PZfs7GJKz1ASZSAzybmPzFuQu2+fPhsXLyJAPL31h3czhuXB88Y4iM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772287022; c=relaxed/simple; bh=folcasxC8R85n2b8wnCDU1NJVS3iOEobjI0icOIulEk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SLKIdgKWFrj/nUH1ZPIXxZed+2y0OFMN1hLIg1eUj7g6fM0jByg2Y7z+XCWUW1jgTXpsEhj9hZmnLlrvVQBLyTc09z6eLcTlTj6i0O65L8ij9yjOn81FcFiKxzbifIUvl/joXYX8H16rdRIX1Y9NqUJbC6GaEmMHg1ba66zNWyk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P3UmGw5U; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ssnDYfWe; arc=pass smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P3UmGw5U"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ssnDYfWe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772287018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lPeE6tJ7LvztkqM9H/hBuFs1UkdrH4QjKz/WrRBZT6k=; b=P3UmGw5UeA8/suhLWs4nCu7fjZ/c75w5pacTbw3IYi0G6jU/2XvNceuF+OLc56TPp7vJyM Ss2iYG3i/nH0gT89sr8Sevl13TQPiN7uyy+hyqdKnN+d2SbRd5fHp+gv9EKpqQ3ZNt3TOr wQuDWITKG3d+j+ZHZ+d8EGSSjqLo3EE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-FceV_pDfMZOWy_3PgSAkqQ-1; Sat, 28 Feb 2026 08:56:56 -0500 X-MC-Unique: FceV_pDfMZOWy_3PgSAkqQ-1 X-Mimecast-MFC-AGG-ID: FceV_pDfMZOWy_3PgSAkqQ_1772287016 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso39824915e9.1 for ; Sat, 28 Feb 2026 05:56:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772287015; cv=none; d=google.com; s=arc-20240605; b=iLIacFiTkwSXWHIJ6/NsIUkW06GCQrtL+Vdrdpb70Hl03KER7LYiVHXvTiV795+64m MGas9KMZ3Asy0VdYmocjof66cdNtCZEIkAtEHijL2/Ko8t+Q7WBh3AJbld70acwLoyFw vo98EpccspajpZiqdgPRggPsD0XoD5/1xRJeGxts+JmImxlc3hgRUDg1HN+BxhhCK98a tq9wvTy+PG1puMOZsJLxL3nZAjr0nM0bgoe+GbI4dPP8iRGq1gLrRdZnve0HV3vquEG2 IiuVvwydYTvYM+nVLpaB7RPbSMBY+jgrd6aiWWFOaHKQeRIJ832RmyQNgX7wWAX9JZKL FlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lPeE6tJ7LvztkqM9H/hBuFs1UkdrH4QjKz/WrRBZT6k=; fh=acQ9c1PqyLRweXx7wxtKICCzxxycNgrMe1d/WAU5t4U=; b=O89AINHsMw67h/+WrfVYLLyuUCaDGVczLuvzoExxBW0MPkP+rzWFPDsfKW3/7w/5EB r3JZE9p1NzwsM2r427ACLT0L4yxKokBmjeIalcYQmdzv/JQCE92KqpOlsWC4NwHFw3ZD Yc5V+M2aN4SFO0/J0Qy7Vpt8xgpXCCr1RirRt+cshsnnt3OPHVhhPDAR6bVzZfebyksY Q4AnCoZDUYG01zpaxyNrk2NDMWJoJQ5y+Ugn/8Tg7KhZ3xAMeUtYIm1//fk6qdZLlv4h sUrTcCdcIDMhE+FKFn2WNHm/MsgX4BqXvjN5d5qlHCRbgiPD7/MPglUCCtMe5YTcih0U fqXA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772287015; x=1772891815; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lPeE6tJ7LvztkqM9H/hBuFs1UkdrH4QjKz/WrRBZT6k=; b=ssnDYfWeQ51hHa3Zg2j+Y4CVrWm6J9dPl282gLT37FxJfFJip3+lDPNYWCOwSrLtay vL9ZJdS8rv+bT3xAYnWSqMvm5ASk2NnDk8vW69mE5LgoTSc3dykUX3dD37jnDwga7su2 PQKGb1M3e1boWTw0pSBNmp541saFeZ3taXtwJ2OfZ72e7Nk3NU/gtilewG/EfYZNMRW+ HcrdAP9MOU/upM0iYryB/Vs9Lx+yM1JvmpUinvj8/5QYS9Z+tAP/f4+hZZHFTDfDIr5z 8PSO8IaUZK5QN1CvOnyIeGD2nT1DFQ4qM6odiPe4xnsGXav1ASkOQ/Jo1Zn79WynSLWt vGzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772287015; x=1772891815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lPeE6tJ7LvztkqM9H/hBuFs1UkdrH4QjKz/WrRBZT6k=; b=PhDVcRbdvfGdWZLHfqk12iQDKyN/5QBRGiUVEBXcMvC328QMw4inVK5uE1Gizy6/vG I/hx2oSbbHgzJJXptwndxMmqkGYNd6AP98Fbmp4l5or/t9M+rJKbbO06xEKIvc0LM6Aa 8nmWR+tH/eiSTGHVsjUsLJdzULkycAuh4jbAAp6otOYLBsQja3iAU2B35ZShMSgOYzvm QAu6qiuZMEV7NeTWfNKjLqvRoccX6l52pQn8BA5wEFKrm3QjHfkiguIgH4BnDi6iNRKt IZ1tjrpOdmgT2hfUe5Ap2nUPz7NWK8fUCvEJtfPBou3YvFUxvSUQMfRZziQx01Li8d0z Z2Qg== X-Forwarded-Encrypted: i=1; AJvYcCUY/KP9XouL4/DJdInPnu8QWtSjVmAo2y+IpohS0ILP5DBmIPRAedJL9BSSFiARJIz9Z6Uhtsj7PbeITIY=@vger.kernel.org X-Gm-Message-State: AOJu0YyFX9qalfMsIaDuNOtOocEiCo2YQPZ2n1wN2Qok/NwqdTge4J0K 4xsYWuLIFr2SmDqOKAzVfQYWV4gsnUnEicuR10xQipMAP8cisXNo1MmyH9Hk46lRab5omrROW7z VhrKqngPK96zWS97pyBZSUVEZfm0GBTesYIl0q5+AFvoAKp2jxpGz13iLRNf8zANoCqW5idOHd4 SlcOZF3IsG+5t1CMxb6y9+aHySGRxcwTPbGpvvI99s X-Gm-Gg: ATEYQzwHgkF273ujFDNeAgrs+QWstZeVoa2NPdL2h/xT8xIOc4uT2wd4KHmI067T09V N3EKs5dBqlnfctDyryLb71mVlJ7rh/OEbAubCGO7t1FDdwxLuxmJ/fEDQtOnnkpH14dZkPCpaK3 +MKadKBYbVDj87VXUbhWfEFgW6AxuA5fXdWGxkYa+tOvubv86FyLV1N6y9XaeuVd25t4cDNdDuJ 0gmNd5n0YtbDj6quidalMmtcBQL9K9ux+aSFBRsFl3aT/fW838lk8nAcjG44irt37+Z0LuuAba9 FyOWl6M= X-Received: by 2002:a05:600c:8711:b0:47e:e20e:bbb2 with SMTP id 5b1f17b1804b1-483c9b970a5mr96104635e9.7.1772287015617; Sat, 28 Feb 2026 05:56:55 -0800 (PST) X-Received: by 2002:a05:600c:8711:b0:47e:e20e:bbb2 with SMTP id 5b1f17b1804b1-483c9b970a5mr96104395e9.7.1772287015182; Sat, 28 Feb 2026 05:56:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260207041011.913471-1-seanjc@google.com> <20260207041011.913471-3-seanjc@google.com> In-Reply-To: From: Paolo Bonzini Date: Sat, 28 Feb 2026 14:56:42 +0100 X-Gm-Features: AaiRm52HcKDpbS6MO9vZNRRsa_AijihXRFwIw89yTT0EnVi90z05uyRBgaOXTs4 Message-ID: Subject: Re: [GIT PULL] KVM: Generic changes for 6.20 To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 28, 2026 at 12:21=E2=80=AFAM Sean Christopherson wrote: > Finally got around to prepping a v2, and I realized that vcpu->mutex isn'= t held > when kvm_alloc_apic_access_page() is called, and thus isn't (currently) t= aken > outside kvm->slots_arch_lock. It is, via kvm_mmu_new_pgd (kvm_mmu_reload -> kvm_mmu_load -> mmu_alloc_shadow_roots -> mmu_first_shadow_root_alloc). In fact commit b10a038e added slots_arch_lock exactly to have something that could be taken within the SRCU critical section, and thus within vcpu->mutex :) (slots_arch_lock is also taken inside slots_lock, and therefore it must be taken inside vcpu->mutex transitively; but more to the point it exists specifically to be taken during KVM_RUN). > But update the changelog to not claim that the behavior is "arguablyh wro= ng". That too, yes. Paolo