From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BC613049E for ; Fri, 19 Apr 2024 16:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713543226; cv=none; b=oMBaNRdh/FlEmrM+QDQLrWKoLHgGcYnS3DRXzebk8wjARHAgjuCP52RBZLMkrGzecQHUDmYCHhyUVh/i3DLMaJqmct6EU4IaIGUpiHw+ICNkjZhz2dJ90Yw6zzM4XAjq9VVFXhMMx6jGBrEB768tMLX/WIENIjqcqUmGj4Am83o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713543226; c=relaxed/simple; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EYFzRtdjPF5qSCUvkoLPDDe7Es3jtuF7XhNuQK/0oi1M2pz7pahpLTTCFdg4tYKCfJ+jRvJmknOKGRqG7fHvGYLoYX2M6VUOs2BXRAQufcaW0tb1SYxETHBDt3t9grP+nlg9ZlknZPR0VlQNIZSxJQbn1BEo7al69cT/U1IrffI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HIZVcVIu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIZVcVIu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713543224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=HIZVcVIu5JU7nFfDo41kCjTnm+RMgxeVliRcaRd/FHxUsqySdBFjsazv93AKd2dyKUQzCF Arbfbhudwhq6HnC0OoX0Y9vT3x2OlDjW/dbJYJRPAp93LRxgfDj6DtACBbmZK6yPzzJTrt k03tIz8HxfSLX6T3jnboMr9pXrM7uwc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-5kXVe74APJO5vGnippP5gw-1; Fri, 19 Apr 2024 12:13:42 -0400 X-MC-Unique: 5kXVe74APJO5vGnippP5gw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-418916f5b3cso11370095e9.2 for ; Fri, 19 Apr 2024 09:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713543221; x=1714148021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=TknBP4H7ZiHR8wPkUce1yLC9Lm0EeyP0NRD/xYOo8nl55R40Ts3MClQwKwsP2DGnPS nEN6sdwE5BrGz7sAVtzKObrRYA2VdKp9sRoJYWd9wDGUmbQJ1Vm/f+ozlJvm7gNt55Mb ZZU3HVJ4SaYsWxwt2VzDQoF+p3eeIA186Zpqbfu8gs9czcTrE7x22Au9Vy6z69fepd4W 9iYinWtFVD/9+YDQxhaQHezk7U1ruoOIRa7h0o6wRNwKgz29WAGYCiOXZ173By+RA1Ma K/7hI793vCPGTCdAmrjXUc9Q9hwEuAJwKhWiwSWxOmgrWdhG3DGz4RPKG2Ql2BQRxv5O xUgA== X-Forwarded-Encrypted: i=1; AJvYcCXJM8eer4trY55NSu1MZxSdb7MFM6Xjb9T0OWDjPohkwdxW6rmYKj9x/V3wW2E11fT7k6gO0bH26GQr6KVbcbaN73d5o1mC/H7OkYSf X-Gm-Message-State: AOJu0Yw0w6Le2yROzBPE6ATpJK5LwAG3/PxjU7rRmmQlEJrTOa2yzxEz bcj04AkbDpMj/I2lJ0yJIDioGJXsDS6nsgPBL0EzDdP36DRWzHYFeTvo0kjhbyvPSXgOW8HOUXK mDXt5VlBjUuTaxy0aJub59fgmYXPbtkmy44F9jPSYlv/3P2Q8tJgv/OQPOz6Mc1Tyb1QtaebR8s 334xZcyOxPXDgdvl0WSu5lPKg9RqhQxnGzzjiZ X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596282wrc.0.1713543221704; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnajPMHcMdpRY04h+TNXdbRj7g/tI02Iw0JIqVHCpyfHEB4naUbmsOShyxFazrDJ7rYEXw5oIH9VgniqhruMA= X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596246wrc.0.1713543221365; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-10-michael.roth@amd.com> <20240419141920.2djcy6ag3peiiufn@amd.com> In-Reply-To: <20240419141920.2djcy6ag3peiiufn@amd.com> From: Paolo Bonzini Date: Fri, 19 Apr 2024 18:13:30 +0200 Message-ID: Subject: Re: [PATCH v13 09/26] KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 4:19=E2=80=AFPM Michael Roth = wrote: > So my current leaning is to send a v14 that backs out the major/minor > policy enforcement and let firmware handle that aspect. (and also > address your other comments). Sounds good to me! In the meanwhile I guess you can also update to have PFERR_PRIVATE_ACCESS. Paolo