From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89E60238C3A for ; Sat, 24 Jan 2026 07:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=170.10.133.124 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769240998; cv=pass; b=SFYbOCeWY7ov/tRbZN7sm+TA+y9YOz5MmW+2yz4QoYT5AvV7VAAKXL1qvQtNr28welZewmXI//DMFuzC4ovKDrONdYnhoeI1uXIXMeflF2BIujSz5M26G1SbfnqBCBGpbMEAX7HqZxBuL4MV9Me5++zB8SqdTChqdZEZcfdaEVU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769240998; c=relaxed/simple; bh=wjMnGoeDh+YdrtLg+xDqC4Hnv8XghUga4m38t6BAP9M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=V465vl5EWrkkUEgGN5q3ZXPiut0gc3GTsqXwmWVAai5nMT2kkP8sVyXl/jf+H0aXZFNyRzrI9A1ioYV9bFVYf9FI+BCMDfeYjiaobm6kwchTX4iQ+VkJqee3BgM+/tHIL+DklkYBTFTW72L7pgtoBFQNC5o/2kIE7ANF6NYyef8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ok97up28; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bCGwrVxB; arc=pass smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ok97up28"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bCGwrVxB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769240995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjMnGoeDh+YdrtLg+xDqC4Hnv8XghUga4m38t6BAP9M=; b=Ok97up28cwKzKuP+BwTkQqyLnQji+fmpvR+421Kl1UxREhVEKI9QEBXxtxoyxEmcNL6x5W VBHafoFohNpvP8u0TuMEbo+EUR1MbW51qu3rsO3KWYS3q/QHW8ldsLzrDbFtkuI/vg+6ul jW7c5S/bM2edBn7xKeUJ/A5MZLLw06g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-QQVbNwp2NACT3iYEgcPiTw-1; Sat, 24 Jan 2026 02:49:54 -0500 X-MC-Unique: QQVbNwp2NACT3iYEgcPiTw-1 X-Mimecast-MFC-AGG-ID: QQVbNwp2NACT3iYEgcPiTw_1769240993 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-435a2de6ec0so684331f8f.0 for ; Fri, 23 Jan 2026 23:49:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769240993; cv=none; d=google.com; s=arc-20240605; b=kiUfFcpTtW/e+rQ3ehMcUmpwuTOcrjcJjQTwlcL2mhNAJVZ7dr5WvA9Q9o7ZNprJGe 25D8m/n8b/Rs331n2OQsb9MCHLOb4leyDLmaIXiEB+q/8BYX6HW7WBHsILbIykKSBaS3 X7n/bt17+V6gHCB1cRTo0EkGqVlxGQo+Rqmgm6ItIUQG1hE6OgF8U80cueiqJlCSovTQ iGaYGelu5ehG+6e+TNg1fsjTQzuHNmlFy4TMoUnFLO5/pWqtXm0f5Tp6TyXLld4j8G7E Hd/bmd+BSGav0oG2TAEocZ6uuK84xHH4NiFJ56o1IDzDeBc7/A3NhCaiNSiSUaT+aA6T ruIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wjMnGoeDh+YdrtLg+xDqC4Hnv8XghUga4m38t6BAP9M=; fh=pqpbX3ONxU2sJ/hbSjHyhp7m7Zf4rYhbprQlq91T+XU=; b=bUTF4PAdt7AGINOVW9oA6ci7fCJMUiDJeX/RR5FCXTFSFrPplgUDo+QdNGD5WXfrcG W6qzNuJ7WJDh8ezb8K34T0A5bEBcQcFkLhneTTxebK8aIPj7C9g2NeUgwXulaBKmI1Of TXO84eu7UgDSqgT0iTaEJyH1Zi7U1z3o66+Ax+x7Fh6sqipJWpZh0tqCLdMBo2zdQ7M2 Cmn4C8iv4gSpGeaykPmBx5Tk7NM3dpzvhNhgTGCUzzxfOtla32xDMY21hoCffj6c3xNY qXaMBd7UaYuy0yQXmOG7+rbfvbPKpw1910e4rIktciDn9K7NiMrF6yvd27XQEMtH2+kX Rwag==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769240993; x=1769845793; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wjMnGoeDh+YdrtLg+xDqC4Hnv8XghUga4m38t6BAP9M=; b=bCGwrVxBRW+G3YPfHdZBfVsW9u4h2o+hYQm7KKq6lupnkR/7bAeAByTCI8y69IYkiy CgVWVIP+wZYP0D43VhO14n95x8IK59SwecT+ja/oPMDhA2fEcwmtdPlMBi3+3Ag3WnoW 2NVFqQE/+XRzTbSZ8Q2HEIMgwuej7it+luO+qaFmsAJwNH4uj+DPgs7ugHOdYmwQYQ++ Pf41yVKCGb1Txf/pFDsusU+EUBeO4933MN+KANej1LXJKrFQH/LyTuhai1c9jZ9podHI yq4Jed1c2OL4Km4ufHsa0wjgJDer6z4xMfG+k/VcHgywX0/1H8k2EXRWEAlyCxf46rO9 6fcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769240993; x=1769845793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wjMnGoeDh+YdrtLg+xDqC4Hnv8XghUga4m38t6BAP9M=; b=hHiu2QGruLyncUho8A/C7QdYgnkpGa7xgfCCIf7c8Xs/DP0PqXT3/ksmj0BlFLD3aH TnXd12oKq5QDFYjT/+kDcmPFTWEt5i5e6Y1ehlnT5/uy+xP1+OmzDS7q7695s6sn74L+ xck2E/vtFtJUFBMQMPR55sgwrTr3hCnxvVI/XSkHTZ2QuMkiRBUTKeHGPE4v37Whfiq8 W7gVzEa6KC3WWP6r3vXCLq0Vy2WdoPWPucbzOJdlO2OIIau4oLgcPTnw2YGQ5AEY2xWn 89msdDE9ZPW3B4P8mQR+zdRi4r4vpS802mbVsEMODtU5FZToCL1RqZ0fVEofUl7lbgx8 qC8w== X-Forwarded-Encrypted: i=1; AJvYcCWAUnsya/h+cTFkUZWDpdTC7S2OnDimWdW3HilaRX5OfF8ZT7EnOuWncgxqAu11apxh3VVWtabkUOItHF8=@vger.kernel.org X-Gm-Message-State: AOJu0YyL6LXlfPdUQNjcA41fis9s7qtC2X7vKJjzL5gpCJ4BQRW3ceCV bU6u1T2g1ftlO6PrDkmDenqp9TARy4zfB0vSBj++ufIXjcOp8kkbhYbt4/C3jztA6tWDyKz/niV 3yaNUMI86V4v+yBrOzhA4nnH+n3HfYrspxC4+Q095B9ryFySaEoZ6bXb2Qhbw78XTm7H2MWdaL5 /pnEpOMchL1UGzcxZl32pFpIwywz/qipp0nFBsUEHy X-Gm-Gg: AZuq6aI+Rdyy555Ac/KTM9UR2HJnWjy2Sqxu94DtVS6bGc9RSBIOrXAvlLrSJ3SBVby MoVlwCxDpZZyk7nngFf13CsVFBxAwrLooj4M/PIMLWEg76RqrZgsD76WG8wKeX0MArEo1Gm8zE6 9JbK6TfANv8/a4Go2AWEUsYKjbRK5se2/iqTuVlU/qCPXjS1j5s1u6SqJiapZQjugyJrtZzybFe MpXurJ5iJETHjHH+U4Dpha1f92pP7qFHCJk60q951nD6eI3axKsCqPrN0ROReqVjSKGhg== X-Received: by 2002:a05:6000:601:b0:430:fdc8:8bbd with SMTP id ffacd0b85a97d-435b16039damr9146816f8f.41.1769240992702; Fri, 23 Jan 2026 23:49:52 -0800 (PST) X-Received: by 2002:a05:6000:601:b0:430:fdc8:8bbd with SMTP id ffacd0b85a97d-435b16039damr9146785f8f.41.1769240992303; Fri, 23 Jan 2026 23:49:52 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250611224604.313496-2-seanjc@google.com> <20250611224604.313496-40-seanjc@google.com> <42513cb3-3c2e-4aa8-b748-23b6656a5096@redhat.com> <874iovu742.ffs@tglx> <87pl7jsrdg.ffs@tglx> <5bea843b-dec8-4f15-bb7c-1d0550542034@redhat.com> <87sebxtrgp.ffs@tglx> In-Reply-To: <87sebxtrgp.ffs@tglx> From: Paolo Bonzini Date: Sat, 24 Jan 2026 08:49:40 +0100 X-Gm-Features: AZwV_Qj6aLwVSas8vwNUo-Ndu2FBevRcUQp0THPxC18GLGDTRk3JARciXPkQtdQ Message-ID: Subject: Re: possible deadlock due to irq_set_thread_affinity() calling into the scheduler (was Re: [PATCH v3 38/62] KVM: SVM: Take and hold ir_list_lock across IRTE updates in IOMMU) To: Thomas Gleixner Cc: Ankit Soni , Sean Christopherson , Marc Zyngier , Oliver Upton , Joerg Roedel , David Woodhouse , Lu Baolu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Sairaj Kodilkar , Vasant Hegde , Maxim Levitsky , Joao Martins , Francesco Lavra , David Matlack , Naveen Rao , Crystal Wood Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 22, 2026 at 7:47=E2=80=AFPM Thomas Gleixner w= rote: > > On Wed, Jan 21 2026 at 19:13, Paolo Bonzini wrote: > > On 1/8/26 22:53, Thomas Gleixner wrote: > >> Are you still claiming that this is a kernel/irq bug? > > > > Not really, I did say I'd like to treat it as a kernel/irq bug... > > but certainly didn't have hopes high enough to "claim" that. > > I do think that it's ugly to have locks that are internal, > > non-leaf and held around callbacks; but people smarter than > > me have thought about it and you can't call it a bug anyway. > > Deep core code has a tendency to be ugly. But if it makes your life > easier, then these wakeups can be delayed via an irq_work to be outside > of the lock. That needs some life-time issues to be addressed, but > should be doable. Thanks for the suggestion---hopefully it's not needed at all and we can delay taking the lock in KVM. Paolo