From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02759276D24 for ; Thu, 27 Feb 2025 23:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740699541; cv=none; b=FHpxtFx2OZiRKPGSwpHOl3uN2g2GQYwiF2S/TA2h9VfgoM7TSTt65OR/eaVzzIy5dGdmM8SPrg4F//x47i0cGviEOb4oHn570sq/NyBDNWY42MKlvQDtEN2I1d7aMbRLNMDjJDTQAW677FNAyO920wwYeo8bjgIBTXOrLfgvPUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740699541; c=relaxed/simple; bh=uazbQbXAgJkqYDiwEOwqWCYWk/4zsx2AxDpUxCHm10E=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FoSSsmLQlifx/yuG1ASA/eoox3TJG1YZShAOlzCSwn+DubpfT9GTi/bOEAbASk7x7ukrb3KkvkHybaKWwXcHFfZFR19L3MwmqYcKIHXY1UrSBvBzECgkDXFfbJ+s4T78W4sJrrwRrkU3iAwIQSsqlrsX0LcKelzF0NYf2g5CAGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fKc1RRcE; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fKc1RRcE" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5fc6f75aa8aso77668eaf.1 for ; Thu, 27 Feb 2025 15:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740699539; x=1741304339; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BtvOHIMuelDkAYqCBYw4pmTE6kjO3Q01OuRJQEoDcUw=; b=fKc1RRcEGDUZyYWtSMByqX9B9cHwAbgxw6kJAIBLl38G8StmfOTvlmpx+9Tgz4s5a0 i6veTF78h5Ws2AudlsdDUqazKPTQZ6Yu5izi8ln/Y70UR8lXec0t13vj+HraQe9n6Thv SwyZPxbeDZGyeyNL9XYJAvc6oCvKnZPe88hbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740699539; x=1741304339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtvOHIMuelDkAYqCBYw4pmTE6kjO3Q01OuRJQEoDcUw=; b=jU6BBYb+DYdW+T8i8E6GaSrTP3ArvFw5brAhYTNVymikhgxMTitbW7iCAM/HJjRUYO rDo/sGVappxwSgA9YW7dZtchUoQN6mK871OmVJ0Hp2oMM+QyryHkqj5hqFD9TiQ5Rowj pFCcOpgl3uvJZJDBYoWk2HS/tbzV7BvNfRfs3hiFRYc1cBanHQUVvxAmxqBwGavXZVBq qtfOe7ruJ6XsyAwnS8jWJcCgm2MUfZrLotEd7SZLMssxTg3mshoAV+ctk3m4jX+U1ehD Yv6G3dU4/fTzniVdOSZq8CVORwKFnZgrBaoQ4LWiEYBzI4j1pK/i0FY+1Zh915/GBeNK S+Ww== X-Forwarded-Encrypted: i=1; AJvYcCU8p7NCYuVOqd8hD6jBhXiZS2LqsACVidt9QPrxB6PaZmdCGFF83xChxTEMYBOfNcLROKXOv6xFfL6jvKU=@vger.kernel.org X-Gm-Message-State: AOJu0YyplqE2NynK04taPxKxKeddAeWauHQ60dFu9DmDNgPMj5DVFN9Q 0WKfm6RtojdhpK13IcHvM73703FHYvP1FtVqHT+nLgb30GWVOklcVnhsP2Gx6AyfVfF6hNAEiP0 BkY3G6uoIMQMuS/6IN7uMdWR5zd3nEHHWrBS1 X-Gm-Gg: ASbGncuTvJ8hVz40nrDTs7vmK7exZETpgUMBDDPC/Bsyq/hdTC0haI8awob8+tmJO4A 3Nq6mjgNZOpQak+1mfEGE3PHy7b+FE0NMSnwKtddIY/WJ2X2aNSFAkfcAa++Pkz64MiSy2HPEIm g3gqaatl/p2Dnsl8IHE2HVd/1XqEr87DALSoRmpUrP X-Google-Smtp-Source: AGHT+IGa5qWw6mWS9FqBki1tFln20XRNh8F87XAQ33WnPErm38DCBjPn+ns0NBr5sJsRp+DHD4erKnV1oUgv1UGVsr8= X-Received: by 2002:a05:6820:a110:b0:5fc:e9dd:45ed with SMTP id 006d021491bc7-5feb352ea7bmr202854eaf.1.1740699539040; Thu, 27 Feb 2025 15:38:59 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-7-jeffxu@google.com> <20250226162604.GA17833@redhat.com> <20250226180135.GI8995@redhat.com> <20250226182050.GK8995@redhat.com> In-Reply-To: From: Jeff Xu Date: Thu, 27 Feb 2025 15:38:47 -0800 X-Gm-Features: AQ5f1JpI4wTwciE-lKyx_Ev93hW3Fh_Xe8B3FCHbhfxf4AGtcraQIrvmSgrDIxs Message-ID: Subject: Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping To: Lorenzo Stoakes Cc: Oleg Nesterov , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 26, 2025 at 10:25=E2=80=AFAM Lorenzo Stoakes wrote: > > On Wed, Feb 26, 2025 at 07:20:50PM +0100, Oleg Nesterov wrote: > > On 02/26, Lorenzo Stoakes wrote: > > > > > > Like I said, Jeff opposes the change. I disagree with him, and agree = with you, > > > because this is very silly. > > > > > > But I don't want to hold up this series with that discussion (this is= for his > > > sake...) > > > > Neither me, so lets go with VM_SEALED_SYSMAP. > > > > My only objection is that > > > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO; > > vm_flags |=3D VM_SEALED_SYSMAP; > > > > looks unnecessarily confusing to me, > > > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED_SYSMA= P; > > > > or just > > > > vma =3D _install_special_mapping(..., > > VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_S= EALED_SYSMAP, > > ... > > > > looks more readable. But this is cosmetic/subjective, so I won't argue/= insist. > > Agreed. This would be good. > > > > > > Jeff - perhaps drop this and let's return to it in a follow up so thi= s series > > > isn't held up? > > > > Up to you and Jeff. > > > > But this patch looks "natural" to me in this series. > > OK, I mean in that case I'm ok with it as-is, as you confirms there's no > issue, I've looked at the code and there's no issue. > > It was only if we wanted to try the VM_SEALED thing, i.e. _always_ seal > then it'd do better outside of the series as there'd be a discussion abou= t > maybe changing this CONFIG_64BIT thing yada yada. > > > > > Oleg. > > > > Jeff - in that case, do NOT drop this one :P but do please look at the > above style nit. > Ok. > Let's keep things moving... :)