Re: [PATCH 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

[Matthias Brugger <matthias.bgg@gmail.com>]

2014-10-29 6:37 GMT+01:00 Xudong Chen <xudong.chen@mediatek.com>:
> Add devicetree bindings for Mediatek Soc I2C driver.
>
> Signed-off-by: Xudong Chen <xudong.chen@mediatek.com>
> ---
>  .../devicetree/bindings/i2c/i2c-mt6577.txt         | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> new file mode 100644
> index 0000000..b4012c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> @@ -0,0 +1,37 @@
> +* Mediatek's I2C controller
> +
> +The Mediatek's I2C controller is used to interface with I2C devices.
> +
> +Required properties:
> +  - compatible: value should be either of the following.
> +      (a) "mtk,mt6577-i2c", for i2c compatible with mt6577 i2c.

Looking on the datasheet of mt6577 it does not seem that this driver
is really compatible.
I was not able to find the PATH_DIR register neither in the datasheet
nor in the source code.

> +      (b) "mtk,mt8127-i2c", for i2c compatible with mt8127 i2c.
> +      (c) "mtk,mt8135-i2c", for i2c compatible with mt8135 i2c.
> +  - reg: physical base address of the controller and dma base, length of memory mapped
> +    region.
> +  - interrupts: interrupt number to the cpu.
> +  - clock-div: the fixed value for frequency divider of clock source in i2c module.
> +    Each IC may be different.
> +  - clocks: clock name from clock manager
> +  - clock-names: clock name used in i2c driver probe
> +
> +Optional properties:
> +  - clock-frequency: Frequency in Hz of the bus when transfer, the default value is 100000.
> +  - mediatek,have-pmic: platform can control i2c form special pmic side.
> +  - mediatek,have-dcm: platform has DCM(hardware digital clock manager) property.
> +  - mediatek,use-push-pull: IO use push-pull mode.
> +
> +Example:
> +
> +       i2c0: i2c@1100d000 {
> +                       compatible = "mediatek,mt6577-i2c";
> +                       reg = <0x1100d000 0x70>,
> +                             <0x11000300 0x80>;
> +                       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> +                       clock-frequency = <100000>;
> +                       mediatek,have-pmic;
> +                       clock-div = <16>;
> +                       clocks = <&i2c0_ck>, <&ap_dma_ck>;
> +                       clock-names = "main", "dma";
> +       };
> +
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com