From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbbIAJQK (ORCPT ); Tue, 1 Sep 2015 05:16:10 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:35871 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213AbbIAJQH convert rfc822-to-8bit (ORCPT ); Tue, 1 Sep 2015 05:16:07 -0400 MIME-Version: 1.0 X-Originating-IP: [95.23.99.125] In-Reply-To: <20150901090916.GM4796@x1> References: <1440784362-31217-1-git-send-email-peter.griffin@linaro.org> <1440784362-31217-5-git-send-email-peter.griffin@linaro.org> <20150901090916.GM4796@x1> Date: Tue, 1 Sep 2015 11:16:05 +0200 Message-ID: Subject: Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios From: Javier Martinez Canillas To: Lee Jones Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org, "devicetree@vger.kernel.org" , valentinrothberg@gmail.com, hugues.fruchet@st.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On Tue, Sep 1, 2015 at 11:09 AM, Lee Jones wrote: > On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: >> On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin wrote: >> > gpio.txt documents that GPIO properties should be named >> > "[-]gpios", with being the purpose of this >> > GPIO for the device. >> > >> > This change has been done as one atomic commit. >> > >> > Signed-off-by: Peter Griffin >> > Acked-by: Lee Jones >> > --- >> > Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++--- >> > arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++-- >> > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- >> > 3 files changed, 6 insertions(+), 6 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt >> > index d4def76..e70d840 100644 >> > --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt >> > +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt >> > @@ -35,7 +35,7 @@ Required properties (tsin (child) node): >> > >> > - tsin-num : tsin id of the InputBlock (must be between 0 to 6) >> > - i2c-bus : phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected. >> > -- rst-gpio : reset gpio for this tsin channel. >> > +- reset-gpios : reset gpio for this tsin channel. >> >> The documentation is a bit outdated, the GPIO subsystem supports both >> -gpio and -gpios, see commit: >> >> dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names") >> >> So it makes sense to me to use -gpio instead of -gpios in this case >> since is a single GPIO. Also rst is already a descriptive name since >> that's how many datasheets name a reset pin. I'm not saying I'm >> against this patch, just pointing out since the commit message is a >> bit misleading. > > As I suggested this patch, I feel I must comment. > > My order of preference would be: > > reset-gpio > reset-gpios > rst-gpio > rst-gpios > > This current patch is No2, so it's okay to stay IMHO. > If the property is being changed anyways, why not going with No1 then? As I said, I'm not against the patch but I think the commit message has to be reworded since implies that the problem is that the -gpio sufix is being used instead of -gpios. But since both are supported by the GPIO subsystem, the commit should mention that "reset" is more clear and easier to read than "rst" or something along those lines. BTW, I just posted a patch for the GPIO doc to mention that -gpio is also supported: https://patchwork.kernel.org/patch/7103761/ > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Best regards, Javier