From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B44BA34 for ; Thu, 20 Mar 2025 01:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742434966; cv=none; b=tvZWJ2dwP2bifj/LnMCg4ERk96tofTLF4mkutm6HXdSYjIeqO/mhG+6+TI76APEXdYUh0b+J7EkSUFY1wFrAEOnG+oaamDicAZeRX+soCkLcSKIn2+p6sbNcHKqwZe11F84hHf7npjUI6OAuVkapoKuo7yTHGeRVpsNq93SoUo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742434966; c=relaxed/simple; bh=SGrH1u360HKGfwUkB5OQl0M0A4QLRKrf61IPTLVqChc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=L8Qd95JU4JlMMQKqudPcxc5k3o+KQoCg0wFX3dgP5EnRycO3q3T9xEgwVaohXEBCFcRZ6ElIjsNpAnajl/z/o4g7WAzUu2zYkU4ln15hI0RjQkjhJzFw82fqrhWJPXrZtFGwLExX7rrtfRiLBL1Rlw32rb9F/I7iWDj7F5gRXpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Tf9ghmXw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tf9ghmXw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742434964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGrH1u360HKGfwUkB5OQl0M0A4QLRKrf61IPTLVqChc=; b=Tf9ghmXwJ23G4LWVoUJMsX/NyaV+ULvrl7eSgrtuqxQc0xo9WkxmJQ6QN5xQ5BUFeXg/yN zdjCVj2USs1ZfO6fx30pqvAyCvO10Slz+/40lwQ9Dr2G+xT/bnguNl4RxjUEapbbAmfPZf 74+C8TSmnZ8GDrEwlcUT2lEXseOkX04= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-r1JdIdJYNUi8tDhTae5Z5Q-1; Wed, 19 Mar 2025 21:42:42 -0400 X-MC-Unique: r1JdIdJYNUi8tDhTae5Z5Q-1 X-Mimecast-MFC-AGG-ID: r1JdIdJYNUi8tDhTae5Z5Q_1742434961 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2ff798e8c90so459162a91.1 for ; Wed, 19 Mar 2025 18:42:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742434961; x=1743039761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SGrH1u360HKGfwUkB5OQl0M0A4QLRKrf61IPTLVqChc=; b=q+O/wzRXCIQf7FIFeQ3tOfKOi89+2NsNFB7xToyqUWV5OuyCYM+bIlBccIPSXue7zM CyRPP8c1CYlSAf/HQhQvwOX6CXrQRGK0MzoOYwlU98D3sCwixMpBymyOJ+aMrra5IN21 jM8P2j6GMOvCWdXA0lannQ4Q0UP1l3V08d7g5C+J9+4s3QCd/ov8pMEOIsrYdwOOJlIi 962Aewbfo8OBPLVPrH8GrXYc+8Ma8HPM28rsL+rebTl5E7QNH+cU5plXXjnXm0lR+1KW NhzdsHQc8GEVHauKSW6BCRDuuc18E8NH0Hi+DG92g4SceAYzGFnB2Zy9KI0sITt4yNlR jdYw== X-Forwarded-Encrypted: i=1; AJvYcCW2SpsC4KGNieY16S7q1erEmetkauNPWMYoFzezZ3/G9gohfp5R2YAmLuAT5b1qNSAZw1V6Qo5OIEbjSB4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw71duCZmZ2BMRueE+dzzMob1yIQdrjotcIyS6w9muFNwIdp6+C 4UEbErNV4Y/X+8tsPwvuRtqm2pZglXv3H06emcZ8lGN/uEUANb7aHF/urC7Cf/6Z7usL9i69Yjj gkLZbtIeO5bVP504LAC9zSFxm9qX1sPEnV7bOA4gTF/CKejL3YFNeq9DY1fWxI+0A+N14fXntta RndESEjpzDWGmi8QPGfsiwKO6w6e0jv3DjJKnr X-Gm-Gg: ASbGncvZ7WKrdG0sAsIn1xBB5cbcUd3KRaSCxIMQcCkexFvfSTXczSbA/D1Lp/1WMva hB+ebBGpZgkCxYA9oOXP+fFKevbGqURBZro8RJXbkbVDDxFSzn+C7xxqgCGTgmYLiFQOMuNei8A == X-Received: by 2002:a17:90b:3b8d:b0:2ff:702f:7172 with SMTP id 98e67ed59e1d1-301be22004bmr8335518a91.33.1742434961584; Wed, 19 Mar 2025 18:42:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHL8OOunCev/pL9yVKVD54yPvvXy/UMUfGTvOvKDcF+K+NIjug+q9W+WWL+a2DVKRNK9ypCK2PuGfDdKa5c2c= X-Received: by 2002:a17:90b:3b8d:b0:2ff:702f:7172 with SMTP id 98e67ed59e1d1-301be22004bmr8335480a91.33.1742434961230; Wed, 19 Mar 2025 18:42:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250317235546.4546-1-dongli.zhang@oracle.com> <20250317235546.4546-4-dongli.zhang@oracle.com> In-Reply-To: From: Jason Wang Date: Thu, 20 Mar 2025 09:42:29 +0800 X-Gm-Features: AQ5f1Jog19Stpw5ZwXnl2LZ0a3rRd5bIs46de4Ks1-qbsvRNWnVK_fE3aiW_X5c Message-ID: Subject: Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status() To: Dongli Zhang Cc: virtualization@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, mst@redhat.com, michael.christie@oracle.com, pbonzini@redhat.com, stefanha@redhat.com, eperezma@redhat.com, joao.m.martins@oracle.com, joe.jin@oracle.com, si-wei.liu@oracle.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 20, 2025 at 1:54=E2=80=AFAM Dongli Zhang wrote: > > Hi Jason, > > On 3/17/25 5:48 PM, Jason Wang wrote: > > On Tue, Mar 18, 2025 at 7:52=E2=80=AFAM Dongli Zhang wrote: > >> > >> Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was > >> signaled by the commit 664ed90e621c ("vhost/scsi: Set > >> VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"), > >> vhost_scsi_send_bad_target() still assumes the response in a single > >> descriptor. > >> > >> Similar issue in vhost_scsi_send_bad_target() has been fixed in previo= us > >> commit. > >> > >> Fixes: 3ca51662f818 ("vhost-scsi: Add better resource allocation failu= re handling") > > > > And > > > > 6dd88fd59da84631b5fe5c8176931c38cfa3b265 ("vhost-scsi: unbreak any > > layout for response") > > > > Would suggest add the commit to Fixes? > > vhost_scsi_send_status() has been introduced by the most recent patch. > > It isn't related to that commit. That commit is to fix > vhost_scsi_complete_cmd_work() > > Or would you suggest mention it as part of "Similar issue has been fixed = in > previous commit."? I'm fine with either, they are all fixes for any header layout anyhow. Thanks > > Thank you very much! > > Dongli Zhang >