From: Jason Wang <jasowang@redhat.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Cindy Lu <lulu@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Laurent Vivier <lvivier@redhat.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
Yongji Xie <xieyongji@bytedance.com>,
Maxime Coquelin <mcoqueli@redhat.com>
Subject: Re: [PATCH 2/6] vduse: add vq group support
Date: Mon, 8 Sep 2025 10:12:35 +0800 [thread overview]
Message-ID: <CACGkMEsX+D2_12xGDxusO3+BR2bqqXodHHjLy_4TJCpm96jRTA@mail.gmail.com> (raw)
In-Reply-To: <CAJaqyWcQwkpRZdKJBSHhtfLXfL5gb2_z8j-OsqSy3pPa+ZvYxw@mail.gmail.com>
On Fri, Sep 5, 2025 at 4:47 PM Eugenio Perez Martin <eperezma@redhat.com> wrote:
>
> On Thu, Sep 4, 2025 at 5:20 AM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Thu, Sep 4, 2025 at 11:08 AM Jason Wang <jasowang@redhat.com> wrote:
> > >
> > > On Wed, Sep 3, 2025 at 6:31 PM Eugenio Perez Martin <eperezma@redhat.com> wrote:
> > > >
> > > > On Wed, Sep 3, 2025 at 9:40 AM Jason Wang <jasowang@redhat.com> wrote:
> > > > >
> > > > > On Wed, Sep 3, 2025 at 2:29 PM Eugenio Perez Martin <eperezma@redhat.com> wrote:
> > > > > >
> > > > > > On Wed, Sep 3, 2025 at 5:58 AM Jason Wang <jasowang@redhat.com> wrote:
> > > > > > >
> > > > > > > On Mon, Sep 1, 2025 at 4:40 PM Eugenio Perez Martin <eperezma@redhat.com> wrote:
> > > > > > > >
> > > > > > > > On Mon, Sep 1, 2025 at 3:59 AM Jason Wang <jasowang@redhat.com> wrote:
> > > > > > > > >
> > > > > > > > > On Tue, Aug 26, 2025 at 7:27 PM Eugenio Pérez <eperezma@redhat.com> wrote:
> > > > > > > > > >
> > > > > > > > > > This allows sepparate the different virtqueues in groups that shares the
> > > > > > > > > > same address space. Asking the VDUSE device for the groups of the vq at
> > > > > > > > > > the beginning as they're needed for the DMA API.
> > > > > > > > > >
> > > > > > > > > > Allocating 3 vq groups as net is the device that need the most groups:
> > > > > > > > > > * Dataplane (guest passthrough)
> > > > > > > > > > * CVQ
> > > > > > > > > > * Shadowed vrings.
> > > > > > > > > >
> > > > > > > > > > Future versions of the series can include dynamic allocation of the
> > > > > > > > > > groups array so VDUSE can declare more groups.
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > > > > > > > > > ---
> > > > > > > > > > v1: Fix: Remove BIT_ULL(VIRTIO_S_*), as _S_ is already the bit (Maxime)
> > > > > > > > > >
> > > > > > > > > > RFC v3:
> > > > > > > > > > * Increase VDUSE_MAX_VQ_GROUPS to 0xffff (Jason). It was set to a lower
> > > > > > > > > > value to reduce memory consumption, but vqs are already limited to
> > > > > > > > > > that value and userspace VDUSE is able to allocate that many vqs.
> > > > > > > > > > * Remove the descs vq group capability as it will not be used and we can
> > > > > > > > > > add it on top.
> > > > > > > > > > * Do not ask for vq groups in number of vq groups < 2.
> > > > > > > > > > * Move the valid vq groups range check to vduse_validate_config.
> > > > > > > > > >
> > > > > > > > > > RFC v2:
> > > > > > > > > > * Cache group information in kernel, as we need to provide the vq map
> > > > > > > > > > tokens properly.
> > > > > > > > > > * Add descs vq group to optimize SVQ forwarding and support indirect
> > > > > > > > > > descriptors out of the box.
> > > > > > > > > > ---
> > > > > > > > > > drivers/vdpa/vdpa_user/vduse_dev.c | 51 ++++++++++++++++++++++++++++--
> > > > > > > > > > include/uapi/linux/vduse.h | 21 +++++++++++-
> > > > > > > > > > 2 files changed, 68 insertions(+), 4 deletions(-)
> > > > > > > > > >
> > > > > > > > > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> > > > > > > > > > index e7bced0b5542..0f4e36dd167e 100644
> > > > > > > > > > --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> > > > > > > > > > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> > > > > > > > > > @@ -58,6 +58,7 @@ struct vduse_virtqueue {
> > > > > > > > > > struct vdpa_vq_state state;
> > > > > > > > > > bool ready;
> > > > > > > > > > bool kicked;
> > > > > > > > > > + u32 vq_group;
> > > > > > > > > > spinlock_t kick_lock;
> > > > > > > > > > spinlock_t irq_lock;
> > > > > > > > > > struct eventfd_ctx *kickfd;
> > > > > > > > > > @@ -114,6 +115,7 @@ struct vduse_dev {
> > > > > > > > > > u8 status;
> > > > > > > > > > u32 vq_num;
> > > > > > > > > > u32 vq_align;
> > > > > > > > > > + u32 ngroups;
> > > > > > > > > > struct vduse_umem *umem;
> > > > > > > > > > struct mutex mem_lock;
> > > > > > > > > > unsigned int bounce_size;
> > > > > > > > > > @@ -592,6 +594,13 @@ static int vduse_vdpa_set_vq_state(struct vdpa_device *vdpa, u16 idx,
> > > > > > > > > > return 0;
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > +static u32 vduse_get_vq_group(struct vdpa_device *vdpa, u16 idx)
> > > > > > > > > > +{
> > > > > > > > > > + struct vduse_dev *dev = vdpa_to_vduse(vdpa);
> > > > > > > > > > +
> > > > > > > > > > + return dev->vqs[idx]->vq_group;
> > > > > > > > > > +}
> > > > > > > > > > +
> > > > > > > > > > static int vduse_vdpa_get_vq_state(struct vdpa_device *vdpa, u16 idx,
> > > > > > > > > > struct vdpa_vq_state *state)
> > > > > > > > > > {
> > > > > > > > > > @@ -678,6 +687,28 @@ static u8 vduse_vdpa_get_status(struct vdpa_device *vdpa)
> > > > > > > > > > return dev->status;
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > +static int vduse_fill_vq_groups(struct vduse_dev *dev)
> > > > > > > > > > +{
> > > > > > > > > > + /* All vqs and descs must be in vq group 0 if ngroups < 2 */
> > > > > > > > > > + if (dev->ngroups < 2)
> > > > > > > > > > + return 0;
> > > > > > > > > > +
> > > > > > > > > > + for (int i = 0; i < dev->vdev->vdpa.nvqs; ++i) {
> > > > > > > > > > + struct vduse_dev_msg msg = { 0 };
> > > > > > > > > > + int ret;
> > > > > > > > > > +
> > > > > > > > > > + msg.req.type = VDUSE_GET_VQ_GROUP;
> > > > > > > > > > + msg.req.vq_group.index = i;
> > > > > > > > > > + ret = vduse_dev_msg_sync(dev, &msg);
> > > > > > > > > > + if (ret)
> > > > > > > > > > + return ret;
> > > > > > > > > > +
> > > > > > > > > > + dev->vqs[i]->vq_group = msg.resp.vq_group.group;
> > > > > > > > > > + }
> > > > > > > > > > +
> > > > > > > > > > + return 0;
> > > > > > > > > > +}
> > > > > > > > > > +
> > > > > > > > > > static void vduse_vdpa_set_status(struct vdpa_device *vdpa, u8 status)
> > > > > > > > > > {
> > > > > > > > > > struct vduse_dev *dev = vdpa_to_vduse(vdpa);
> > > > > > > > > > @@ -685,6 +716,11 @@ static void vduse_vdpa_set_status(struct vdpa_device *vdpa, u8 status)
> > > > > > > > > > if (vduse_dev_set_status(dev, status))
> > > > > > > > > > return;
> > > > > > > > > >
> > > > > > > > > > + if (((dev->status ^ status) & VIRTIO_CONFIG_S_FEATURES_OK) &&
> > > > > > > > > > + (status & VIRTIO_CONFIG_S_FEATURES_OK))
> > > > > > > > > > + if (vduse_fill_vq_groups(dev))
> > > > > > > > > > + return;
> > > > > > > > >
> > > > > > > > > I may lose some context but I think we've agreed that we need to
> > > > > > > > > extend the status response for this instead of having multiple
> > > > > > > > > indepdent response.
> > > > > > > > >
> > > > > > > >
> > > > > > > > My understanding was it is ok to start with this version by [1]. We
> > > > > > > > can even make it asynchronous on top if we find this is a bottleneck
> > > > > > > > and the VDUSE device would need no change, would that work?
> > > > > > >
> > > > > > > I think I need to understand why we can not defer this to get_group_asid() call.
> > > > > > >
> > > > > >
> > > > > > Because we need to know the vq_groups->asid mapping in other calls
> > > > > > like set_group_asid or get_vq_group.
> > > > >
> > > > > I think we don't need the mapping of those, or anything I miss?
> > > > >
> > > >
> > > > If the kernel module does not ask the userland device for the actual
> > > > vq group of a virtqueue, what should it return in vduse_get_vq_group?
> > > > 0 for all vqs, even if the CVQ is in vq group 1?
> > >
> > > Since the topology is fixed I think userspace should provide this when
> > > creating a device.
> > >
>
> The topology is not fixed: The CVQ may be either the vq #2 or the last
> one depending if mq has been negotiated or not.
>
> So it cannot be provided at device creation, but only after feature negotiation.
You are correct. This has been discussed before.
Thanks
next prev parent reply other threads:[~2025-09-08 2:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 11:27 [PATCH 0/6] Add multiple address spaces support to VDUSE Eugenio Pérez
2025-08-26 11:27 ` [PATCH 1/6] vduse: add v1 API definition Eugenio Pérez
2025-08-26 11:27 ` [PATCH 2/6] vduse: add vq group support Eugenio Pérez
2025-09-01 1:59 ` Jason Wang
2025-09-01 2:31 ` Jason Wang
2025-09-01 8:39 ` Eugenio Perez Martin
2025-09-03 3:57 ` Jason Wang
2025-09-03 3:58 ` Jason Wang
2025-09-03 6:28 ` Eugenio Perez Martin
2025-09-03 7:40 ` Jason Wang
2025-09-03 10:30 ` Eugenio Perez Martin
2025-09-04 3:08 ` Jason Wang
2025-09-04 3:20 ` Jason Wang
2025-09-05 8:47 ` Eugenio Perez Martin
2025-09-08 2:12 ` Jason Wang [this message]
2025-08-26 11:27 ` [PATCH 3/6] vduse: return internal vq group struct as map token Eugenio Pérez
2025-09-01 2:25 ` Jason Wang
2025-09-01 7:27 ` Eugenio Perez Martin
2025-08-26 11:27 ` [PATCH 4/6] vduse: create vduse_as to make it an array Eugenio Pérez
2025-09-01 2:27 ` Jason Wang
2025-08-26 11:27 ` [PATCH 5/6] vduse: add vq group asid support Eugenio Pérez
2025-09-01 2:46 ` Jason Wang
2025-09-01 9:11 ` Eugenio Perez Martin
2025-09-03 3:56 ` Jason Wang
2025-09-03 6:39 ` Eugenio Perez Martin
2025-09-08 12:12 ` Yongji Xie
2025-09-16 9:30 ` Eugenio Perez Martin
2025-08-26 11:27 ` [PATCH 6/6] vduse: bump version number Eugenio Pérez
2025-09-15 22:42 ` [PATCH 0/6] Add multiple address spaces support to VDUSE Michael S. Tsirkin
2025-09-16 6:37 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACGkMEsX+D2_12xGDxusO3+BR2bqqXodHHjLy_4TJCpm96jRTA@mail.gmail.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®