From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: virtualization <virtualization@lists.linux-foundation.org>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] vdpa_sim_blk: use dev_dbg() to print errors
Date: Thu, 23 Jun 2022 11:40:43 +0800 [thread overview]
Message-ID: <CACGkMEsdx24TMSw_HgDemNKLAQJfym_fkn-th1HEX8q8ESRoag@mail.gmail.com> (raw)
In-Reply-To: <20220621160859.196646-2-sgarzare@redhat.com>
On Wed, Jun 22, 2022 at 12:09 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> Use dev_dbg() instead of dev_err()/dev_warn() to avoid flooding the
> host with prints, when the guest driver is misbehaving.
> In this way, prints can be dynamically enabled when the vDPA block
> simulator is used to validate a driver.
>
> Suggested-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> index 42d401d43911..a83a5c76f620 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> @@ -76,13 +76,13 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> return false;
>
> if (vq->out_iov.used < 1 || vq->in_iov.used < 1) {
> - dev_err(&vdpasim->vdpa.dev, "missing headers - out_iov: %u in_iov %u\n",
> + dev_dbg(&vdpasim->vdpa.dev, "missing headers - out_iov: %u in_iov %u\n",
> vq->out_iov.used, vq->in_iov.used);
> return false;
> }
>
> if (vq->in_iov.iov[vq->in_iov.used - 1].iov_len < 1) {
> - dev_err(&vdpasim->vdpa.dev, "request in header too short\n");
> + dev_dbg(&vdpasim->vdpa.dev, "request in header too short\n");
> return false;
> }
>
> @@ -96,7 +96,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> bytes = vringh_iov_pull_iotlb(&vq->vring, &vq->out_iov, &hdr,
> sizeof(hdr));
> if (bytes != sizeof(hdr)) {
> - dev_err(&vdpasim->vdpa.dev, "request out header too short\n");
> + dev_dbg(&vdpasim->vdpa.dev, "request out header too short\n");
> return false;
> }
>
> @@ -110,7 +110,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> switch (type) {
> case VIRTIO_BLK_T_IN:
> if (!vdpasim_blk_check_range(sector, to_push)) {
> - dev_err(&vdpasim->vdpa.dev,
> + dev_dbg(&vdpasim->vdpa.dev,
> "reading over the capacity - offset: 0x%llx len: 0x%zx\n",
> offset, to_push);
> status = VIRTIO_BLK_S_IOERR;
> @@ -121,7 +121,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> vdpasim->buffer + offset,
> to_push);
> if (bytes < 0) {
> - dev_err(&vdpasim->vdpa.dev,
> + dev_dbg(&vdpasim->vdpa.dev,
> "vringh_iov_push_iotlb() error: %zd offset: 0x%llx len: 0x%zx\n",
> bytes, offset, to_push);
> status = VIRTIO_BLK_S_IOERR;
> @@ -133,7 +133,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
>
> case VIRTIO_BLK_T_OUT:
> if (!vdpasim_blk_check_range(sector, to_pull)) {
> - dev_err(&vdpasim->vdpa.dev,
> + dev_dbg(&vdpasim->vdpa.dev,
> "writing over the capacity - offset: 0x%llx len: 0x%zx\n",
> offset, to_pull);
> status = VIRTIO_BLK_S_IOERR;
> @@ -144,7 +144,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> vdpasim->buffer + offset,
> to_pull);
> if (bytes < 0) {
> - dev_err(&vdpasim->vdpa.dev,
> + dev_dbg(&vdpasim->vdpa.dev,
> "vringh_iov_pull_iotlb() error: %zd offset: 0x%llx len: 0x%zx\n",
> bytes, offset, to_pull);
> status = VIRTIO_BLK_S_IOERR;
> @@ -157,7 +157,7 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> vdpasim_blk_id,
> VIRTIO_BLK_ID_BYTES);
> if (bytes < 0) {
> - dev_err(&vdpasim->vdpa.dev,
> + dev_dbg(&vdpasim->vdpa.dev,
> "vringh_iov_push_iotlb() error: %zd\n", bytes);
> status = VIRTIO_BLK_S_IOERR;
> break;
> @@ -167,8 +167,8 @@ static bool vdpasim_blk_handle_req(struct vdpasim *vdpasim,
> break;
>
> default:
> - dev_warn(&vdpasim->vdpa.dev,
> - "Unsupported request type %d\n", type);
> + dev_dbg(&vdpasim->vdpa.dev,
> + "Unsupported request type %d\n", type);
> status = VIRTIO_BLK_S_IOERR;
> break;
> }
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-06-23 4:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:08 [PATCH 0/3] vdpa_sim_blk: several fixes for the vDPA block simulator Stefano Garzarella
2022-06-21 16:08 ` [PATCH 1/3] vdpa_sim_blk: use dev_dbg() to print errors Stefano Garzarella
2022-06-23 3:40 ` Jason Wang [this message]
2022-06-21 16:08 ` [PATCH 2/3] vdpa_sim_blk: limit the number of request handled per batch Stefano Garzarella
2022-06-23 3:50 ` Jason Wang
2022-06-23 8:58 ` Stefano Garzarella
2022-06-28 4:01 ` Jason Wang
2022-06-28 7:55 ` Stefano Garzarella
2022-06-21 16:12 ` [PATCH 3/3] vdpa_sim_blk: call vringh_complete_iotlb() also in the error path Stefano Garzarella
2022-06-23 3:52 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACGkMEsdx24TMSw_HgDemNKLAQJfym_fkn-th1HEX8q8ESRoag@mail.gmail.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®