From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FDE15B971 for ; Wed, 23 Oct 2024 09:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729675389; cv=none; b=QZC4xd68ODtvNKaPIfahPu4m69FTsAqSbWeF8eOpWqMrHcufzn66dCil9f78/RXsOBUQijXZR/QsWI4qGZdvL1B349iQmOvRMZb1z68dUw+U8PwqjuIWzfIl7qKOPPY63KMDCKl55mBLT8rcBmv/xBZolu4CkvTCEtlRvmU+C6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729675389; c=relaxed/simple; bh=FV1ZLlJ6ihzrtTWl6CBeIqu9ifr35Cm5491ANjcacY8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=PaoXo3wB09u7c/MKIhrIxNVtNVV2TISOh7a9RBfiz1RJdKpDnuA13jUByEbaVIiPzO1DNjsZt7yfNRVeLxypMWRifT2GnAh9MaJThrxRi+NAy+TgQ56sqHRQ2bvKwSfPcLh9IQSAHpP/FaRTduYbgjkoqizFXZdA6KkYvsippMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HNczZDfw; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HNczZDfw" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6e3c3da5bcdso68407197b3.2 for ; Wed, 23 Oct 2024 02:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729675387; x=1730280187; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FV1ZLlJ6ihzrtTWl6CBeIqu9ifr35Cm5491ANjcacY8=; b=HNczZDfwjAo5JDmhShhuyai5ZYYuijJ1u0CJVAJY9sodKBZTseExmMtSMrhNO7kNgt CJKyk5Y0Ss71oGwC6G8uUdnUo9tIpS9xSD0fQa5Fhbf3pF/GhpQezYC9YvJCg2X/gBxw JJuS5A8S3Rhadeum/yvr/EhmEPwuoP2zpL382APom+OMQj3Q8RiMne5m/s08a0QrggR6 p7X6mgiFxVPOxQU94+0DKxyiEysYZLc/7HwMsfIRZcsKzgp0zFw0Nqjd3HuL4r9nSlA4 xPMjE+5tN+i7d52jhgtGtZIwLjv1ShEudNFYNpo9vIEZE75y0SNBJvEAQWxRc7VXses1 URuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729675387; x=1730280187; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FV1ZLlJ6ihzrtTWl6CBeIqu9ifr35Cm5491ANjcacY8=; b=Z2a/WksFhHBJVslgIfDdFGENm5INpLJLOWadT7GIR9yODjVKEzHl5pKVzX4LYLI0DS xp26xw7HZsVR2CBsfB7Ir0WMQphwHUaOuVGFlMTQ/OlTWvDm4rGr5zSfzWF52OY7nbtE mpCt0z1PHNc7E55x8GxzbvfQVF8bU33xBefOL/4qh1zVevK4fjF+jM2KwNU3hWK1EV7X JoCxnUgHykpkNKVvnnuHmLVlV7syxrghTuqcxMrlB7aBLdX6OvQIsgmu9eVWCJpNIRvT Sixt/LeA5JNF11iqam0cSq3aYDZNidI5zoltICtFpAYuzzdFCCmcUaBLQJ0rpx0wwYuu mBsQ== X-Forwarded-Encrypted: i=1; AJvYcCWHzqFZOYNPo4bNLqs94mSrTN6/qvXqXuUVTXl9qK3nRG+6JQCKBW5HcNJFncqXL2PKPO7v6cRUFu029kI=@vger.kernel.org X-Gm-Message-State: AOJu0YxaubTdS9BBi0nEi6FuQr+HS5R+2JC3PKqBae3qRIgm9QiKJnbB rrqbs9pP3lxFluVJaT42xBXYNN6z7fHOeU0n4F4ViaGj0H8hQLRzblS565j0aHPxma+lsPkeSQa 22sWRmdF81FO9O97R8IhiuMySQlZSn0sJj3bNWg== X-Google-Smtp-Source: AGHT+IGwT/XQGTi9q+W4JK6054qYIT+LVrJhEVBeHkw3KiZ6r1s0bvwN6zFNuF2/oxMRtTdC06ygKUosK4CfLjZmk4w= X-Received: by 2002:a05:690c:2b10:b0:6e5:ac5f:9c43 with SMTP id 00721157ae682-6e7f0fda834mr15598017b3.39.1729675386754; Wed, 23 Oct 2024 02:23:06 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241022-pci-pwrctl-rework-v1-0-94a7e90f58c5@linaro.org> <20241022-pci-pwrctl-rework-v1-2-94a7e90f58c5@linaro.org> In-Reply-To: <20241022-pci-pwrctl-rework-v1-2-94a7e90f58c5@linaro.org> From: Bartosz Golaszewski Date: Wed, 23 Oct 2024 11:22:56 +0200 Message-ID: Subject: Re: [PATCH 2/5] PCI/pwrctl: Create pwrctl devices only if at least one power supply is present To: manivannan.sadhasivam@linaro.org Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Johan Hovold , Abel Vesa , Stephan Gerhold , Srinivas Kandagatla , Bjorn Andersson , stable+noautosel@kernel.org Content-Type: text/plain; charset="UTF-8" On Tue, 22 Oct 2024 at 12:28, Manivannan Sadhasivam via B4 Relay wrote: > > From: Manivannan Sadhasivam > > Currently, pwrctl devices are created if the corresponding PCI nodes are > defined in devicetree. But this is not correct, because not all PCI nodes > defined in devicetree require pwrctl support. Pwrctl comes into picture > only when the device requires kernel to manage its power state. This can > be determined using the power supply properties present in the devicetree > node of the device. > > So add a new API, of_pci_is_supply_present() that checks the devicetree > node if at least one power supply property is present or not. If present, > then the pwrctl device will be created for that PCI node. Otherwise, it > will be skipped. > > Cc: stable+noautosel@kernel.org # Depends on of_platform_device_create() rework > Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node") > Suggested-by: Dmitry Baryshkov > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Bartosz Golaszewski