From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4AAF1EB9FA for ; Tue, 7 Jan 2025 18:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736273778; cv=none; b=ObDbkFVNVEJOAmPWxEbV2v2G03JeAbf3n7Ua3rn0SuzGgAONkOw5aHSVn4V1Cijz3kgCB72N50T3BydPpWCsP6FzpWlf6pI/HobYWl71305p1Frsgask70BFJ/k2IK/MshW2jVQXi6iPGK35r9LEj9FMNZlAnH/ReD7CUeuDslg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736273778; c=relaxed/simple; bh=+OJh+YFDg/UdDZD6b6VZdQG5zcwutYIyrLSE6z+ExwE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cGPtRLfj8SOyrcD/YD6PYzsmXZQyIj/t/M1LYUjwz+WTvexkYnMAfrmNnm8Ut0Jw1r38gEKbWRQvNTbnh/WZLxXws9w48ADaY1YX/MmMujgMV9Rmmkpzu6NF273VlAGueuhs+HltGUP2tA7Z0PGloft1m69wNWyU7QAdEwrbPEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BeGOFGgB; arc=none smtp.client-ip=209.85.221.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BeGOFGgB" Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-51c4bc9cb02so830251e0c.3 for ; Tue, 07 Jan 2025 10:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736273776; x=1736878576; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UExxcpCdfTsbTmzHCTMTBTh1+P52/4iPUCwoN1TLcVg=; b=BeGOFGgBJq6hB870JPlygJV1h6SAbV8R/KHbaFDasCH5gKXyXycOBLXts+0UDdILer 1MxfCPDTIaohKW/jFA4ILGF0hVkqU/908UzwSr3OzzouhtWQXIkOHcYIP7Nf4SKpapNt Fu4C8LycIQBlTxvGcgt29WJZdSgBA9RF3gBg6cqz7yz1ygMzw4mfwvTFMI+YKDtzAM2P +HfwPG0pnEVSCuBvzommjYeiUvfx+PhQA+xfIx/+j7iUz4C+EmRzuB6ycRZHQjRLOciR YJ3ayLrh/qM0hNDJhn5N7E1VVm0Wcl8U6gVjOpgMgi5ZcoQP4V3sThevniCU1sFy8ln7 ULrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736273776; x=1736878576; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UExxcpCdfTsbTmzHCTMTBTh1+P52/4iPUCwoN1TLcVg=; b=GsKdjmIE9tRLygrJQJeeTMJFlHNlkdJW/jSbr+verFZfVq5zSoQyqssHYRD0bp3j8D gQMejcCXsfpk94Cpz5nyGELBLvhbezV4I1JiH6ak7KH75u1HBuz2vfObjHJYCXACS3qY OF+C3O6L/iNWkv41cCDVGhHfiJ8VN89LQzqnRxFM1rCL6bmIfmrAT4fVMU2aR2P498N+ /mPXY29FONsHmtW/3xbE2xUX7EaNdilnMSGKnWRIdmnZN215gbJ7hJ8vdXQmuqbdzk9q DPJ+gO2iw0MZnpCMUl8D59Pftv8329pCNV47jSVWMbD48Z+UCLVojSsUw3Wrz58tyPli +aeg== X-Forwarded-Encrypted: i=1; AJvYcCVVLOiPn95yTFTJhd8qNsWqbIXVh++91N8pgN2oyda1sIHloomIcuy7umN3gy8mUHEKCn3ik/Qylr4sp/I=@vger.kernel.org X-Gm-Message-State: AOJu0YydfckdZwp15lUXOoq3H9Wxi0IMbi2mkfTaztFbhGWZYE1OmdQx 6Lmub02SUPNWTn4rWgmy5oN3paA8SSpR4yMRfXiQxqMTovq42+Bi+qtI3gL/wte3i0348ategpY 9ZmaDP2eXAMJbgV/od3EPTjAkSQ0= X-Gm-Gg: ASbGncvH4s7xSMGMEp5nxl01ipk56PcoIWXL8xBZUmPCwoTwh15snRNNqgDFCc7S/ud LYcz9cb60xhNKGTbQCx5fs82b4+TxTO69dHxO4zqnC68f0RZjKkdywoqUhtVmmO9QZca8 X-Google-Smtp-Source: AGHT+IGaobdeB9My3aaHJEyiFzc/D92OyQLbVj7nK7zwifry6Aa2ccokTW3PmwZ1RPvqK9q1gVblq7+zMTjX6KEpnVs= X-Received: by 2002:a05:6122:458b:b0:518:8bfe:d5f0 with SMTP id 71dfb90a1353d-51c6c2b3d25mr187793e0c.0.1736273775757; Tue, 07 Jan 2025 10:16:15 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250107023248.3702924-1-jaegeuk@kernel.org> <86062930-7a8d-40c5-bbe5-b5bd62fc04ec@kernel.org> In-Reply-To: <86062930-7a8d-40c5-bbe5-b5bd62fc04ec@kernel.org> From: Daeho Jeong Date: Tue, 7 Jan 2025 10:16:03 -0800 X-Gm-Features: AbW1kvbHTq87O4bYIZCdXjj1s_JglS8T3nc-uQtpDQxjih1ixl_auDrPyxKcH_Q Message-ID: Subject: Re: [f2fs-dev] [PATCH] f2fs: don't call block truncation for aliased file To: Chao Yu Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 7, 2025 at 7:00=E2=80=AFAM Chao Yu via Linux-f2fs-devel wrote: > > On 2025/1/7 10:32, Jaegeuk Kim via Linux-f2fs-devel wrote: > > This patch should avoid the below warning which does not corrupt the me= tadata > > tho. > > > > [ 51.508120][ T253] F2FS-fs (dm-59): access invalid blkaddr:36 > > [ 51.508156][ T253] __f2fs_is_valid_blkaddr+0x330/0x384 > > [ 51.508162][ T253] f2fs_is_valid_blkaddr_raw+0x10/0x24 > > [ 51.508163][ T253] f2fs_truncate_data_blocks_range+0x1ec/0x438 > > [ 51.508177][ T253] f2fs_remove_inode_page+0x8c/0x148 > > [ 51.508194][ T253] f2fs_evict_inode+0x230/0x76c > > > > Fixes: 128d333f0dff ("f2fs: introduce device aliasing file") > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/node.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > > index c04ee1a7ce57..06313e1eb884 100644 > > --- a/fs/f2fs/node.c > > +++ b/fs/f2fs/node.c > > @@ -1274,6 +1274,12 @@ int f2fs_remove_inode_page(struct inode *inode) > > return err; > > } > > > > + /* The aliase file must be truncated successfully. */ > > + if (unlikely(IS_DEVICE_ALIASING(inode))) { > > + f2fs_put_dnode(&dn); > > + return 0; > > Do we need to keep calling truncate_node() for device alias inode in > f2fs_remove_inode_page()? > > Thanks, > > > + } > > + > > /* remove potential inline_data blocks */ > > if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || > > S_ISLNK(inode->i_mode)) > How about modifying like the below? /* remove potential inline_data blocks */ if (!IS_DEVICE_ALIASING(inode) && (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode))) Thanks, > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel