From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbdIFFXw (ORCPT ); Wed, 6 Sep 2017 01:23:52 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35369 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbdIFFXt (ORCPT ); Wed, 6 Sep 2017 01:23:49 -0400 X-Google-Smtp-Source: ADKCNb4HgNlwVOhCTPIUQv1wkJO1fb3uUj4fJaDQrzRJO7b15Ld4cuo2ccQmOdzcYxXlXv97Uih5rUGObbvMFhqa4CI= MIME-Version: 1.0 In-Reply-To: <20170906003016.2159-3-brendanhiggins@google.com> References: <20170906003016.2159-1-brendanhiggins@google.com> <20170906003016.2159-3-brendanhiggins@google.com> From: Joel Stanley Date: Wed, 6 Sep 2017 14:53:26 +0930 X-Google-Sender-Auth: 2F2ulwkpDLVJdT1FJs9aESVTvp8 Message-ID: Subject: Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree To: Brendan Higgins Cc: Rob Herring , Mark Rutland , Russell King , avifishman70@gmail.com, tmaimon77@gmail.com, Rick Altherr , Florian Fainelli , devicetree , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins wrote: > +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt > @@ -0,0 +1,6 @@ > +NPCM Platforms Device Tree Bindings > +----------------------------------- > +NPCM750 SoC > +Required root node properties: > + - compatible = "nuvoton,npcm750"; > + This is minimal. I assume there will be more content added as more support is added? Does it need it's own directory? > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > new file mode 100644 > index 000000000000..54df32cff21b > --- /dev/null > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts > + > +/dts-v1/; > +#include "nuvoton-npcm750.dtsi" > + > +/ { > + model = "Nuvoton npcm750 Development Board (Device Tree)"; > + compatible = "nuvoton,npcm750"; > + > + chosen { > + stdout-path = &serial3; > + bootargs = "earlyprintk=serial,serial3,115200"; > + }; > + > + memory { > + reg = <0 0x40000000>; > + }; > + > + cpus { > + enable-method = "nuvoton,npcm7xx-smp"; > + }; > + > + clk: clock-controller@f0801000 { > + status = "okay"; > + }; > + > + apb { > + watchdog1: watchdog@f0009000 { > + status = "okay"; > + }; You've already got the label for the node, is there are reason you don't use a phandle to set the status? &watchdog1 { status = "okay"; }; Same with the serial nodes below. > + > + serial0: serial0@f0001000 { > + status = "okay"; > + }; > + > + serial1: serial1@f0002000 { > + status = "okay"; > + }; > + > + serial2: serial2@f0003000 { > + status = "okay"; > + }; > + > + serial3: serial3@f0004000 { > + status = "okay"; > + }; > + };