From: Joel Stanley <joel@jms.id.au>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Rob Herring <robh@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver
Date: Fri, 23 Sep 2016 15:32:03 +0930 [thread overview]
Message-ID: <CACPK8XcWbgfW_==aVjUataA2Yk26TSaO2o3Vt0pR68qKpkYxuA@mail.gmail.com> (raw)
In-Reply-To: <CAFd5g46j02sb2w_DwaXAgnfcO=ONmJGZwqdRneNd0QHq-t53rA@mail.gmail.com>
Hi Brendan,
On Wed, Sep 21, 2016 at 3:35 AM, Brendan Higgins
<brendanhiggins@google.com> wrote:
> First off, someone pointed out to me that the mapping that I used between
> addresses and bus numbers is not actually valid for busses 8-14.
>
> This could be fixed by checking the offset, but I am wondering if that is
> the right way to do it. It seems like this is not completely trivial so
> maybe this should be specified in the device tree? If that is the case,
> should I do this as another reg entry or go back to the way I was doing it
> before?
I don't see an alternative way to derive these numbers. As you
mention, the block of SRAM in the middle of the IP screwing up the
linear mapping.
I suggest going back to what you have in v2, with a mention in the
commit message as to why the bus property is necessary.
Cheers,
Joel
next prev parent reply other threads:[~2016-09-23 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 19:54 [PATCH 0/2] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2016-09-09 19:54 ` [PATCH 1/2] " Brendan Higgins
2016-09-09 22:48 ` kbuild test robot
2016-09-10 0:48 ` kbuild test robot
2016-09-10 1:55 ` [PATCH v2 " Brendan Higgins
2016-09-10 1:55 ` [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2016-09-19 21:35 ` Rob Herring
2016-09-19 23:26 ` Brendan Higgins
2016-09-20 18:08 ` Brendan Higgins
2016-09-20 23:03 ` Brendan Higgins
[not found] ` <CAFd5g46j02sb2w_DwaXAgnfcO=ONmJGZwqdRneNd0QHq-t53rA@mail.gmail.com>
2016-09-23 6:02 ` Joel Stanley [this message]
2016-09-19 17:56 ` [PATCH v2 1/2] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2016-09-19 23:23 ` [PATCH v3 " Brendan Higgins
2016-09-19 23:23 ` [PATCH v3 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2016-09-23 18:02 ` Rob Herring
2016-10-12 20:01 ` Brendan Higgins
2016-09-09 19:54 ` [PATCH " Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XcWbgfW_==aVjUataA2Yk26TSaO2o3Vt0pR68qKpkYxuA@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®