From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19476C388F7 for ; Wed, 28 Oct 2020 23:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98EAE20790 for ; Wed, 28 Oct 2020 23:12:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="HM99HBk8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389751AbgJ1XM3 (ORCPT ); Wed, 28 Oct 2020 19:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727308AbgJ1XMA (ORCPT ); Wed, 28 Oct 2020 19:12:00 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0423C0613CF; Wed, 28 Oct 2020 16:11:59 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id x20so639081qkn.1; Wed, 28 Oct 2020 16:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ELimXLIjFFEyZU/ch1CMaoy2YuMN5MJVjff2er+s7NQ=; b=HM99HBk83YvD2YeS+eQsdX3b8HsDJPHH2RUbI86H++j7WB8wVMh0dqhupICJ4TmMd+ JHaTXnKkRz33Mz2ZhTVPwiICOg0FYj7XW93kWewABTZf9Fp5rOlUwYQ2/tV+lQGFTRtk v6z4LQ92auwCat4tQ5JI+JVoxqgPR9uiC5nbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ELimXLIjFFEyZU/ch1CMaoy2YuMN5MJVjff2er+s7NQ=; b=U77akUT5S+Ok8qtefUwpMPBXbS/bs6UqVqLWrcbEh939n7ZiDisJj9eTaFQLbtQzBL 1SYOTRygFQsQegx9acCi+vo5lUG8wChwRq4oEUTJ3hc1vTHC0eXicOqqcvBIWQ39JbuS Ms0zyVQ6Bk157eFocZWYIASIyLpIZPrLp+jBtPJPzyPl+L5lafBpRQqlmDSDi6ncgBMS aMT+dzsjpohU5z6c1R/D8gt5MCBFK+jMl6s2PGsQcRONGC1CN3tctNOotQ4eRA9iAn7R DSBurzV3znI50C7ZSJXU5zbXS4uUhEdfexRF3KEqCW2C0Uk7hrWK7+ikfjNQKbTqcHLE U8HQ== X-Gm-Message-State: AOAM5309WgVIW23np2xSm1D+P9QkKlFJRli8qyaIjDgQnYZuv4aTGPI2 Km6gMxdkMk/PZ3bc32HSKhaNGaUwJ3+fuoczHavmYK052Qs= X-Google-Smtp-Source: ABdhPJw4sL0/a9JoSrIwywzd8l+q04n/V4qcoRQ1usL9+UKdAACMkTARtNb9rBqxdCnSCJBOQ/U2QBCJqcZJxGf9rjM= X-Received: by 2002:ac8:794f:: with SMTP id r15mr409042qtt.385.1603859268783; Tue, 27 Oct 2020 21:27:48 -0700 (PDT) MIME-Version: 1.0 References: <20201008015106.3198-1-billy_tsai@aspeedtech.com> <20201008015106.3198-3-billy_tsai@aspeedtech.com> In-Reply-To: From: Joel Stanley Date: Wed, 28 Oct 2020 04:27:36 +0000 Message-ID: Subject: Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting To: Billy Tsai Cc: Jeremy Kerr , Andrew Jeffery , Rob Herring , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2020 at 05:25, Billy Tsai wrote: > > Hi Joel, > > On 2020/10/8, 11:49 AM, Joel Stanley wrote: > > On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > > > for sgpiom1 > > > > The code looks good Billy. > > > > Please split the change in two: device tree changes (arch/arm/dts) in > > one, and pinctrl in the second, as they go through different > > maintainers. > > > > If I split the change in two, the patch of dts will have a compiler error. > Because that the sgpiom1 node needs the pinctrl symbol "&pinctrl_sgpm2_default". The drivers/pinctrl/ changes should be split from the arch/arm/boot/dts/ changes. You should keep the arch/arm/boot/dts/ changes in the same patch. Cheers, Joel