mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kairui Song <kasong@redhat.com>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Omar Sandoval <osandov@fb.com>, Baoquan He <bhe@redhat.com>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v3] x86/gart/kcore: Exclude GART aperture from kcore
Date: Wed, 6 Mar 2019 16:20:31 +0800	[thread overview]
Message-ID: <CACPcB9fkho7n16Q9mDVddQF_8hyArP7ZyzS6q87e+b-R+wX1RQ@mail.gmail.com> (raw)
In-Reply-To: <20190228231202.3wvojgxscrodoalt@dwarf.suse.cz>

On Fri, Mar 1, 2019 at 7:12 AM Jiri Bohac <jbohac@suse.cz> wrote:
>
> On Wed, Feb 13, 2019 at 04:28:00PM +0800, Kairui Song wrote:
> > @@ -465,6 +472,12 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos)
> >                               goto out;
> >                       }
> >                       m = NULL;       /* skip the list anchor */
> > +             } else if (m->type == KCORE_NORAM) {
> > +                     /* for NORAM area just fill zero */
> > +                     if (clear_user(buffer, tsz)) {
> > +                             ret = -EFAULT;
> > +                             goto out;
> > +                     }
>
> I don't think this works reliably. The loop filling the buffer
> has this logic at the top:
>
>         while (buflen) {
>                 /*
>                  * If this is the first iteration or the address is not within
>                  * the previous entry, search for a matching entry.
>                  */
>                 if (!m || start < m->addr || start >= m->addr + m->size) {
>                         list_for_each_entry(m, &kclist_head, list) {
>                                 if (start >= m->addr &&
>                                     start < m->addr + m->size)
>                                         break;
>                         }
>                 }
>
> This sets m to the kclist entry that contains the memory being
> read. But if we do a large read that starts in valid KCORE_RAM
> memory below the GART overlap and extends into the overlap, m
> will not be set to the KCORE_NORAM entry. It will keep pointing
> to the KCORE_RAM entry and the patch will have no effect.
>
> But this seems already broken in existing cases as well, various
> KCORE_* types overlap with KCORE_RAM, don't they?  So maybe
> bf991c2231117d50a7645792b514354fc8d19dae ("proc/kcore: optimize
> multiple page reads") broke this and once fixed, this KCORE_NORAM
> approach will work. Omar?
>

Thanks for the review! You are right, although I hid the NORAM region
from the elf header, but didn't notice this potential risk of having
overlapped region.
I didn't see other kcore regions overlap for now, if so the
optimization should be totally good.
Better to keep using a hook just like what we did in vmcore or we will
have a performance drop for "fixing" this.
Will send V4 using the previous approach if there are no further comments.

-- 
Best Regards,
Kairui Song

      reply	other threads:[~2019-03-06  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13  8:28 Kairui Song
2019-02-25  7:42 ` Kairui Song
2019-02-28 23:12 ` Jiri Bohac
2019-03-06  8:20   ` Kairui Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPcB9fkho7n16Q9mDVddQF_8hyArP7ZyzS6q87e+b-R+wX1RQ@mail.gmail.com \
    --to=kasong@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jbohac@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=osandov@fb.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®