From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbdHGMSp (ORCPT ); Mon, 7 Aug 2017 08:18:45 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:35553 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbdHGMSm (ORCPT ); Mon, 7 Aug 2017 08:18:42 -0400 MIME-Version: 1.0 In-Reply-To: <1501675570.29303.353.camel@linux.intel.com> References: <20170725205800.GA25245@dtor-ws> <1501064497.29303.251.camel@linux.intel.com> <20170801192418.GE28401@dtor-ws> <1501675570.29303.353.camel@linux.intel.com> From: Linus Walleij Date: Mon, 7 Aug 2017 14:18:40 +0200 Message-ID: Subject: Re: [PATCH] gpio: add gpio_add_lookup_tables() to add several tables at once To: Andy Shevchenko Cc: Dmitry Torokhov , Lars-Peter Clausen , Mika Westerberg , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 2, 2017 at 2:06 PM, Andy Shevchenko wrote: > On Tue, 2017-08-01 at 12:24 -0700, Dmitry Torokhov wrote: >> On Wed, Jul 26, 2017 at 01:21:37PM +0300, Andy Shevchenko wrote: >> > On Tue, 2017-07-25 at 13:58 -0700, Dmitry Torokhov wrote: >> > > When converting legacy board to use gpiod API() there migt be >> > > several >> > > lookup tables in board file, let's provide a way to register them >> > > all >> > > at >> > > once. >> > >> > Looking into the code which is using several GPIO look up tables I >> > noticed that the pattern often something like >> > >> > >> > gpiod_add_lookup_table(x_tbl); >> > platform_device_register(x_dev); >> > >> > ... >> > >> > gpiod_add_lookup_table(y_tbl); >> > platform_device_register(y_dev); >> > >> > which looks also logical. >> > >> > So, I have no strong opinion here, though it would be nice to have >> > an >> > example where it makes sense. >> >> Here is an example. It actually does not have multiple GPIO tables, >> but >> it allows to keep the structure of init sequence for the board, which >> relies on having series of arrays conditionally populated with devices >> and other data that need to be registered. > > I see your point. Okay, no objections from me. > > Please, add a stub for !GPIOLIB case. > > After addressing it, > > Reviewed-by: Andy Shevchenko OK I wait for the stub-inclusive patch. Yours, Linus Walleij