From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A110023D7D9 for ; Tue, 14 Oct 2025 19:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760469454; cv=none; b=NPw48wq1NJLPCZqHfI/GEanlYiUkIPIxJzaK3Zk1rZxGTSkuyUEdkaPXqRvtmpThx8ihKBxDio/CEZ3dGW5p2BvzxAa3CVqiQyxnUFChHuynZZLZ9yc6il9dYYPNvrVdbOPMC4Y+vKsfjMWVjTNyfkXkIeggeJesGZaztVCIJDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760469454; c=relaxed/simple; bh=v7ZDvyx+at8OgOme+TAX8QT70PNDFj+9qBTaC8/DA+o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=XbMfCybSL/j8ND27uNnZmPg7XJdQVnbr0v+/UQoGoP+bZQI/bLzXvWCUZQgdSQ5s1fFCfWW9nilKj4KE7MGSjHd7R4x02Z/15a4sdv2Tzxo56WOsHVyV0VyNblJpbk4z0CPV+KSnzBcfC8XtgSokBQmGQAfnzXYXYSoRXQmouUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q4ZLWjNJ; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q4ZLWjNJ" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5818de29d15so7130047e87.2 for ; Tue, 14 Oct 2025 12:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760469451; x=1761074251; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9u2xhRjxMY0OHfkeZgBaJjHDhZQq+aqtFfr5uDFVIn8=; b=Q4ZLWjNJDbCSVz7OScHAy552KlNdqIOKFqgFskvUBC8EtVOZPYNCIEoWl23FlDl2wg RE4xw06ZDcScOtGUMxNWIgLfhQ7jz0V89DD/G/KCMMs89ZuoVfJ3oKXakLYviKX5o6s5 SaNjoRhqoCncO+Duoo8hKb61fk4MGqabEVhAJCfJdLc84M/9Zau82l8yajly4a4X0k7l m4oIc2uE9vrIUQuMnHx9JUMMmNhtvYNseplDcVQeZAtFu6G9VjIQcZUs+BhbGeaKa3Fp yjDNRObWF5BzPgaukDX2zwlOIkxSKX8LikkW/iLFzoA5fncZ5YHDBtipOs2fEKqg3QUf 88lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760469451; x=1761074251; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9u2xhRjxMY0OHfkeZgBaJjHDhZQq+aqtFfr5uDFVIn8=; b=K53o5FqYLJirDNZ3/IXYuJGjwiCdZBBFHhKJwY+n8E9JJwa4ONia43Fbg8o7Tk3em5 6IKiGuxG+KNyLQMYFhnbfZDlZh4mEtZqnXFAz+12GoKr+XdaIkuGn79OoxIDW+0zuV6J 1/faZCOu9Ig42xJTPuIgWqazOBJzLdwEGVSmynlO19b7GKszP47kQa84jd5QZcS0hXPS r/0QkpHPiDLkAdJULf18e20NivhhMOjhqbVAydRx3Ei8stwRvTHJQKvK0wVD1bakgmen jML/Rcm9J84cRqz3Zgk7URQIEJWzacE09cOWo0BJMggQiK3uR5QkNHTTvhidUBTTAkMN Uqvw== X-Forwarded-Encrypted: i=1; AJvYcCV67SHRp4LPL1Omf8xZ4Xx02LGaxy1FxOnzWQkcQoxu5jveTUmYSenZUY4JCE60oPd8WXIa7heT5dHruus=@vger.kernel.org X-Gm-Message-State: AOJu0YzsiO9rM61pSSO0d7252B/C0d+lKhxfmdR5C4cDZDdQe19oQPX5 aDL5V5YCqgtZDXOYwxlVW3+i/Tc9ep40Qn+2ZxOEMTQq2YOMH76ICMkKz8myP8w57xZsiHg6H5A cOZFaaPsALVVvKcDti7IDRr8xGw9b+rQ3pKQlBPRS4w== X-Gm-Gg: ASbGncuWhKZ/LDYyrBXYF+DF3ItKaAMtxE4Zg5KWpA5WD/HNuAQpQeOTFWaOtqTVIlI /8M7yuRdHQBXHeeaNha/CvYODBiUvtBa+oBuUpGUodFgG+k8uP0Qxgt+8dGmKmIfxUJVbTrXhgs Hf/6busBskaKL+/j9O0Q9ZdG5H9FQAUJgq6XyUtayeffV4OZIqF9Tm/DomO9shIHWlEw50NO2V7 DI3SR+IhiUVtX6uyiu3UJN65eOYVw== X-Google-Smtp-Source: AGHT+IEGUS4Gd3DOiYb0CWjdPtTrv4xdAxyOe7Tv+OqMwGviA724GimvTCnIrTO1U+O4G506e5yK1WmR/GzoIGF6mSU= X-Received: by 2002:a05:6512:3d23:b0:58b:189:871e with SMTP id 2adb3069b0e04-5906dc12463mr7452727e87.3.1760469450698; Tue, 14 Oct 2025 12:17:30 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251014015712.2922237-1-gary.yang@cixtech.com> <20251014015712.2922237-2-gary.yang@cixtech.com> <20251014-backyard-parted-572627bfc540@spud> In-Reply-To: <20251014-backyard-parted-572627bfc540@spud> From: Linus Walleij Date: Tue, 14 Oct 2025 21:17:19 +0200 X-Gm-Features: AS18NWAUmIlF_t1r_m5_roptigL3TJ5IfhnwTJl60nwKQLpHKJKzA9shz3gKjcE Message-ID: Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl To: Conor Dooley Cc: Gary Yang , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cix-kernel-upstream@cixtech.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 14, 2025 at 7:58=E2=80=AFPM Conor Dooley wro= te: > > > + drive-strength: > > > + description: > > > + Can support 15 levels, from DS_LEVEL1 to DS_LEVEL15. > > > + defined as macros in arch/arm64/boot/dts/cix/sky1-pinf= unc.h. (side note to Gary: drop the reference to the arch/arm64 etc sky1-pinfunc.h file, this is Linux-specific and U-Boot and BSD will be confused) > Isn't this wrong? > drive-strength is in mA but you're just shoving register values in here. > pw-bot: changes-requested That's right, Gary do you think you can add a mA->strength value translation table into the driver and let this be configured in mA? > > type: object > > $ref: /schemas/pinctrl/pinmux-node.yaml > > $ref: /schemas/pinctrl/pincfg-node.yaml > > additionalProperties: false > > > > Something like this, I never get this right before actually testcompili= ng... > > spacemit,k1-pinctrl has a node of this type, that can be copied from > Gary. Essentially, you need an allOf: for the two references. Neat, thanks Conor! Yours, Linus Walleij