From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964996AbcFMHWc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 03:22:32 -0400
Received: from mail-oi0-f46.google.com ([209.85.218.46]:36571 "EHLO
	mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964849AbcFMHW3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 03:22:29 -0400
MIME-Version: 1.0
In-Reply-To: <20160609053204.32398-1-vigneshr@ti.com>
References: <20160609053204.32398-1-vigneshr@ti.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Mon, 13 Jun 2016 09:22:27 +0200
Message-ID: <CACRpkdYZEbefjr-iHT3yahkBovFuE2Ofvr8_Mr+X++pJSVwzfA@mail.gmail.com>
Subject: Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536
To: Vignesh R <vigneshr@ti.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 9, 2016 at 7:32 AM, Vignesh R <vigneshr@ti.com> wrote:

> NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
> hence results in 0 banks for PCA9536 which has just 4 gpios. This is
> wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
> PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
> NBANK().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vignesh R <vigneshr@ti.com>

Patch applied.

Is this really a regression or affecting systems in development?

Which machine/device tree makes this problematic?

Yours,
Linus Walleij