From: Linus Walleij <linus.walleij@linaro.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>, Marc Zyngier <maz@kernel.org>,
Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
Russell King <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Removal of config MACH_FSG and dead reference in LEDS_FSG
Date: Mon, 22 Nov 2021 00:03:57 +0100 [thread overview]
Message-ID: <CACRpkdYfqrSOJYh9trvcioBAVXZRZsjhNEgxpCNFtpjJCPrMfg@mail.gmail.com> (raw)
In-Reply-To: <CAKXUXMxBW0qM06i7TvFG+8HrwbR1eYR+9Ed648aZ95mtXiA7Tg@mail.gmail.com>
On Fri, Nov 12, 2021 at 8:59 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Your commit b71377b3e1e0 ("ARM: ixp4xx: Delete the Freecom FSG-3
> boardfiles") removes the config MACH_FSG. Hence, the config LEDS_FSG
> and its corresponding driver leds-fsg.c is effectively not selectable.
> I do not know much about how with device trees we ensure that specific
> drivers are selected, or how Kconfig build dependencies are combined
> with device trees properly here. So, I do not know what the right
> patch is here.
>
> Was it intended that this code is now made obsolete? Can this driver
> really be deleted?
Oops no.
> Or does it require just some further adjustment to make the leds-fsg
> driver productive again?
Yes. I'll look into it!
Yours,
Linus Walleij
prev parent reply other threads:[~2021-11-21 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 7:58 Lukas Bulwahn
2021-11-21 23:03 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYfqrSOJYh9trvcioBAVXZRZsjhNEgxpCNFtpjJCPrMfg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=kaloz@openwrt.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khalasa@piap.pl \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®