From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbcJCW1J (ORCPT ); Mon, 3 Oct 2016 18:27:09 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33042 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbcJCW1C (ORCPT ); Mon, 3 Oct 2016 18:27:02 -0400 MIME-Version: 1.0 In-Reply-To: <20160927012042.6739-1-paul.gortmaker@windriver.com> References: <20160927012042.6739-1-paul.gortmaker@windriver.com> From: Linus Walleij Date: Tue, 4 Oct 2016 00:27:01 +0200 Message-ID: Subject: Re: [PATCH] bus: qcom-ebi2: make it explicitly non-modular To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2016 at 3:20 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/bus/Kconfig:config QCOM_EBI2 > drivers/bus/Kconfig: bool "Qualcomm External Bus Interface 2 (EBI2)" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We don't replace module.h with init.h since the file already has that. > > Cc: Linus Walleij > Signed-off-by: Paul Gortmaker I was asked during review to make it a module, from originally being a bool. Just missed to update Kconfig as it seems :( So the right patch is a oneliner making it tristate. Yours, Linus Walleij