From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941611AbcJ0UL0 (ORCPT ); Thu, 27 Oct 2016 16:11:26 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:34165 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934289AbcJ0ULZ (ORCPT ); Thu, 27 Oct 2016 16:11:25 -0400 MIME-Version: 1.0 In-Reply-To: <6dcaf788e4ebffd5c753e5fc5ae67668f74f7c32.1477530195.git.eric.jeong@diasemi.com> References: <6dcaf788e4ebffd5c753e5fc5ae67668f74f7c32.1477530195.git.eric.jeong@diasemi.com> From: Linus Walleij Date: Thu, 27 Oct 2016 22:11:23 +0200 Message-ID: Subject: Re: [PATCH V2 2/4] mfd: pv88080: MFD core support To: Eric Jeong , Wolfram Sang Cc: LINUX-KERNEL , Lee Jones , Alexandre Courbot , DEVICETREE , LINUX-GPIO , Liam Girdwood , Mark Brown , Mark Rutland , Rob Herring , Support Opensource Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2016 at 3:03 AM, Eric Jeong wrote: > From: Eric Jeong > > This patch adds supports for PV88080 MFD core device. > > It provides communication through the I2C interface. > It contains the following components: > - Regulators > - Configurable GPIOs > > Kconfig and Makefile are updated to reflect support for PV88080 PMIC. > > Signed-off-by: Eric Jeong (...) > drivers/mfd/pv88080-i2c.c | 99 ++++++++++++++++ This looks like a pure I2C driver. Why is it not in drivers/i2c/busses/i2c-pv88080.c? Yours, Linus Walleij