From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbdLBPzw (ORCPT ); Sat, 2 Dec 2017 10:55:52 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:33746 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbdLBPzu (ORCPT ); Sat, 2 Dec 2017 10:55:50 -0500 X-Google-Smtp-Source: AGs4zMaN7wDnFxv0bE35tsKZpEFHf6KqoGgVVcpKWsi7CRWoVFqwM7DpKt3CBUGd1KpU/vCzKc6KHvS44EkHSjRUAd4= MIME-Version: 1.0 In-Reply-To: <7fdc42fd2d3572069292ebe1376bb446beb4d8a9.1512135804.git-series.quentin.schulz@free-electrons.com> References: <7fdc42fd2d3572069292ebe1376bb446beb4d8a9.1512135804.git-series.quentin.schulz@free-electrons.com> From: Linus Walleij Date: Sat, 2 Dec 2017 16:55:48 +0100 Message-ID: Subject: Re: [PATCH v4 03/10] dt-bindings: gpio: gpio-axp209: add pinctrl features To: Quentin Schulz Cc: Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , Maxime Ripard , Lee Jones , linux-gpio@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Linux ARM , Thomas Petazzoni , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 1, 2017 at 2:44 PM, Quentin Schulz wrote: > The X-Powers AXP209 has 3 GPIOs. GPIO0/1 can each act either as a GPIO, > an ADC or a LDO regulator. GPIO2 can only act as a GPIO. > > This adds the pinctrl features to the driver so GPIO0/1 can be used as > ADC or LDO regulator. > > Signed-off-by: Quentin Schulz > Acked-by: Rob Herring Please add a reference to the generic pinctrl bindings and state that you use them and how. pinctrl/pinctrl-bindings.txt > +The GPIOs can be muxed to other functions and therefore, must be a subnode of > +axp_gpio. > + > +Example: > + > +&axp_gpio { > + gpio0_adc: gpio0-adc { > + pins = "GPIO0"; > + function = "adc"; > + }; > +}; So write explicitly that this driver employs the per-pin muxing pattern. Yours, Linus Walleij