From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CB2C433FE for ; Tue, 8 Nov 2022 14:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233995AbiKHOvL (ORCPT ); Tue, 8 Nov 2022 09:51:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233947AbiKHOvI (ORCPT ); Tue, 8 Nov 2022 09:51:08 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16D3613FA2 for ; Tue, 8 Nov 2022 06:51:07 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id 13so39320600ejn.3 for ; Tue, 08 Nov 2022 06:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5RfhvWt1Tv41V7xOdh182isXRfcqnMCvMMU4ZxjHa4I=; b=vgPgq/fKoy91SWpS9t2e6oRNux2GYZ11uz4nq69Ecusn/WQxEr9PnRkXeciq96q9Kf Y/uc1JXxwDcE7DZk4ERIHWnMD3xCOKQOkmZ9szh6zLYAHlS8jB3/9Vzu0GTEcRvD273p QcJzqGu94FAUp4fND/CyiussZorc4AISQgkF6NZxvG/MLLVHHNxJkea27kaoeMZFf8NM MrPmIrciQQHldO1W0L/ICYsoJczxk/E5K1ku/kfcnyWtcEYwFARIfMuiqAHSi0RwOReo 3xg6N55uGAcHesseexA8+25xPiouSe/QNOgAQpSqMWJsa4JVGZPnnvoO6B0S9mYDKIX0 HTaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5RfhvWt1Tv41V7xOdh182isXRfcqnMCvMMU4ZxjHa4I=; b=SGqorLdLjRPZwGoQBXajtOgTd7aaqT2w6UxcuzfRccup6fLgzlLCpIBcBht6zhJyMT v8ZADX1pMQ6sAzw0dU1uFL0uq6A/YLUjMMKh67rqveAeXCR3FmxWQquI0Ub0D+xkxVEb xGrOjF7a9xxS/Sc0kNdKeOXEOLkd9qhdFOLJiz8M0PoNmvgJnt5+6PYbBEZ0l5/lA9jD OQ3ENmRplI8dP3G4SdTpLmPMf7LRtvQ8zPlAl7VJV/gkSsGYK1gxamur0YhUP+yWGFxO wAO1kJX6wwgfmrkZ4NwnmHyTek7obS+9XPY8gMmuvs9h3NceH/mSpXLAQssZZrG+ecIA Eesg== X-Gm-Message-State: ACrzQf2c3YYmDo5ZscRYt39uhShoQ3ktjQX58/601LLLSKlLmyPsA8OH Roen3O3yjcyOoPsWWIZsVOwnVWwVLSw7ZDvAVvaIGA== X-Google-Smtp-Source: AMsMyM43GACP12dQZV6v3KIC5Qxaj6QVCASShwmiPx6+SaG+30Y/RBMbREK4KJlCmGU7p1c/8UJC8IQmuja8j8BZsDc= X-Received: by 2002:a17:907:c1e:b0:7ae:31a0:571e with SMTP id ga30-20020a1709070c1e00b007ae31a0571emr21471098ejc.690.1667919065615; Tue, 08 Nov 2022 06:51:05 -0800 (PST) MIME-Version: 1.0 References: <20221025070255.14407-1-linux@fw-web.de> In-Reply-To: From: Linus Walleij Date: Tue, 8 Nov 2022 15:50:44 +0100 Message-ID: Subject: Re: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC To: Frank Wunderlich Cc: Krzysztof Kozlowski , Frank Wunderlich , linux-mediatek@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 4, 2022 at 5:04 PM Frank Wunderlich wrote: > > Gesendet: Dienstag, 25. Oktober 2022 um 20:35 Uhr > > Von: "Krzysztof Kozlowski" > > Betreff: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC > > > > On 25/10/2022 03:02, Frank Wunderlich wrote: > > > From: Frank Wunderlich > > > > > > Add new splitted uart pins and emmc_51 > > > > > > Signed-off-by: Frank Wunderlich > > > > > > Acked-by: Krzysztof Kozlowski > > after talking with MTK for the emmc pinctrl settings (custom pull-up) they suggested me to change > binding to fix other emmc-values and allow multiple (2) uart-items > > so on top of this patch > > then: > properties: > groups: > - enum: [emmc, emmc_rst, emmc_51] > + enum: [emmc_45, emmc_51] > - if: > properties: > function: > @@ -231,10 +231,12 @@ patternProperties: > then: > properties: > groups: > - enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1, > - uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx, > - uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts, > - uart2_1, uart0, uart1, uart2] > + items: > + enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1, > + uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx, > + uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts, > + uart2_1, uart0, uart1, uart2] > + maxItems: 2 > > i would squash these changes and send as v3 or should i send an extra-patch? Squash and send av v3 if you haven't already! Easiest for me. Yours, Linus Walleij