From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753227AbdF2MwI (ORCPT ); Thu, 29 Jun 2017 08:52:08 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:33695 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbdF2Mv5 (ORCPT ); Thu, 29 Jun 2017 08:51:57 -0400 MIME-Version: 1.0 In-Reply-To: <20170627002533.97293-1-mka@chromium.org> References: <20170627002533.97293-1-mka@chromium.org> From: Linus Walleij Date: Thu, 29 Jun 2017 14:51:56 +0200 Message-ID: Subject: Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable To: Matthias Kaehlcke Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Doug Anderson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2017 at 2:25 AM, Matthias Kaehlcke wrote: > Don't inflate the kernel size with data that isn't used. The conditional > declaration also fixes the following warning when building with clang: > > drivers/iio/magnetometer/ak8975.c:704:36: error: variable 'ak_acpi_match' > is not needed and will not be emitted > [-Werror,-Wunneeded-internal-declaration] > > Signed-off-by: Matthias Kaehlcke Acked-by: Linus Walleij Yours, Linus Walleij