From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbbD2VtA (ORCPT ); Wed, 29 Apr 2015 17:49:00 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35969 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbbD2Vs5 (ORCPT ); Wed, 29 Apr 2015 17:48:57 -0400 MIME-Version: 1.0 In-Reply-To: <1429630951-27082-4-git-send-email-johan@kernel.org> References: <1429630951-27082-1-git-send-email-johan@kernel.org> <1429630951-27082-4-git-send-email-johan@kernel.org> Date: Wed, 29 Apr 2015 23:48:57 +0200 Message-ID: Subject: Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq From: Linus Walleij To: Johan Hovold Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold wrote: > Drop redundant lock-as-irq in gpio_setup_irq, which has already been > handled when requesting and releasing the irq (i.e. in the irq chip > irq_request_resources and irq_release_resources callbacks). Well we would hope they all do that. And I hope for the vast majority that is true, but there is a TODO to go over all gpiochip drivers (some which are elsewhere in the kernel than drivers/gpio) and make sure they actually do so. Right now it's a bit arbitrary if so happens, and in not marked by the driver as IRQ then this kicks in and provides an additional protection. But maybe that's overzealous, what do people say? Yours, Linus Walleij