mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Sean Paul <seanpaul@chromium.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Sangsu Park <sangsu4u.park@samsung.com>
Cc: grant.likely@secretlab.ca, linus.walleij@stericsson.com,
	linux-kernel@vger.kernel.org, olofj@chromium.org,
	dianders@chromium.org
Subject: Re: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses
Date: Sat, 28 Jul 2012 01:09:30 +0200	[thread overview]
Message-ID: <CACRpkdZupvxyadxi8GppP6W2Pe5-eOcdjYYAcS28euUk8vx9iQ@mail.gmail.com> (raw)
In-Reply-To: <1342817939-7118-1-git-send-email-seanpaul@chromium.org>

On Fri, Jul 20, 2012 at 10:58 PM, Sean Paul <seanpaul@chromium.org> wrote:

> Move gpc4 to the end of the automatically processed gpio controllers so
> we don't taint the automatic offset calculation.
>
> This bug caused all controllers coming after gpc4 to map to the
> incorrect address. The result is <&gpd1 0 0 0 0> would actually map to
> GPIO 0 in gpd0.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Samsung people, please comment on this patch.

Yours,
Linus Walleij

  parent reply	other threads:[~2012-07-27 23:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 20:58 Sean Paul
2012-07-20 21:06 ` Doug Anderson
2012-07-30  8:04   ` 박상수
2012-07-30  8:37     ` Thomas Abraham
2012-07-27 23:09 ` Linus Walleij [this message]
2012-07-31 23:27   ` Kukjin Kim
2012-08-05  9:59 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZupvxyadxi8GppP6W2Pe5-eOcdjYYAcS28euUk8vx9iQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=dianders@chromium.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olofj@chromium.org \
    --cc=sangsu4u.park@samsung.com \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®