mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	David Cohen <david.a.cohen@intel.com>,
	"linux-gpio @ vger . kernel . org" <linux-gpio@vger.kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@intel.com>,
	Len Brown <lenb@kernel.org>,
	"linux-kernel @ vger . kernel . org"
	<linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Len Brown <len.brown@intel.com>
Subject: Re: [PATCH v2 2/3] gpiolib: append SFI helpers for GPIO API
Date: Tue, 26 Nov 2013 10:37:15 +0100	[thread overview]
Message-ID: <CACRpkdaO2oPoT0Vg7sLBoGfM-x3evaAW1rOtB4Wbggu5cbMQ_g@mail.gmail.com> (raw)
In-Reply-To: <1385051340.1871.2.camel@smile>

On Thu, Nov 21, 2013 at 5:29 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, 2013-11-21 at 12:40 +0200, Mika Westerberg wrote:
>> On Wed, Nov 20, 2013 at 04:31:35PM +0200, Andy Shevchenko wrote:

>> > +struct gpio_desc *sfi_get_gpiod_by_name(const char *name);
>>
>> I'm wondering should this function be exported at all? What the drivers
>> should be using is gpiod_get_xxx() APIs and not DT/ACPI/SFI specific
>> interfaces.
>
> I won't mix this with generic stuff since we have really few users of
> SFI and there should be no new users at all.
>
>> Yeah, we have the same in ACPI version but I'm planning to get rid of it
>> completely.
>
> I'm okay to move to this direction, if Linus and others are okay with
> it.

Go for it. Mika is right that we need to get rid of any custom calls
and this is the way ACPI is moving too...

Yours,
Linus Walleij

  reply	other threads:[~2013-11-26  9:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 14:31 [PATCH v2 0/3] sfi, intel_mid: introduce SFI GPIO API and use it Andy Shevchenko
2013-11-20 14:31 ` [PATCH v2 1/3] sfi: fix compiler warnings Andy Shevchenko
2013-11-20 14:31 ` [PATCH v2 2/3] gpiolib: append SFI helpers for GPIO API Andy Shevchenko
2013-11-21 10:40   ` Mika Westerberg
2013-11-21 16:29     ` Andy Shevchenko
2013-11-26  9:37       ` Linus Walleij [this message]
2013-11-20 14:31 ` [PATCH v2 3/3] intel_mid: switch to use SFI " Andy Shevchenko
2013-11-20 18:13   ` David Cohen
2013-11-26  9:38   ` Linus Walleij
2013-11-27 11:55     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdaO2oPoT0Vg7sLBoGfM-x3evaAW1rOtB4Wbggu5cbMQ_g@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=acourbot@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.a.cohen@intel.com \
    --cc=grant.likely@linaro.org \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®