From: Linus Walleij <linus.walleij@linaro.org>
To: Viresh Kumar <viresh.kumar@st.com>,
Christopher BLAIR <chris.blair@stericsson.com>
Cc: Linus WALLEIJ <linus.walleij@stericsson.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH v2] gpio/stmpe: support no-irq mode
Date: Thu, 26 Jan 2012 07:34:36 +0100 [thread overview]
Message-ID: <CACRpkdaRojO2P8FrVFygA16DazGdFj05eXqZjX7oJS2QT4qfZQ@mail.gmail.com> (raw)
In-Reply-To: <4F1FDAF9.90008@st.com>
On Wed, Jan 25, 2012 at 11:35 AM, Viresh Kumar <viresh.kumar@st.com> wrote:
> On 1/25/2012 3:23 PM, Linus WALLEIJ wrote:
>> + if (!stmpe->pdata->no_irq) {
>> + irq = platform_get_irq(pdev, 0);
>> + if (irq < 0)
>> + return irq;
>> + }
>
> I already acked it once, but there is another idea that i have :)
> Why not allow passing no irqs in resource fields directly.
>
> i.e. platform_get_irq() < 0 will automatically mean irqs are not supported
> on platform and then we can do what we are doing in your patch. This will
> remove need of another pdata field. :)
Hm sounds intuitively elegant! Chris, do you want to have a go
at it?
Yours,
Linus Walleij
prev parent reply other threads:[~2012-01-26 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 9:53 Linus Walleij
2012-01-25 10:35 ` Viresh Kumar
2012-01-26 6:34 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaRojO2P8FrVFygA16DazGdFj05eXqZjX7oJS2QT4qfZQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=chris.blair@stericsson.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®