From: Linus Walleij <linus.walleij@linaro.org>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Dev Null <devnull@uvos.xyz>, Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sre@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Doug Zobel <dougdev334@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: lp55xx: initialise output direction from dts
Date: Mon, 13 Dec 2021 00:59:18 +0100 [thread overview]
Message-ID: <CACRpkdaW6UeEo7SWac9ibWKSb6w_2KDcoJGGi5qztyPjD1y2xg@mail.gmail.com> (raw)
In-Reply-To: <20211212224007.10293-3-merlijn@wizzup.org>
On Sun, Dec 12, 2021 at 11:34 PM Merlijn Wajer <merlijn@wizzup.org> wrote:
> Commit a5d3d1adc95f ("leds: lp55xx: Initialize enable GPIO direction to
> output") attempts to fix this, but the fix did not work since at least
> for the Nokia N900 the value needs to be set to HIGH, per the device
> tree. So rather than hardcoding the value to a potentially invalid value
> for some devices, let's set direction in lp55xx_init_device.
>
> Fixes: a5d3d1adc95f ("leds: lp55xx: Initialize enable GPIO direction to output")
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> Fixes: ac219bf3c9bd ("leds: lp55xx: Convert to use GPIO descriptors")
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks for fixing my mistakes!
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-12-12 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 22:40 [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900 Merlijn Wajer
2021-12-12 22:40 ` [PATCH 1/2] ARM: dts: omap3-n900: Fix lp5523 for multi color Merlijn Wajer
2021-12-15 20:31 ` Pavel Machek
2021-12-16 11:50 ` Merlijn Wajer
2021-12-12 22:40 ` [PATCH 2/2] leds: lp55xx: initialise output direction from dts Merlijn Wajer
2021-12-12 23:59 ` Linus Walleij [this message]
2021-12-15 20:32 ` [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900 Pavel Machek
2021-12-16 11:51 ` Merlijn Wajer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaW6UeEo7SWac9ibWKSb6w_2KDcoJGGi5qztyPjD1y2xg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devnull@uvos.xyz \
--cc=dmurphy@ti.com \
--cc=dougdev334@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®