From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932147AbdERMnd (ORCPT ); Thu, 18 May 2017 08:43:33 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36062 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754764AbdERMn3 (ORCPT ); Thu, 18 May 2017 08:43:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170517140542.20016-1-linus.walleij@linaro.org> <20170517140542.20016-8-linus.walleij@linaro.org> From: Linus Walleij Date: Thu, 18 May 2017 14:43:27 +0200 Message-ID: Subject: Re: [PATCH 7/8] clocksource/drivers/fttmr010: Merge Moxa into FTTMR010 To: Joel Stanley Cc: Daniel Lezcano , Thomas Gleixner , Jonas Jensen , Janos Laube , Paulius Zaleckas , "linux-arm-kernel@lists.infradead.org" , Hans Ulli Kroll , Florian Fainelli , Linux Kernel Mailing List , Benjamin Herrenschmidt , Ryan Chen , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 9:22 AM, Joel Stanley wrote: > On Wed, May 17, 2017 at 10:05 PM, Linus Walleij > wrote: >> This merges the Moxa Art timer driver into the Faraday FTTMR010 >> driver and replaces all Kconfig symbols to use the Faraday >> driver instead. We are now so similar that the drivers can >> be merged by just adding a few lines to the Faraday timer. > > Nice work! > > I gave this a spin on hardware and it didn't work :( How typical. > Thanks for the rework! Unfortunately the Aspeed IP does not have bits > to control the direction of counting, and the timers only count down. > Bits 3, 7 and 11 are marked reserved in the data sheet. Can you rework > the patch to count down? How unintuitive. I guess I will just make it handle the Aspeed separately, so we count up on Gemini and Moxa and down on Aspeed if that is all it can do. > As an aside, we have a pretty decent model for the Aspeed SoCs in > Qemu. If you want to use it to smoketest your rework: > > $ qemu-system-arm -m 512 -M ast2500-evb -nodefaults -nographic > -serial stdio -kernel arch/arm/boot/zImage -dtb > arch/arm/boot/dts/aspeed-ast2500-evb.dtb > > I tested with Ubuntu's qemu v2.8. It looks like we have a bug when the > kernel tries to use the clock the way your driver works, so we will > look at that. It does function properly for the current upstream code. Oh that's sweet! I'll test it if I can get it working like this. Yours, Linus Walleij