From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752477AbcD3Lfd (ORCPT <rfc822;w@1wt.eu>);
	Sat, 30 Apr 2016 07:35:33 -0400
Received: from mail-oi0-f48.google.com ([209.85.218.48]:35357 "EHLO
	mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752418AbcD3Lfb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 30 Apr 2016 07:35:31 -0400
MIME-Version: 1.0
In-Reply-To: <20160427080835.GB22469@mwanda>
References: <20160427080835.GB22469@mwanda>
Date: Sat, 30 Apr 2016 13:35:30 +0200
Message-ID: <CACRpkdagyyeTTieGNNdT-O2pQAZBAnKtUkTBzAc_0Fdq_w-7aA@mail.gmail.com>
Subject: Re: [patch] pinctrl: baytrail: fix some error handling in debugfs
From: Linus Walleij <linus.walleij@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Cristina Ciocan <cristina.ciocan@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 27, 2016 at 10:08 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:

> We need to unlock before continuing.  Also the continue was accidentally
> left out on one error path which would lead to a NULL dereference.
>
> Fixes: 86e3ef812fe3 ('pinctrl: baytrail: Update gpio chip operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied with Mika's ACK.

Yours,
Linus Walleij