From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E1BCD80D5 for ; Tue, 10 Oct 2023 13:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbjJJNpP (ORCPT ); Tue, 10 Oct 2023 09:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232734AbjJJNol (ORCPT ); Tue, 10 Oct 2023 09:44:41 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7491170A for ; Tue, 10 Oct 2023 06:43:57 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5a7cc03dee5so4291637b3.3 for ; Tue, 10 Oct 2023 06:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696945437; x=1697550237; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NHv90yeM59s0sxqLXofNmRkQi512BP/YIHCc5n2XRV8=; b=CTyBwscDdXRHfa357oTE1VQHcc+sWJybRzF8l/lDUwTxVNEzcHhFmRPIN7iVX00q5e dL9Jv9oWpALsKF3Vy4wCinfh64MMftWPbosuSIXO5s8RW71Mt3gC/6G/YQQrbwJECQ2P +8+ezSPRw05/LCXXRoXz/3ghL+l0fg42OEBlXQeluuz76mznXEiapmeeAZFXdo/1GZr8 2Co7IJtOSlfAl1DwAfrWMaSmrGNXKUWGhvlA5Q5OPTfp2SqJlVIkgWjUdGPEGEI+/eZ4 U1veRiqf26prKpGFZ2KMqw16DqRp8K8dfl4WaPdUwIS8cc8/iXw05zYoNqD2xfnKqNjX Axcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696945437; x=1697550237; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHv90yeM59s0sxqLXofNmRkQi512BP/YIHCc5n2XRV8=; b=Z93l9x49EunSSz6NkAwgj/YBr6vnOqJzpXlJU0+q500AOXfld9XMcJF+ysPe5AR3rT byCDpeHv/NsQiJ07Y/McS/yMYp/ej75vvp5JB9uZNCvLskuSiQMyD/cyrkdyOijn57+J 1sGrC+rKkZW5xO2Citj0QqNf6790PCgDicrvADtVpue6PvhFJh9qxL0SrxqJZ0XGWn7i 4m3W8pceTZpzzD82tRutGHh2U2bSwo3illEFGpYGBHvmsHHqft7yynGRagjvFTPeTq0m FTCoCJh+mEhpCRdeog+9l3NFMIwfBZsjfZfzq+0rhbrUOAo/7+t2b8NvPG5BkjFeEFMw LqSg== X-Gm-Message-State: AOJu0YwZMAFbJQoAehsaSphVWG2mj3F4ogA5thfLAjoSMQ5/sbhwKT62 vgD6mnay2bNIqiL+sx0lxmM7o1z9dQ1bd5Idj9gsZzdiljdQG/x/Sbk= X-Google-Smtp-Source: AGHT+IFe14EexLrkBZfWNsifbauHwwB0K/+Kizwq9byU1Yt/kNve+L3d4GQbubrht+pN7n07ezMuTgwFSCYBnOdSWxU= X-Received: by 2002:a81:83c6:0:b0:5a7:b96e:9693 with SMTP id t189-20020a8183c6000000b005a7b96e9693mr2720838ywf.31.1696945436630; Tue, 10 Oct 2023 06:43:56 -0700 (PDT) MIME-Version: 1.0 References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> <20231009083856.222030-18-u.kleine-koenig@pengutronix.de> In-Reply-To: <20231009083856.222030-18-u.kleine-koenig@pengutronix.de> From: Linus Walleij Date: Tue, 10 Oct 2023 15:43:45 +0200 Message-ID: Subject: Re: [PATCH 17/20] pinctrl: qcom: ssbi-gpio: Convert to platform remove callback returning void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 9, 2023 at 11:22=E2=80=AFAM Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Patch applied. Yours, Linus Walleij