From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753848AbeBGM5I (ORCPT ); Wed, 7 Feb 2018 07:57:08 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:47026 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753695AbeBGM5H (ORCPT ); Wed, 7 Feb 2018 07:57:07 -0500 X-Google-Smtp-Source: AH8x227Rhoxx2f6zqbx6sICqcWSsjruc6TegYGlI65hKMgpthCDjlxlgkzx+eOxI8Hbjx9msTEqHfnIDBiESFRk9mLk= MIME-Version: 1.0 In-Reply-To: <1516566774-1786-1-git-send-email-david@lechnology.com> References: <1516566774-1786-1-git-send-email-david@lechnology.com> From: Linus Walleij Date: Wed, 7 Feb 2018 13:57:04 +0100 Message-ID: Subject: Re: [PATCH] gpiolib: suppress error message on EPROBE_DEFER To: David Lechner Cc: linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 21, 2018 at 9:32 PM, David Lechner wrote: > This suppresses printing an error message during probe of gpio drivers > when the error is EPROBE_DEFER. > > Cc: Linus Walleij > Signed-off-by: David Lechner I'm not sure about this. GPIO can be very basic system components. If we don't print this, defer a few times (for some reason) and then the kernel gives up on retrying, silently (as it happens) there is no trace in dmesg of what happened. That makes things hard to debug. This happened to me with some other driver, so it is not a made up example. What about an explicit deferral message for now? Yours, Linus Walleij