From: Linus Walleij <linus.walleij@linaro.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Russell King <linux@armlinux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH 5/6] tty: serial: amba-pl011: unindent pl011_console_get_options function body
Date: Thu, 26 Oct 2023 15:46:58 +0200 [thread overview]
Message-ID: <CACRpkdbLqB29gMHYU2sT=3VD6XuOeaFSAdO2=qDS+=KCBi0jPA@mail.gmail.com> (raw)
In-Reply-To: <20231026-mbly-uart-v1-5-9258eea297d3@bootlin.com>
On Thu, Oct 26, 2023 at 12:41 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:
> The whole function body is encapsulated inside an if-condition. Reverse
> the if logic and early return to remove one indentation level.
>
> Also turn two nested ifs into a single one at the end of the function.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-10-26 13:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 10:41 [PATCH 0/6] Cleanup AMBA PL011 driver Théo Lebrun
2023-10-26 10:41 ` [PATCH 1/6] tty: serial: amba: cleanup whitespace Théo Lebrun
2023-10-26 12:05 ` Linus Walleij
2023-10-26 10:41 ` [PATCH 2/6] tty: serial: amba: Use BIT() macro for constant declarations Théo Lebrun
2023-10-26 13:37 ` Linus Walleij
2023-10-26 14:14 ` Théo Lebrun
2023-10-26 10:41 ` [PATCH 3/6] tty: serial: amba-pl011: cleanup driver Théo Lebrun
2023-10-26 13:38 ` Linus Walleij
2023-10-26 10:41 ` [PATCH 4/6] tty: serial: amba-pl011: replace TIOCMBIT macros by static functions Théo Lebrun
2023-10-26 13:46 ` Linus Walleij
2023-10-26 14:24 ` Hugo Villeneuve
2023-10-26 14:37 ` Théo Lebrun
2023-10-26 10:41 ` [PATCH 5/6] tty: serial: amba-pl011: unindent pl011_console_get_options function body Théo Lebrun
2023-10-26 13:46 ` Linus Walleij [this message]
2023-10-26 10:41 ` [PATCH 6/6] tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options Théo Lebrun
2023-10-26 11:13 ` Ilpo Järvinen
2023-10-26 12:54 ` Théo Lebrun
2023-10-26 13:48 ` Linus Walleij
2023-10-26 14:18 ` Théo Lebrun
2023-10-26 14:53 ` Hugo Villeneuve
2023-10-31 9:35 ` Théo Lebrun
2023-10-31 10:11 ` Russell King (Oracle)
2023-10-31 11:04 ` Théo Lebrun
2023-10-31 11:22 ` Russell King (Oracle)
2023-10-31 13:51 ` Théo Lebrun
2023-10-31 14:05 ` Russell King (Oracle)
2023-10-31 14:30 ` Théo Lebrun
2023-10-31 13:39 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbLqB29gMHYU2sT=3VD6XuOeaFSAdO2=qDS+=KCBi0jPA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®