From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939887AbdAIScg (ORCPT ); Mon, 9 Jan 2017 13:32:36 -0500 Received: from mail-qt0-f173.google.com ([209.85.216.173]:35118 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbdAIScb (ORCPT ); Mon, 9 Jan 2017 13:32:31 -0500 MIME-Version: 1.0 In-Reply-To: References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> From: Linus Walleij Date: Mon, 9 Jan 2017 19:31:42 +0100 Message-ID: Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() To: SF Markus Elfring , Chunyan Zhang Cc: "linux-mmc@vger.kernel.org" , Adrian Hunter , Harjani Ritesh , Jens Axboe , Mike Christie , Shawn Lin , Ulf Hansson , Wolfram Sang , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 18:44:26 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring Chunyan has been running this test code so she might have additional insights to provide. I am not aware about anyone else really running the tests, are there people who do it? Reviewed-by: Linus Walleij Yours, Linus Walleij