From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbbJ0Qma (ORCPT ); Tue, 27 Oct 2015 12:42:30 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:36784 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754358AbbJ0Qm2 (ORCPT ); Tue, 27 Oct 2015 12:42:28 -0400 MIME-Version: 1.0 In-Reply-To: <20151027142343.GI1548@lahna.fi.intel.com> References: <20151019165914.GA22867@sophia> <20151027142343.GI1548@lahna.fi.intel.com> Date: Tue, 27 Oct 2015 17:42:23 +0100 Message-ID: Subject: Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16 From: Linus Walleij To: Mika Westerberg Cc: William Breathitt Gray , Andreas Bofjall , Simon Guinot , =?UTF-8?Q?Diego_Elio_Petten=C3=B2?= , Daniel Krueger , Bruno Randolf , Vivien Didelot , Alexandre Courbot , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 3:23 PM, Mika Westerberg wrote: > On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: >> > +menu "ISA GPIO drivers" >> > + >> > +config GPIO_104_IDIO_16 >> > + tristate "ACCES 104-IDIO-16 GPIO support" >> > + depends on X86 >> > + help >> > + Enables GPIO support for the ACCES 104-IDIO-16 family. >> > + >> > +endmenu >> >> I have five other drivers using port-based I/O: >> >> gpio-f7188x.c >> gpio-it87.c >> gpio-sch.c >> gpio-sch311x.c >> gpio-ts5500.c >> >> Do you think it makes sense to move all of these in under >> the "ISA GPIO drivers" menu as well? I guess they all require >> ISA after all. >> >> (Added their maintainers to the To: line so I can get some input >> on this.) > > Not all of them actually require ISA. For example gpio-sch is part of an > MFD device which is a PCI device. PCI bus also has notion of I/O ports. Hm, is there a more fitting symbol we should sort it under, which means thingofabob-that-has-portmapped I/O? Yours, Linus Walleij