From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9359330DD36 for ; Fri, 23 Jan 2026 15:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.167.42 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769180949; cv=pass; b=GW1dcN4CWqj+d6nmxMFb2JJNRCNjfn7A+xxUQc4Ug9Ybey+hXG4nwPcBP2WaPRaO6fmo5gm1vBxhBrsg1C/lKucRmg+oyQ9WqTeaSyq+SNyAoi13chcje4l8hl2R8MAd801mBI4x0zRThkRabwp6UoPb/kIBf9dXkDpWeee8/a4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769180949; c=relaxed/simple; bh=maYxuNd0JD/bXR4V12BARXKUWnmKMhaShzx3Z+hIg/I=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=GIeGJ00Cy6vRw/2A8vikD9szW94PfgTu9upmFCf5K8TvtYobfhiV7dqKRrLwMowHFABHsv/C09XzGmq6MSa8hoCpfDH7H9EdBjfQPdDbfeIJ3zcwXC0sMVKmFKbrCpE9bVSwsJOg0Q9sn4+P5hpIpTZOlyNNTyn86nLlMkfyRO4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MCS3Bfm2; arc=pass smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MCS3Bfm2" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-59dd54b1073so2440171e87.0 for ; Fri, 23 Jan 2026 07:09:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769180944; cv=none; d=google.com; s=arc-20240605; b=ExQclu+Xf1i83qM/nPz51t+fsDs3mGjtKmxsqq0TI64iAARHhXWDvlZFW2q2T/ogYx xR3iY12F24GFfdYDYUV+/KdaKpGi5RAvDpDLkxNlDMuBnPRNZY5/zW4tasMbDybZRkkP 5Slh7x0KILLOhPpM5DwidqBraOkicM1NZskoV5OyLb/XIIC5xpwvnRgca0FK0Nz5mw3O rsziWzPB9MNMy0EDyNg7LDQBZZliOOdnSXf1JkITyDJCEPelyLVarahx/ayW7Btd8UdQ 9rvtUHqjR9Re6a0BlCG2AcFfQJBMVFdwmlWI9FtWlg8DM8SlIbw4KJz6iN+MTjaSkzFE n7RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hTPFJHsp7+e3p+AgGMM8NKUKVszz8QkOczw1QOR6pB4=; fh=d/PGEvP67s95k6Rl/hIFqrYPEEkOOG1nMiNnAeCfgH4=; b=Zj65sMyCiKs5tZITTsxt9Bn+PBByaGZ4oWE64abdC2Df/ijpVjbT9XQL+U1koc8xTm 7Ep8ftAaLiQP0Zqym3vjUL6pTxEgAT2Iqqk8fV5rujNvnBmElJytUhqu32EBJStseOVz euoDtO03ghyu1n9xv12hYL07mo8j3tbxiErPCXiXyjdLNPxveGWQsXlXnAR8WvDhHF63 VsJjrbP1XCOhe3T78VgeQAuCPzFy1rizX9VIlvyqI1TgfOXECPYLOGs8+B09qFvtbN17 p1VGa4vUR5s00kC0UIhK5SVzyX8CFj+LqwebmJXK8hqScbJHHlBEN4iuq5Qrgz/oLi5z z/Fw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769180944; x=1769785744; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hTPFJHsp7+e3p+AgGMM8NKUKVszz8QkOczw1QOR6pB4=; b=MCS3Bfm2TkUfqZi/maxLzx4DHFPYE6LZ/1nOGIx0p5SL0FkfVjnKUs18PUdZRESjcw C5bsxGywYaJmlSFpsKPDOZjehya+JH2IbUSQOZLrkvHymWXUh19YC/MINtpA/C5qHOJ4 dTi3GDcMXuO2uDmojm+14ajwQqMT5pn4/OShlnYZ9IdablXatLng6B3m5XqV2YYtSHaa 5bg5dAui4dtKXbHYw6m02EaOD/cCJd3SVPLDC8kotPzJ7Vjzv/ZIgxDLMTIuXjTa1wnW XygjzZELU6+NMZMw2yCQRjUINZfLfKuFIhh0GWv4Z3VoGfL5enMaF4ug8EuGLheZ4ldj yeCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769180944; x=1769785744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hTPFJHsp7+e3p+AgGMM8NKUKVszz8QkOczw1QOR6pB4=; b=r4N8B5d2WkNptm7pMqH013Rp3AFoVuf15v2LT83xyd7Ovp4egVuuTm8hTlUJzN5ASq ySbKptr/zV6r7r0lHH9h9xdfw1equJTZXHaelGMlLwCZYbRClZ225xDqs/4a/QEHGn8m klxBhq8VG6p6jSwS2ahua97J4kY2zwTx0R+EMWnlwDObJI/rATOh1/sxLVdzsmDyLjoq 8JuAsHSgUXMhtnaWyJzN7Tf0doTvt7hHhaXrY/J985Qa7KiPRVNDLqP7gOG83+GSMwgE i0PRY81f9vApNn9tdvtLMrKi2KFJmFVHsp8uCW77f0ZCshc1D0u99UTCBCsv8ARjn5bV 9/6w== X-Forwarded-Encrypted: i=1; AJvYcCXGCzGyWqxM6U7flP1mkJ6oOgacsv7yfODapyLHgLiFcjMopJnVn5YRuA6adZbIpwWKWIbU57yylgnySiA=@vger.kernel.org X-Gm-Message-State: AOJu0YyKGCUR4pEzZ2G9U1gGW12uRddZJ+yxaKLOr9QmNNG9fL5TArUg QHIassIvw2TAqK1JcgZsrOJZiIwY9R7LC42eh8cPR6gkRs3zgHeBgqpe1BXc2OrDc3KVMBHAMto Y61dR5aXYm9mzH2psV4L7SDzboq5qX3E= X-Gm-Gg: AZuq6aKimgF7E9csHpfc7DbcfADK3m07xR+kDNUOCJ1nT2cQpDgHXc09xFeRvGe0TSK bZyJuGjTP4zUxFdGKArskRfcc+a/vw6+bjCNk06g7oWPYiNHqsvHBYKS/FH4nkK9H1IJsnBXMGG yms0B9CGpdOXw9km0K8XlsNHUo4tmm6AkFxwYRI81eZlbWKbuGz3CS8EfDxaLTR1t8OCCWnltYj dDeHVs5tDUEL0Qsxbclzi/5UrJWa+EQrqbvD4AGeJhMOu38Q1b/ah1YGTMQNZMvkNqqm4Y= X-Received: by 2002:a05:6512:2513:b0:59b:9fee:2602 with SMTP id 2adb3069b0e04-59de49130bamr1104247e87.19.1769180943292; Fri, 23 Jan 2026 07:09:03 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260123082232.16413-1-vernon2gm@gmail.com> <20260123082232.16413-5-vernon2gm@gmail.com> <5820b1e9-3c45-432c-84aa-638cf92fd240@linux.dev> In-Reply-To: <5820b1e9-3c45-432c-84aa-638cf92fd240@linux.dev> From: Vernon Yang Date: Fri, 23 Jan 2026 23:08:51 +0800 X-Gm-Features: AZwV_QhS1nxlj2EnvC6I8sFHl5Yi8lcT62VM-jATdm2GqT5TT7YIjjiTEulfQKc Message-ID: Subject: Re: [PATCH mm-new v5 4/5] mm: khugepaged: skip lazy-free folios To: Lance Yang Cc: lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@kernel.org, Vernon Yang , akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 23, 2026 at 5:09=E2=80=AFPM Lance Yang w= rote: > > On 2026/1/23 16:22, Vernon Yang wrote: > > From: Vernon Yang > > > > For example, create three task: hot1 -> cold -> hot2. After all three > > task are created, each allocate memory 128MB. the hot1/hot2 task > > continuously access 128 MB memory, while the cold task only accesses > > its memory briefly andthen call madvise(MADV_FREE). However, khugepaged > > still prioritizes scanning the cold task and only scans the hot2 task > > after completing the scan of the cold task. > > > > And if we collapse with a lazyfree page, that content will never be non= e > > and the deferred shrinker cannot reclaim them. > > > > So if the user has explicitly informed us via MADV_FREE that this memor= y > > will be freed, it is appropriate for khugepaged to skip it only, thereb= y > > avoiding unnecessary scan and collapse operations to reducing CPU > > wastage. > > > > Here are the performance test results: > > (Throughput bigger is better, other smaller is better) > > > > Testing on x86_64 machine: > > > > | task hot2 | without patch | with patch | delta | > > |---------------------|---------------|---------------|---------| > > | total accesses time | 3.14 sec | 2.93 sec | -6.69% | > > | cycles per access | 4.96 | 2.21 | -55.44% | > > | Throughput | 104.38 M/sec | 111.89 M/sec | +7.19% | > > | dTLB-load-misses | 284814532 | 69597236 | -75.56% | > > > > Testing on qemu-system-x86_64 -enable-kvm: > > > > | task hot2 | without patch | with patch | delta | > > |---------------------|---------------|---------------|---------| > > | total accesses time | 3.35 sec | 2.96 sec | -11.64% | > > | cycles per access | 7.29 | 2.07 | -71.60% | > > | Throughput | 97.67 M/sec | 110.77 M/sec | +13.41% | > > | dTLB-load-misses | 241600871 | 3216108 | -98.67% | > > > > Signed-off-by: Vernon Yang > > --- > > include/trace/events/huge_memory.h | 1 + > > mm/khugepaged.c | 11 +++++++++++ > > 2 files changed, 12 insertions(+) > > > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/= huge_memory.h > > index 384e29f6bef0..bcdc57eea270 100644 > > --- a/include/trace/events/huge_memory.h > > +++ b/include/trace/events/huge_memory.h > > @@ -25,6 +25,7 @@ > > EM( SCAN_PAGE_LRU, "page_not_in_lru") \ > > EM( SCAN_PAGE_LOCK, "page_locked") \ > > EM( SCAN_PAGE_ANON, "page_not_anon") \ > > + EM( SCAN_PAGE_LAZYFREE, "page_lazyfree") \ > > EM( SCAN_PAGE_COMPOUND, "page_compound") \ > > EM( SCAN_ANY_PROCESS, "no_process_for_page") \ > > EM( SCAN_VMA_NULL, "vma_null") \ > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index de95029e3763..be1c09842ea2 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -46,6 +46,7 @@ enum scan_result { > > SCAN_PAGE_LRU, > > SCAN_PAGE_LOCK, > > SCAN_PAGE_ANON, > > + SCAN_PAGE_LAZYFREE, > > SCAN_PAGE_COMPOUND, > > SCAN_ANY_PROCESS, > > SCAN_VMA_NULL, > > @@ -583,6 +584,11 @@ static enum scan_result __collapse_huge_page_isola= te(struct vm_area_struct *vma, > > folio =3D page_folio(page); > > VM_BUG_ON_FOLIO(!folio_test_anon(folio), folio); > > > > + if (!pte_dirty(pteval) && folio_test_lazyfree(folio)) { > > I'm wondering if we need "cc->is_khugepaged &&" as well here? > > We should allow users to enforce collapse via the madvise_collapse() > path even if pages are marked lazyfree, IMHO. $ man madvise MADV_COLLAPSE Perform a best-effort synchronous collapse of the native pages mapped by the memory range into Transparent Huge Pages (THPs). The semantics of MADV_COLLAPSE are best-effort and do not imply to enforce collapsing, so we don't need "cc->is_khugepaged" here. We can imagine that if a user simultaneously uses MADV_FREE and MADV_COLLAPSE, it indicates a misunderstanding of their semantics. As the kernel, we need to safeguard the baseline. > > + result =3D SCAN_PAGE_LAZYFREE; > > + goto out; > > + } > > + > > /* See hpage_collapse_scan_pmd(). */ > > if (folio_maybe_mapped_shared(folio)) { > > ++shared; > > @@ -1330,6 +1336,11 @@ static enum scan_result hpage_collapse_scan_pmd(= struct mm_struct *mm, > > } > > folio =3D page_folio(page); > > > > + if (!pte_dirty(pteval) && folio_test_lazyfree(folio)) { > > Ditto. > > > + result =3D SCAN_PAGE_LAZYFREE; > > + goto out_unmap; > > + } > > + > > if (!folio_test_anon(folio)) { > > result =3D SCAN_PAGE_ANON; > > goto out_unmap; >