From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1502326F476 for ; Mon, 3 Nov 2025 23:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762214323; cv=none; b=Tmu00ASJRi7htAcANmka2kqRN+pyjvovnXLXHNMzRiMgo1/y4JORJU7NVAjyBADnh7qhbHTktc6GxOT+YZVlx3eLVIHgXcHR3k6Bn8O+Ao9LF42/laWQ3hjdhXVE+JlGWOF+5JrGEyDvgSOVtjd7EyCL51ANGPAi5boxauzru9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762214323; c=relaxed/simple; bh=+GjPBbS4tzsC0uAErgpZoYbDYAoVZCtoNhVMyqS5aak=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fYBsAkRACZvMLcT2Fy0VEX/+g7gPtfIA4ELR12yzvksHkAnNRxeStp9768Bd1M83YNrn+S3PpLrRdlVlY950pXr54BxFbpHzsBH7xmvvHhehdaZJ1Ry05clFF1rsDTYeNrn1l8b6Stoy1Mx0RE40TitHQSkO2vO+j9q/uiC7BD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QVEsPW/j; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QVEsPW/j" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-295c64cb951so93645ad.0 for ; Mon, 03 Nov 2025 15:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762214321; x=1762819121; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UiaumAf9uKaq/47KUh0x3Zq3WXVBAjDWrX0gtHKtIa0=; b=QVEsPW/jD/HZgfftOEifqiw5dvFekHCVoADUXunIIMxI9umfm3yHkT4hKw3qZeQqUN UNTIFYDGE/amfzXM06cR7QWGGIIcwqsWQ1szWPdUlKW8wJCtYMRyzUbtAN1iIaOcdXdy Rv8Ghrxeo8ftSL/5tMAosiYzL7G+zL0SMNuYdGC3dlzQn/hdO4hj753g+u656QqtW7yI 88t9CpLjJZyikwbPPHXokowV7Dm/jBQucMCKOcnTBEUiAHEAKiMtj1r5TytMqSv96cum IDNWlXpOhIzQEnZ/NoQ+n5gk6ZGBC8QqqBzP3xYM1n98AN9nrpvBcU/hSkvIE6f5NaIZ rRTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762214321; x=1762819121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UiaumAf9uKaq/47KUh0x3Zq3WXVBAjDWrX0gtHKtIa0=; b=QOxBUUUyZSDupDotSdhr0BgkmkYnRZFLYrLzKm9Twm2ui2ljjL5AK9A/Cw+JFOV4ZI KEWD6B1hp1hasoXKEuzVWgELaAMwzPy9FR64owM52lO/mDenlGHkhZg5+qzW1Ah9/d+V Dv89bNkkjoSeKGxNz1z1tYj8cV9n32B559QhhDG4rR4+sigVXXJUVNk/gTpq8ax9wel3 MlpFkA6c18difOa5eRcwts/obvTH906x0JxLKPa7J97XiJ8rMS5Y4g5zWqWwyWqcyPFS p+5sd3HQo5WmglLoTGtUJlXz7xPyoVxfJe2akUdEcUPQDJMRdu2Dx2opNTlZX5h8b/hz 9cBQ== X-Forwarded-Encrypted: i=1; AJvYcCVf27cpjkxWMK3QEvk/nmN/9gixnxZpL0cub8p6Y7SOTQls3LHRzljBrKIkZRVwsj75FJGy0/NT7XNjpTU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxbef4opa+dUWl5L4Jt+kKyZQ8XzwFqk1yFWDw6Ab5ak9bN4Fo tEJ+qsumlNLTVAU4g5pFXC7Jks2D+YcF7xMDTmjNBfoLm5P6zhaowaxIs8BVWIrDhoIZ8KRpimC pmGP5cR+niFT00lYND06UfdpEnV+U2EXTq0kUHV5f X-Gm-Gg: ASbGncvSajoFnrQGpmLTSUqJo778x0tyMys9KU3jfc8M+9L4WdG0U9lyNsOotzVdVgP rKZjLvfL0PTsWAhN8sx//FiCX/UbNgtKeLI0IiKoeYcK3/DwklOBwMIiXV4XjbUlOQZm6H1C5iA ey8yDNDnYbm0D84COdWXBDwQgBqNdPtLXhXwjim+ioLp4AZfRCqaFshuk+OAkyCYvprJyTO/ORl CZ+e2WZTGfGNSLOWjD4ww4KYMAp0nmuyyz/MJptnsAvTCLJrBYCx+s7kB+xSStgEKzdtGvtBkfI 9NjKMYB873ztYMtH4rNUDBBhlTw= X-Google-Smtp-Source: AGHT+IHt6j/O2+BVT8RrxCXQhlHMInI33IDskTKx+bVIyN+3SBdebf/1pf/skkswodcwqLLeaarZnJrY3sFQZRZnnO4= X-Received: by 2002:a17:902:ec81:b0:290:d7fd:6297 with SMTP id d9443c01a7336-295fd265e91mr2024145ad.2.1762214320623; Mon, 03 Nov 2025 15:58:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251028212528.681081-1-kaleshsingh@google.com> <20251028212528.681081-3-kaleshsingh@google.com> <6c34ce4e-1212-4dd0-8b7c-6af952dda3cb@kernel.org> In-Reply-To: <6c34ce4e-1212-4dd0-8b7c-6af952dda3cb@kernel.org> From: Kalesh Singh Date: Mon, 3 Nov 2025 15:58:28 -0800 X-Gm-Features: AWmQ_blqxq78jLq4HTBbisYrdSqGuPCxohmpOKASM-NgBeXlVoTSRESehr_wOXs Message-ID: Subject: Re: [PATCH v4 2/5] mm/selftests: add max_vma_count tests To: "David Hildenbrand (Red Hat)" Cc: akpm@linux-foundation.org, minchan@kernel.org, lorenzo.stoakes@oracle.com, david@redhat.com, Liam.Howlett@oracle.com, rppt@kernel.org, pfalcato@suse.de, rostedt@goodmis.org, hughd@google.com, kernel-team@android.com, android-mm@google.com, Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Jann Horn , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 3, 2025 at 9:13=E2=80=AFAM David Hildenbrand (Red Hat) wrote: > > On 28.10.25 22:24, Kalesh Singh wrote: > > Add a new selftest to verify that the max VMA count limit is correctly > > enforced. > > > > This test suite checks that various VMA operations (mmap, mprotect, > > munmap, mremap) succeed or fail as expected when the number of VMAs is > > close to the sysctl_max_map_count limit. > > > > The test works by first creating a large number of VMAs to bring the > > process close to the limit, and then performing various operations that > > may or may not create new VMAs. The test then verifies that the > > operations that would exceed the limit fail, and that the operations > > that do not exceed the limit succeed. > > > > NOTE: munmap is special as it's allowed to temporarily exceed the limit > > by one for splits as this will decrease back to the limit once the unma= p > > succeeds. > > > > Cc: Andrew Morton > > Cc: David Hildenbrand > > Cc: "Liam R. Howlett" > > Cc: Lorenzo Stoakes > > Cc: Mike Rapoport > > Cc: Minchan Kim > > Cc: Pedro Falcato > > Signed-off-by: Kalesh Singh > > --- > > [...] > > No capacity to review the tests in detail :( Appreciate you taking a look :) > > > + > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/= selftests/mm/run_vmtests.sh > > index d9173f2312b7..a85db61e6a92 100755 > > --- a/tools/testing/selftests/mm/run_vmtests.sh > > +++ b/tools/testing/selftests/mm/run_vmtests.sh > > @@ -49,6 +49,8 @@ separated by spaces: > > test madvise(2) MADV_GUARD_INSTALL and MADV_GUARD_REMOVE options > > - madv_populate > > test memadvise(2) MADV_POPULATE_{READ,WRITE} options > > +- max_vma_count > > + tests for max vma_count > > - memfd_secret > > test memfd_secret(2) > > - process_mrelease > > @@ -426,6 +428,9 @@ fi # VADDR64 > > # vmalloc stability smoke test > > CATEGORY=3D"vmalloc" run_test bash ./test_vmalloc.sh smoke > > > > +# test operations against max vma count limit > > +CATEGORY=3D"max_vma_count" run_test ./max_vma_count_tests > > I'd just call it CATEGORY=3D"vma" or "vma_handling". > > Which makes me wodnering whether "vma_merge" falls into the same category= . > > Smalls like mremap test is similar. > > Point is that "CATEGORY" stops being really useful if we end up having a > separate category for each test, right? :) I agree making both use a "vma" category seem more helpful. I'll wait for others' feedback before resending. Thanks, Kalesh > > -- > Cheers > > David