From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7B93C9ED9 for ; Fri, 24 Jul 2026 12:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.219.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784897055; cv=pass; b=WH5LgKUTnWOK0d5zJc7Xf00lx2unQh1F8FO0A+hyf+GpIpP48OV3k0OzGFH74fLJaOAiEgXuz5ehVTIi4dnCj8YEMyck/8JPc+zkURhvfG+/gA5RBl2Q/dUT4skzBrUZAEgtvZWUruzjToiOnIZByH/46Ha008aEtlh67QYS31s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784897055; c=relaxed/simple; bh=E5JHc8HLuoo7DhyKVoM/oTbX8SZtTMnPKN+K2+UHJEY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rULb6eck0dJuWs/jB+Dhn866tHwQvX3p7p94J7EhRpJ8kvBu3fRAti/qw+RxRZ4EuGH0G44vAgpBayd29Y3933iQtpo5yILYwTenDeKIxNZb/jRoFRgEfm3ZRRkfzgVCLCpg3/AhP91w1/wHAwsfiH/uRpxMwM14b4dKSxuCp2k= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gr44gRZ2; arc=pass smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gr44gRZ2" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-8ff5d1b0f91so2880076d6.2 for ; Fri, 24 Jul 2026 05:44:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784897053; cv=none; d=google.com; s=arc-20260327; b=SJ8twg+gnux84bdRbW0vNOUlNwu+2fT+bfb/u74H1cZonb/2mhxjLT9hnkFEAPbHFw 39f6l9zIixmRPjTYLQ3qCMtiDhFsmsYAG2YQ9Wm7zaDoHbOGwm8UfV+gFfcOlb9aa1AM qux7/MVzH1ltQTZxk6vL+ICO2z7x2xT90m2HAyDE/pUXjX/Xo8xdWdNHGUahQUZpMal4 TIuFc9X29O6nazQh+HJUaU9NboT0nGbU9Y+8id0QaE7KPYZm0LJ059ooc4+uPmkpYf2t 1+lEXeyxMSl5EYrwc/kPBYXcSmacVU8qmZBiOFIZAOtnHPJpqC5sLmPemi8MF89eHQha Wpjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=aC2psv7ALiBxeuXZI5bTG7C7BxKxDQncU75RPTVHyag=; fh=V87mgebzbkFdguidBW2jEN7tW8AEapbq9rlOVJNXm84=; b=n6SMZ08N/y8RGNXceN46UswQ78zm7GzKXFjXAy43oE7nt9sTjVZvP8Vk7IjUBaVoBP QuadMSsFoxoJBddFFklgqvobC5HGs9akVc6N0aR7YRMwh2wtLSlEEWtDgTq2W/mTXtdE b6PkLT9dQvjsIS2umoQ+8gDiQ8F1UzbOdj/ALZVGwNRtwXnpV5xGymoyv72nVq2uA3Og EXxd7T+DjUhhAY+4iNdI9wIUWXPEV5kEJTI4E2C+tHktM/QJMsk8HJaISKxDZ4BlCMtv qsSo+a6T20sosJhaiVqgXZBT0BMjYXTI8Je+Spzo//EFLkAkTXZLgGcZCj/9N8fLDLhS sF/w==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784897053; x=1785501853; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aC2psv7ALiBxeuXZI5bTG7C7BxKxDQncU75RPTVHyag=; b=gr44gRZ2OGBFeO6t1eNpYReLN5M4U5Xw1uc3O7siESuKX3HeLHUI0bqL+XU5wsY4Yx T6xk3BtvWHZUrqRFkrsfhawqzh3cI+gaOlzgI5pNRYA7AtG5DGsIv1nlBuLoCE3HL9KS QJsWoE7A1wbKhvrEaU7bm0sKttZ9cMl88tGiNcLRxqzTgO268rT3G6TpKruVgqbv9P2A QoSwY7UUaQGZLKmUCsImWEnSRU5CX1SS6PuDG+ATdgh1hsAjbVsxFXNw2944erxif/HL DgyM1xoUhIJkG7gzexSIe9kPS9o/lNfxml0aREmDI319oxmPgiGaD3RWEzCflJ8N2yyw wvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784897053; x=1785501853; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=aC2psv7ALiBxeuXZI5bTG7C7BxKxDQncU75RPTVHyag=; b=HubLC2VAOo8fOT8nX0em9c94DKTtTLilP+6vPOXJmggl58kfh8ba1jiRAd4VYQz1SG JOzL57pD0Txdu6PGOi97BI+79qoiOgiUocqxfH4mNAykfavP8oytkXfd+x7BmwW0w6kJ eHq9h4Imej1bHUOQZn39wIo8E1PYXmuC0S7udZOVCILD/VBpeqO8WiiiwajDI8/biQVm ycWEkqrbigQOPaw49ZavROj/QaQfWW8B0bISHZfjr3M3ul+cj7Zf7YFzTxDyS3zM2+Br Tg1NNvW0dVQlDav3p+ReiyR6AUp5YT2uwOuzrGBhQ3y4YZ4iNpnGD5X4k+j5udtPkwMW A2QA== X-Forwarded-Encrypted: i=1; AHgh+Rrh4c2p43/sG5R45sZ3hCUScaYSQW3ZHVBoqEV//E3LYqbletco/5lcU4mqSHJbaaB+LnGyEBHaQ34a76w=@vger.kernel.org X-Gm-Message-State: AOJu0YyTnOWaSFNt7/xuvgcmtKegAd9G4Rcsw+QYjdda5Dkayz4/mQg5 PmhIQpW9WBNVJmY8dNyTcFCOrB5CKx1ztPm2h0S600PxGuawyqqAllzeqkv5crlchGyPf/5YRSu xSLHYVuf7HhuP8X4NofJUIE1PKJ9c8zsgEtkg X-Gm-Gg: AR+sD12gKy0oL/PNUFfNTJzTiiGWFNuuq3vUwgLfdRkqYLhou4VWFBXYnzzqR5fn+7z 6X9YuMabyV+HRm7HMTpYBHF/wchfDCYfeF6pXB5I0EIpxiyIb0bCMreWXXLHhjokdisqq5gOu0n w69iyuV5drKQzGTYzJMjYdhTat9SP15n8y7el0fBb6TbT2m+qH7Ndp9Zq3oa9Z7VYY/JzIyLVPO eaH2HWyqwdsKvUk5qwBbigis4B5aYIDb/vyEUEinhJNgXO429CI3v5pC8TU0GG7uiYi3fXSJGY6 +Mo0iEwvSrjuuyR8U7vfSYGQI6T6Ky8j0IH9NG3kv9vgry7zkbPk X-Received: by 2002:a05:620a:6cca:b0:92e:cac7:96fc with SMTP id af79cd13be357-9310388efd2mr749905085a.24.1784897052712; Fri, 24 Jul 2026 05:44:12 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260724111548.2109-1-tharitt97@gmail.com> <193a0d2b4f7c33163cb6aee56ceee0bf5cb6c11c.camel@pengutronix.de> In-Reply-To: <193a0d2b4f7c33163cb6aee56ceee0bf5cb6c11c.camel@pengutronix.de> From: Tharit Tangkijwanichakul Date: Fri, 24 Jul 2026 19:44:00 +0700 X-Gm-Features: AUfX_mxLzK4lEzDdIm63lfvgUd6SAd7_Ys3EmQdE2d3UhBcu1j4jPRBGqdfCOww Message-ID: Subject: Re: [PATCH] media: hantro: release runtime resources when device_run fails To: Philipp Zabel Cc: Nicolas Dufresne , Benjamin Gaignard , Mauro Carvalho Chehab , Heiko Stuebner , Ezequiel Garcia , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, me@brighamcampbell.com, jkoolstra@xs4all.nl Content-Type: text/plain; charset="UTF-8" > But right below this, you are still letting > > if (ctx->codec_ops->run(ctx)) > goto err_cancel_job; > > without disabling the clocks. > > > > > @@ -191,8 +192,12 @@ static void device_run(void *priv) > > > > return; > > > > +err_disable_clock: > > + clk_bulk_disable(vpu->variant->num_clocks, ctx->dev->clocks); > > You have added vpu = ctx->dev, why not use vpu->clocks as second > parameter? > > > +err_pm_put_autosuspend: > > + pm_runtime_put_autosuspend(vpu->dev); > > err_cancel_job: > > - hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR); > > + hantro_job_finish_no_pm(vpu, ctx, VB2_BUF_STATE_ERROR); > > Why are you changing ctx->dev to vpu here, but not in the other > function calls in device_run(), e.g. pm_runtime_resume_and_get() and > clk_bulk_enable() above? > > regards > Philipp Hi Philipp, This is embarrassing. I did notice this, made a local change and forgot to re-run git add. I will fix this asap and send a v2. Best, Tharit