From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037AbcICQBM (ORCPT ); Sat, 3 Sep 2016 12:01:12 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:36410 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753860AbcICQBG (ORCPT ); Sat, 3 Sep 2016 12:01:06 -0400 MIME-Version: 1.0 In-Reply-To: <1472824787-107939-1-git-send-email-wangnan0@huawei.com> References: <1472824787-107939-1-git-send-email-wangnan0@huawei.com> From: Nilay Vaish Date: Sat, 3 Sep 2016 10:59:32 -0500 Message-ID: Subject: Re: [PATCH 0/3] perf report: Recognize hugetlb mapping as anon mapping To: Wang Nan Cc: Arnaldo Carvalho de Melo , Linux Kernel list , lizefan@huawei.com, Hou Pengyang , He Kuang , Arnaldo Carvalho de Melo Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2 September 2016 at 08:59, Wang Nan wrote: > The requirement of this function is first proposed at 2015. > Please refer to > > http://lkml.iu.edu/hypermail/linux/kernel/1506.2/02372.html > http://lkml.iu.edu/hypermail/linux/kernel/1506.3/02290.html > http://lkml.iu.edu/hypermail/linux/kernel/1506.3/03512.html > > For systems which use hugetlbfs, if a sample is captured inside > hugetlbfs, perf should not resolve symbols from the file shown in > /prof//mmap, because 'files' in hugetlbfs are constructed > during execution and not ELF files. If user knows positions of > symbols, he/she should provide /tmp/perf-.map file. > > This 3 patches makes perf recognize hugetlbfs mapping as anon mapping. > Before this 3 patches user has no chance to use his/her own .map file > to resolve symbols because perf tries to use hugetlbfs file. > > Wang Nan (3): > perf tools: Recognize hugetlb mapping as anon mapping > tools lib api fs: Add hugetlbfs filesystem detector > perf record: Mark MAP_HUGETLB during synthesizing mmap events > > tools/lib/api/fs/fs.c | 15 +++++++++++++++ > tools/lib/api/fs/fs.h | 1 + > tools/perf/util/event.c | 7 +++++++ > tools/perf/util/map.c | 8 +++++--- > 4 files changed, 28 insertions(+), 3 deletions(-) > > Signed-off-by: Wang Nan > Cc: Hou Pengyang > Cc: He Kuang > Cc: Arnaldo Carvalho de Melo Reviewed-by: Nilay Vaish