From: Nilay Vaish <nilayvaish@gmail.com>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86 <x86@kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] x86, relocs: add function attributes to die()
Date: Sat, 3 Sep 2016 10:16:56 -0500 [thread overview]
Message-ID: <CACbG309_Wa3QcYxCF6WEomEcDefaOjJdNiLqWdAYJgCup7kvvA@mail.gmail.com> (raw)
In-Reply-To: <20160903145037.24685-1-nicolas.iooss_linux@m4x.org>
On 3 September 2016 at 09:50, Nicolas Iooss <nicolas.iooss_linux@m4x.org> wrote:
>
> arch/x86/tools/relocs.c:460:5: error: format specifies type 'int'
> but the argument has type 'Elf64_Xword' (aka 'unsigned long')
> [-Werror,-Wformat]
> sec->shdr.sh_size);
> ^~~~~~~~~~~~~~~~~
> arch/x86/tools/relocs.c:464:5: error: format specifies type 'int'
> but the argument has type 'Elf64_Off' (aka 'unsigned long')
> [-Werror,-Wformat]
> sec->shdr.sh_offset, strerror(errno));
> ^~~~~~~~~~~~~~~~~~~
>
> To support both 32-bit and 64-bit modes, add casts to long types and use
> %lu and %ld to format the numbers.
>
Nicolas, should not just changing the format specifiers fix the
problem? How do those type casts help?
--
Nilay
next prev parent reply other threads:[~2016-09-03 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 14:50 Nicolas Iooss
2016-09-03 15:16 ` Nilay Vaish [this message]
2016-09-03 15:51 ` Nicolas Iooss
2016-09-04 16:51 ` [PATCH v2 " Nicolas Iooss
2016-09-05 15:28 ` Nilay Vaish
2016-10-23 16:47 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACbG309_Wa3QcYxCF6WEomEcDefaOjJdNiLqWdAYJgCup7kvvA@mail.gmail.com \
--to=nilayvaish@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas.iooss_linux@m4x.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®