From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0EBF25783C for ; Thu, 19 Feb 2026 17:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771520682; cv=pass; b=E/4YI50NRZMchgQWGELuyveddgo9uKOfu1c6MWq5oRSWdB1kEICSjRWZU06MQd+L3SWcEAibriy0Scz82bXFcbYvvcHoKHO2gBQOT1GdgTTyaxQoJrWb/SpANT9RGH3k6/XfGBL0jmU4qz5p5iv6/Qdgi6xZX9bT+VJj7JsOV8w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771520682; c=relaxed/simple; bh=b6U1hG3nrOVFz0ecG5N+39M6HPtyrPXlR9zj9WH7HqQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qV8IPsn49znt39o0CUGGtbE9T++E+8bzTig4M8EWikjNrwxGm217ROUfhQmSn9dxwmbZ+ILEoRZa4De4cDIbLasCDaLH8h3XPq7q6GDbzINsdIljgdALy9hSBoKIwA1pAy9EDRSMOfYTy7OXu2zCNXDlFSDlwAJqgun0p6THPsY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=chrisli.org; spf=pass smtp.mailfrom=chrisli.org; arc=pass smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=chrisli.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisli.org Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64ae5f0777dso905273d50.3 for ; Thu, 19 Feb 2026 09:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771520680; cv=none; d=google.com; s=arc-20240605; b=EKQBx4ezBlv2i6GHbap1fAdoqirCPULPl77mU/bWG8QzoRlTsgIc/cpmQOievqiBik onjwIGzZFPubv6ypod8K/y8twzewN46DJp1eMceCqUJjy7MpIWZVVW3MSCFvwG5UzXxJ wmwOr2tYbHWr+id+4+G+znrc9pukktaipgikHhr+/efEfUkewRkp8stvvGrWAhUfEZUq gMHuyqbKXdC7OTxwF1Qxl50DlyTtc94X9qxXhCp29h7hQHjt4+LRMvBT8kQA7S8ScDBA m8rbFl3JixupLMqdjWeazyS0s0uLRg7cNPfXY6Lwc/57DcYxOF6eNcFXdq7GQ4CbGTlt hQJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=GCfnfADMenCdj35GVzlSj1RLfLETxBVqx3iNQnVeu6I=; fh=NXKBCKSVxQcvoBt2YFa0f1Q7Uq/Yol/0by4CmUgXcgw=; b=gia8xr1znruOSSkIGSlGebVm37PyGt+iKfBunE3vN2+syLwmq3AReOA4t/PVUhcQ93 foiCZJaAh1Aj8ULcCaezyYGEVJPkCPmMlDpceO9B3lclbnC0qSuhlx8UMskqAlsd2jMa 2Yv0i4akAOr254UH+7Cbqlyw5VFBwvf97Rf535Sll9g9JSEBP7r27pMLQ0/0Sx4DjTJP CAGpHOnBaL4V5WMcHVGGVqqPDDGTB6wbgHtNp6sg2AnmXmyUEBVhOVglVagYqHAs2SnZ CmmK+eMT84KksvgIGxo0yonq7Cvf072YaO55ujpDpg6dip/NB222LvSYBspqkk8wIns2 yvGA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771520680; x=1772125480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GCfnfADMenCdj35GVzlSj1RLfLETxBVqx3iNQnVeu6I=; b=U7Ryh9wiaAmCjM998I4PA1hpDzTSLHvsP/ckrj0tq1Duq4KdhBfVLBS/I7N60LgITq gu9hPjQ2/mJO+ZbQ0n1WJeO/z6jLsS7difnbb76zgi5XXBms2knjYzzYhyjBIfFKM5QF B9MVDlLp5GTwtZkgtOmwhLTodzIuZ6PnFOwNYHZi3f55FojrY8f2btEGm6XZAb78aU8A OKS8PnFCVjZd1rlYFht3Wmx+olGkc1GKFF3Nkk1NLD7uL+nMdGC7MUywdZ/A2cAsWWQS AFgHliFuxTSopida4gsxgpmNLtYNPgBglnXTk4VwTucGKQPurq2oW5Ikw5DiKAAYd7aa 0XzQ== X-Forwarded-Encrypted: i=1; AJvYcCU7/cV07dyYoB5ksaOLuOsT8IuMxek6t8n1OqGwBxBhtB6vJJB7z5J8h9U8RrrqgSwFkTugLPk1gBEH8RU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx88z9ga4gY7KKTLlOK9mNgkFMjo1XCQCxz1Cz43VO9ZsV1E/Z9 XiYccijcjXFIp1zEwhR/c50DxfiStLEZhHF5NuqFmMKJnGblelinJ5o5J4FEvxfWvTrVt1rPe+f QPwyZzoIbujvFl8Mbe3rfJJpkz5rTO0WMn8h8p0cWug== X-Gm-Gg: AZuq6aLOOAwJcSmPW0J/ghihaZOF0XJeQ0tETBNymLoNFiJDajpDK2HbsWxHQ/7fvKw Lkv0PbXrRI3g5RwN+05oND1xkaBkEEWjioFLTemKBEWLULlMq1mgZAgrh+4BmbR0WZs2MBoUiA1 42gq2HFU9acMU2oxTPL1ebOFOuX9Zc1KDrIXZcNl9z+io12l4wB7FcOioEgRNvkQGZ1cm06tUe2 wT5pLoKTQ3mvlUZFyAycXTaV2xMIpzUtaF/GBJgzQ9yfwD1lfzux7wneQjN29gkwgJKIA7DbiAQ ElJ6QeJuFYbGqNgZ7IY2Xmw3ZgY2fiqmmi+Hdpb9+jLHFtfL X-Received: by 2002:a05:690e:1c1c:b0:649:c375:974c with SMTP id 956f58d0204a3-64c55587d75mr4376174d50.28.1771520680340; Thu, 19 Feb 2026 09:04:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251210010020.GA2522829@google.com> <083ebd92-4b3f-47f8-bf0f-395a604b5f05@kernel.org> In-Reply-To: From: Chris Li Date: Thu, 19 Feb 2026 09:04:29 -0800 X-Gm-Features: AZwV_QgEIU-5ticNLcegsMRlOq6nRWIo8xAridFdMNrLj6Suwr-SXxpNMC8DPy0 Message-ID: Subject: Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters To: "Luck, Tony" Cc: Dan Carpenter , Al Viro , Daniel Gomez , Sami Tolvanen , Eric Biggers , Kees Cook , Luis Chamberlain , Rusty Russell , Petr Pavlu , "linux-modules@vger.kernel.org" , Malcolm Priestley , Mauro Carvalho Chehab , Hans Verkuil , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-hardening@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Tony, Sorry for the late reply. On Fri, Dec 19, 2025 at 8:21=E2=80=AFAM Luck, Tony wr= ote: > > On Fri, Dec 19, 2025 at 03:45:42PM +0300, Dan Carpenter wrote: > > On Fri, Dec 12, 2025 at 02:30:48AM +0900, Daniel Gomez wrote: > > > Maybe the flag fix just needs to be applied to the evaluation? Other = op > > > structs do the same. But Dan's patch did not implement evaluate. E.g.= : > > > > > > static struct symbol_op constant_p_op =3D { > > > .evaluate =3D evaluate_to_int_const_expr, > > > .expand =3D expand_constant_p > > > }; > > > > > > > I was waiting for you to send this as a patch. I can do it if you > > need me to. > > Dan, > > Al Viro thought this was wrong. His alternative patch is here: > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?i= d=3D2634e39bf02697a18fece057208150362c985992 Hi Al, should I pull from your git repo https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/ instead? I saw there is more than one commit. I assume it is ready to pull. Please let me know if I shouldn't. Thanks Chris