From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEE2E19343E for ; Sun, 5 Apr 2026 13:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775394991; cv=pass; b=FzUBmYTt/KwPTdtuGEIMFQiAA2Sn2ywY+dEtokG31+t52xzzMvrmYdCtC/NQNtbQen2/kB+bbjJYLHA2+OQ7+oQAeAgBOJSljUgLn8ltbZh+vTCSLK4x9ALPBuD31uzCX6Z+/eNWBLtN+N0z1c0OkjVZWkuysQdNf7nsJZUdpRc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775394991; c=relaxed/simple; bh=Ly4ReE5ZY6QMSHcoPlSOVHi/ePTv7bG2hci37RTMBJ0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=W0iJKmOmqudp1rnBwnriwGoh+GGxGSdGJUTeOGQKQFh6tQ+ZSUGDtCJz9qIYk+OCezE5CGeigc00FJgbuIBWYzAGZA5EULvRZJemRc90cbggnc2Ql40B4aRYdHMJtGeb/ik0fkqocs3V4/gGsZLB5IEEqCU37/6KJ9lrzxrQqds= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MXlir58r; arc=pass smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MXlir58r" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-66e129e457dso3117835a12.1 for ; Sun, 05 Apr 2026 06:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775394988; cv=none; d=google.com; s=arc-20240605; b=U7R0kNr27ZtREB9fD2TfFBP5xlc0Za75ML0Q7EmPGpjI4kFjm6YHdEyPT0MokhwtKH fArZdR0zXkaqFCtmmcn+mJgSvtcsQDMcFTStcxIqgZCPUZtmyrTRF9Im7JI9vqXA9qyv s0DXOsW6StnKrPWDzmP3FVqyWD7uVZQc7NM/ggjH5/mNJlfk5VdlYlNvrQLB9Gy1jjas /SZyeFxeJJSrt+mFm7NhwmqHjLaigR9b6wImmV8qx3tg0/qbR77v9nHxKZniaPktc+Wm TDlwTVqThZ5LHYtarDyYvk5XlWPh+p3xud6qceoVU7GjLWcoz4mPt6K50TcJOvH8Zwnl Lj7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=xvpYyCRLWgdo1VGzh2pTS+EMDwube+KJdI+DsTN88c8=; fh=cb7xnUMxg6u6ziklJZK8y5r4fINLBsX7sZX0Yjj57wI=; b=AOIcgAt+WA9RnCgDHcasCkkztZVlnegliSpIHoDmSBitXE8Ir0Xefuj9YpwAyN+nFF 77E2SatA2y8PwSLkCN1uPgcPwD2HmBNOMLqMV3VAqf6no+OXjDlVKu0qO2/nMqUN4n3s /2TKv71k6Qkj7aN2Cigma7xqc5OOND3cQxUCRM2k8RtWfuwY+tMmNS4tPcvyRdLw7P42 tULKS2XOMaMU9rwhl0+a6WvweXtL88JS5mGOWwO9c0SXLlGlO1pHxKxHZhqy8c13Ym1B +1e/zeZ7CkIHRq3+mV5M08qf5Ej+H+Nmsq6CjWYIkS0x3780I5FhHG52LnvW4g7F/q0L Bdpg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775394988; x=1775999788; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xvpYyCRLWgdo1VGzh2pTS+EMDwube+KJdI+DsTN88c8=; b=MXlir58rZaiF1fL0ou4L8NR4ozdupNw5J3tO/jbBLCSUa/zAMRlzS6Ojd8FnFy8w6/ zAkzvc6l2G83Zxbd/iZP2+mKWZJvgXFAg/8+hoTaDQJJOBQrR5cjkroU2gM7+3mmzRpU E0LZ37LArDl46yuDyISMZEUV5TJMTxmkGztTyCIAHaGVIz88dRaLhwgsf84Q0KI/NFQ5 uHfDIt4htKnATLT47ZSyeG7rxCP9CyluSNsju1watqUaN95UBiQMBdIcArjUd68BYwj1 TOLKEFekH4nZX5CgzDz++MDzHuQA5zM8Re0Ul7Htpm43Tj4wvI4nE4j+ihpJhB5eZjMa 0uVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775394988; x=1775999788; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xvpYyCRLWgdo1VGzh2pTS+EMDwube+KJdI+DsTN88c8=; b=lKRKrMZ1GPY2I6BOcbP1faqyTQcQAJLFQQJ+tFF3NvtnG1VsqqXylFCqOf3Ju0fWG0 bTnmsiwkogp1uF2BgwTJQkEZl2zvpmDoWblP6VRsvyzv9D2AGVq4i9JDC+iIybdpePA0 IOmeb8N9gUWviibIcIdma7SctncfNPjG7eAoiILOKbV9NA5Iy4MVbU6nBSuNlCbW/itr 1AiXMf0wVUQRP36ezFZ55DV4VxCoBptKSFwadrGprLNxROad9OqFhUTGbDHeGomO1m79 PLBnnU2MYiMvEwXYJ1pD3gFDSShnnVRbbJgxzUFAouaj/B7VWb/I+WlzUsvF3INxZYAP VIvg== X-Forwarded-Encrypted: i=1; AJvYcCWfxyJhIbva1zzJsfUEwHx4k87C9iNCP6BRUDSeVvA0sN5JFKn4pxXDhabu4EFTelz2Nuyw0LEOmcmaVIw=@vger.kernel.org X-Gm-Message-State: AOJu0YyljdTwla+gjERFWSpm1XeONRPOU95T52ZDpLR4sHLC88c7hCiy h906NtW+tELQYQVEy4MwSExKb5G1by80ZT6rQUJgBVTAhV5Z8MOcJz+l9uGn+/Tldjf/RTIBrk+ EU7wcgz3yhrJBLpBwHpM8dtp3iIPTNCw= X-Gm-Gg: AeBDievcQ9HW8J9V8nFaCdnsp7aW61xHuh5hbKJ1GgmkitnZrs/v+vmYs+/xswlBJKH dBKQkzYcmhApxHYJwbZ6IFz4pPugdeo2hsgch7ttdY7gcXvs1T+aQjpmGf/6xUZeY3rsp55ua71 buwVuKaQ0Pxub9JXK7BfK37TMWCAf7SX9Ko6V7++YJ2FOrwreuCIvNLLyOCQUxxCJdz8IBU4QoV 5Z2bvt4RS8q7y9/vMJCJNm/N/qPwzVBl2V+Rokcm1zxrpQn3NVnwvJ1Z9Jk5wZSRVNnseku7TMw Z8D9Yoag0oN69sGdFzME0DqHkre/etWC/qAYrYxjDXXsYPBxphn1RZ2r25A5axHYAPnNkEIRKM4 k9ETCAAWDTgjJ2kMb2BEm X-Received: by 2002:a05:6402:46ce:b0:66e:7071:5ce with SMTP id 4fb4d7f45d1cf-66e70711494mr1989535a12.26.1775394988022; Sun, 05 Apr 2026 06:16:28 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260405082330.4104672-1-fuchsfl@gmail.com> <20260405082330.4104672-2-fuchsfl@gmail.com> In-Reply-To: <20260405082330.4104672-2-fuchsfl@gmail.com> From: Adrian McMenamin Date: Sun, 5 Apr 2026 14:16:16 +0100 X-Gm-Features: AQROBzDcgD0a_IZndD0FdHm8XCslACnezKR1fTlZt0C7HNPV41mNpNkZBBgHe8E Message-ID: Subject: Re: [PATCH 1/2] cdrom: gdrom: replace port I/O with MMIO accessors To: Florian Fuchs Cc: linux-sh@vger.kernel.org, John Paul Adrian Glaubitz , Artur Rojek , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sun, 5 Apr 2026 at 09:23, Florian Fuchs wrote: > > GDROM_DATA_REG is a memory-mapped data register, but the driver uses > outsw() and insw() only for this register. Replace this with local > helpers using MMIO accessors ioread16_rep() / iowrite16_rep(). > > Before, it oopsed accessing the data register, as the io_port_base > P2SEG gets added to the argument in outsw() / insw(), which leads to an > unusable drive: > > BUG: unable to handle kernel paging request at 405f7080 > PC: [<8c28d5b4>] gdrom_spicommand+0x6c/0xb0 > > Signed-off-by: Florian Fuchs > --- > The original Oops can be reproduced just by mounting a disc, like: > mount -t iso9660 -o ro /dev/gdrom /mnt > --- > drivers/cdrom/gdrom.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c > index 4ba4dd06cbf4..dccf41fa5d0a 100644 > --- a/drivers/cdrom/gdrom.c > +++ b/drivers/cdrom/gdrom.c > @@ -171,6 +171,16 @@ static void gdrom_identifydevice(void *buf) > data[c] = __raw_readw(GDROM_DATA_REG); > } > > +static void gdrom_fifo_readw(void *buf, unsigned int words) > +{ > + ioread16_rep((void __iomem *)GDROM_DATA_REG, buf, words); > +} > + > +static void gdrom_fifo_writew(const void *buf, unsigned int words) > +{ > + iowrite16_rep((void __iomem *)GDROM_DATA_REG, buf, words); > +} > + > static void gdrom_spicommand(void *spi_string, int buflen) > { > short *cmd = spi_string; > @@ -198,7 +208,7 @@ static void gdrom_spicommand(void *spi_string, int buflen) > gdrom_getsense(NULL); > return; > } > - outsw(GDROM_DATA_REG, cmd, 6); > + gdrom_fifo_writew(cmd, 6); > } > This is one of those "how did this ever work to begin with" bugs when examined today - bur rather than introduce new local functions can we not just use either readsw(p, d, l)/writesw(p, d, l) or __raw_writew(p,d,l) and __raw_read(p,d,l) directly? Adrian