From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756959AbaCDLAK (ORCPT ); Tue, 4 Mar 2014 06:00:10 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:39668 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756682AbaCDLAH (ORCPT ); Tue, 4 Mar 2014 06:00:07 -0500 MIME-Version: 1.0 In-Reply-To: <53153A4C.9050602@infradead.org> References: <1393899345-7397-1-git-send-email-graeme.gregory@linaro.org> <1393899345-7397-2-git-send-email-graeme.gregory@linaro.org> <1393899715.20435.8.camel@joe-AO722> <53153A4C.9050602@infradead.org> From: Grant Likely Date: Tue, 4 Mar 2014 18:59:46 +0800 X-Google-Sender-Auth: R2H6hoTmmMoo8E4CYOnL0ZTIwEA Message-ID: Subject: Re: [PATCH] MAINTAINERS: add maintainers for arm64 acpi To: Randy Dunlap Cc: Joe Perches , Graeme Gregory , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Linux PM list , ACPI Devel Mailing List , Catalin Marinas , Will Deacon , Len Brown , "Rafael J. Wysocki" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 4, 2014 at 10:28 AM, Randy Dunlap wrote: > On 03/03/2014 06:21 PM, Joe Perches wrote: >> On Tue, 2014-03-04 at 10:15 +0800, Graeme Gregory wrote: >>> Add maintainers for the arm-core file for arm64 ACPI support >> >> Shouldn't something have to be in the kernel >> tree before there's a MAINTAINERS entry? > > or in linux-next and the patch can be added to linux-next (some git tree). Sure, it makes sense to merge this file along with the rest of the series, but I certainly appreciate that Graeme and Hanjun are willing to volunteer to do this work. On Tue, Mar 4, 2014 at 6:23 PM, Catalin Marinas wrote: > On Tue, Mar 04, 2014 at 02:15:45AM +0000, Graeme Gregory wrote: >> +ACPI ARM64 > > That's a pretty broad statement for a single file. Is it core support, > architected peripherals, SoC? That's a good point. Graeme, it would be good if you could put some text in the patch describing how you propose the maintainership to work. Unfortunately the maintainers file doesn't have any kind of comments field, otherwise I'd suggest you make those comments directly there. Given that ACPI can touch a lot of subsystems I would expect you and Hanjun not to be merging much code directly, but being listed in maintainers means that you will be kept in the loop when it comes to merging ARM ACPI changes. I would also expect that anything that does go through you (instead of merely acked) would be merged via Rafael and Len's tree. > >> +M: Hanjun Guo >> +M: Graeme Gregory >> +S: Supported >> +L: linux-acpi@vger.kernel.org >> +F: drivers/acpi/plat/arm-core.c > > This patch should be part of the series introducing the arm-core.c file > and it will be ACKed (or NAKed) following review. We can't really commit > maintainers to a file which does not exist in mainline and while there is > still feedback to be addressed. It's like a blank cheque. I agree with merging it with the rest of the series, but comparing it to a blank cheque is not appropriate. Merely having an entry in MAINTAINERS doesn't immediately confer trust or ability to merge code, but it does tell people who to talk to when looking at ACPI on ARM. You can bet that neither Linus, Len or Rafael will merge ARM ACPI trees from them if you disagree. (And even if they did, you would yell, and Linus would revert it). > > -- > Catalin Graeme, you can add my a-b line: Acked-by: Grant Likely