From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F0A389471 for ; Mon, 1 Jun 2026 08:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780301714; cv=none; b=Qn39293Y4mZDaXXJOEaXlSwmGjBVOB+R/q1bTnIhB48/gRisfJnj/moW8Akkd8PfmOE1kBOXAELpwhynJ/8u/bX4lXYAVht9Va5amHKXgxmMTZ/bqq7YlJ9Iw9K8yuiHbVUtLHY5cUzqS4uOpQMzlybveVQvudGN3B184/Zhumo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780301714; c=relaxed/simple; bh=y6ZZGd5HZp+4cfuli6ST+EnFldsgQkO/jKSkyGstQ4I=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AACee3ep/WKcpieUxpr6LcqDwmUPmamKrhxN8TTUjruvx/VGpXNr3l2JL1nsnZ3F9csJgegG7JbC2BRPVIgg2nUOe3IpyOWd1N0fJ0YTo0uGOu6gzH1SNn4vaMsdB96gtMd38mu7c+P6kuvUQ8DKBAS8vT6/BI2Q86GandRlX4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Aq5KUCVO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Aq5KUCVO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A17F11F0089B for ; Mon, 1 Jun 2026 08:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780301712; bh=y6ZZGd5HZp+4cfuli6ST+EnFldsgQkO/jKSkyGstQ4I=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=Aq5KUCVOBlghWDsbPG24Jax1mq5werm58ZV097OjC0eCa9LYgxRSF8P9PG+KyU37m b7ZcqJ3q3v170if+MwV8veM8dtRWcV8uqy2WVLy1m3tUF27sQkm8ouGCDJjgOkgHOL 9HFkCN4as3GPaV+eauIm75nW1CAS4NtUedVf4N9AeyFlXVSQwy1CwbzVTrEgr3TUl4 06AbSDye3wimrPkv8nItUAiIIIWL3jre5TwGUkItVzPMb7zp/6d94Xm7IjD9X2KeN9 9LvfiJFDCjz+peeQNuDkbpJjj/4HCvdxdgFoe8BQYe78BU/m+vQoLXMLFKKBstO1kM rzSQIknLY92iQ== Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-396775c26f9so8967761fa.3 for ; Mon, 01 Jun 2026 01:15:12 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ+N3bzW2c0goTf9BQdUrX5NS6xWg8///VXS59wNl7VcS3FcDWNIuaEo2khE/MllnpF3igsXjuAnyoHhNIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm84yrEvE6ytuRt+TcyRZmaZx9ryBFanYbAPVrRY/O5iNjOhJ9 q9595QsznFnjLqeKEHgfv13a4r5Ee++kSEoOtWqXiS/bogDMmh+xSEnS9KWRnsDPkzbvfScjEUf i7LfDigYukrJAwm9lQ5HFaIm1aeE1CVA= X-Received: by 2002:a05:6512:1096:b0:5aa:6155:d645 with SMTP id 2adb3069b0e04-5aa6155d7b2mr3333446e87.44.1780301711363; Mon, 01 Jun 2026 01:15:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260530-realtek_forward-v10-0-d14b51e6a69d@gmail.com> <20260530-realtek_forward-v10-2-d14b51e6a69d@gmail.com> In-Reply-To: <20260530-realtek_forward-v10-2-d14b51e6a69d@gmail.com> From: Linus Walleij Date: Mon, 1 Jun 2026 10:14:58 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4JKlUQb-NZDzEpuQj9TvCsW3m-2dCsJdI6YAp6-KkVhLYf2Ec21PvkGoWA Message-ID: Subject: Re: [net-next PATCH v10 2/9] net: dsa: realtek: rtl8365mb: reject unsupported topologies To: Luiz Angelo Daros de Luca Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 30, 2026 at 12:51=E2=80=AFPM Luiz Angelo Daros de Luca wrote: > Explicitly enforce the presence of a CPU port (-EINVAL) and reject DSA > cascade links (-EOPNOTSUPP) during setup to prevent silent failures. > > These topologies were already non-functional. Without a CPU port, the > driver does not activate CPU tagging. Additionally, the switch hardware > was not designed to be cascaded, and DSA links never worked because > CPU tagging is not enabled for them. > > Signed-off-by: Luiz Angelo Daros de Luca Reviewed-by: Linus Walleij Yours, Linus Walleij