mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linusw@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: brgl@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org,  afaerber@suse.com, wbg@kernel.org,
	mathieu.dubois-briand@bootlin.com,  mwalle@kernel.org,
	lars@metafoo.de, Michael.Hennerich@analog.com,  jic23@kernel.org,
	nuno.sa@analog.com, andy@kernel.org, dlechner@baylibre.com,
	 tychang@realtek.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-realtek-soc@lists.infradead.org,
	linux-iio@vger.kernel.org,  cy.huang@realtek.com,
	stanley_chang@realtek.com, james.tai@realtek.com,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 3/7] gpio: regmap: Add gpio_regmap_operation and write-enable support
Date: Wed, 13 May 2026 09:40:02 +0200	[thread overview]
Message-ID: <CAD++jLkdq+43N11xNVNvq3wYhhDzvFZ=yJL-SCRDhQPbCAVQLg@mail.gmail.com> (raw)
In-Reply-To: <20260512033317.1602537-4-eleanor.lin@realtek.com>

Hi Yu-Chun,

thanks for your patch! I really like the direction this is taking.

On Tue, May 12, 2026 at 5:33 AM Yu-Chun Lin <eleanor.lin@realtek.com> wrote:

> Extend the reg_mask_xlate callback with an operation type parameter
> (gpio_regmap_operation) to allow drivers to return different
> register/mask combinations for different GPIO operations.
>
> Also add write-enable mechanism for hardware that requires setting a
> write-enable bit before modifying GPIO control registers.
>
> Consequently, update all existing drivers utilizing the gpio-regmap
> framework (across drivers/gpio, drivers/iio, and drivers/pinctrl)
> to accommodate the new reg_mask_xlate function signature.
>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>

linusw@kernel.org these days.

> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>

The rest of the comments I had Andy, Jonathan and Sashiko has
already pointed out, just hash through it and this will look really
nice in the end.

Yours,
Linus Walleij

  parent reply	other threads:[~2026-05-13  7:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  3:33 [PATCH v3 0/7] gpio: realtek: Add support for Realtek DHC RTD1625 Yu-Chun Lin
2026-05-12  3:33 ` [PATCH v3 1/7] gpio: Replace "default y" with "default ARCH_REALTEK" in Kconfig Yu-Chun Lin
2026-05-12  3:33 ` [PATCH v3 2/7] gpio: regmap: add gpio_regmap_get_gpiochip() accessor Yu-Chun Lin
2026-05-12 11:20   ` Andy Shevchenko
2026-05-25 12:04     ` Yu-Chun Lin [林祐君]
2026-06-03  0:34       ` Andy Shevchenko
2026-06-08 14:10         ` Bartosz Golaszewski
2026-06-08 14:41           ` Michael Walle
2026-06-17  8:36             ` Yu-Chun Lin [林祐君]
2026-06-17  8:44               ` Michael Walle
2026-06-17  9:54                 ` Yu-Chun Lin [林祐君]
2026-06-17 11:19                   ` Michael Walle
2026-06-19 21:08             ` Linus Walleij
2026-06-22 10:35               ` Andy Shevchenko
2026-06-30 13:21                 ` Linus Walleij
2026-07-01  8:44               ` Michael Walle
2026-07-01 10:01                 ` Andy Shevchenko
2026-07-01 10:55                   ` Andy Shevchenko
2026-07-01 11:38                     ` Andy Shevchenko
2026-07-01 11:42                       ` Michael Walle
2026-07-01 12:03                         ` Andy Shevchenko
2026-07-01 11:38                     ` Michael Walle
2026-07-01 12:08                       ` Andy Shevchenko
2026-05-12  3:33 ` [PATCH v3 3/7] gpio: regmap: Add gpio_regmap_operation and write-enable support Yu-Chun Lin
2026-05-12 11:26   ` Andy Shevchenko
2026-05-12 14:37   ` Jonathan Cameron
2026-07-09 17:21     ` Yu-Chun Lin [林祐君]
2026-07-16  6:26       ` Yu-Chun Lin
2026-07-16  7:15         ` Michael Walle
2026-07-16  8:27         ` Andy Shevchenko
2026-07-16  9:08           ` Michael Walle
2026-07-16  9:40             ` Andy Shevchenko
2026-07-16 10:47               ` Yu-Chun Lin [林祐君]
2026-07-16 11:03                 ` Michael Walle
2026-07-16 11:21                   ` Yu-Chun Lin [林祐君]
2026-07-16 11:42                     ` Michael Walle
2026-07-16 12:08                       ` Yu-Chun Lin [林祐君]
2026-07-16 10:55               ` Michael Walle
2026-07-16 17:56                 ` Andy Shevchenko
2026-07-17 15:38                   ` Yu-Chun Lin [林祐君]
2026-07-17 18:11                     ` Andy Shevchenko
2026-05-13  7:40   ` Linus Walleij [this message]
2026-05-12  3:33 ` [PATCH v3 4/7] gpio: regmap: Add set_config callback Yu-Chun Lin
2026-05-12 18:12   ` Andy Shevchenko
2026-05-12  3:33 ` [PATCH v3 5/7] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio Yu-Chun Lin
2026-05-12  3:33 ` [PATCH v3 6/7] gpio: realtek: Add driver for Realtek DHC RTD1625 SoC Yu-Chun Lin
2026-05-12 18:50   ` Andy Shevchenko
2026-05-12  3:33 ` [PATCH v3 7/7] arm64: dts: realtek: Add GPIO support for RTD1625 Yu-Chun Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD++jLkdq+43N11xNVNvq3wYhhDzvFZ=yJL-SCRDhQPbCAVQLg@mail.gmail.com' \
    --to=linusw@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=afaerber@suse.com \
    --cc=andy@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cy.huang@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eleanor.lin@realtek.com \
    --cc=james.tai@realtek.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=stanley_chang@realtek.com \
    --cc=tychang@realtek.com \
    --cc=wbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox